qiurui
/
glibc
mirror of git://sourceware.org/git/glibc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
37,381 Commits 248 Branches 1,652 Tags 256 MiB
Commit Graph

14121 Commits

Author SHA1 Message Date
Florian Weimer ac0353af81 Linux: Remove remaining references to $(shared-thread-library) 
Since the variable expands to nothing under Linux, it is no longer
necessary to clutter the makefiles with it.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-25 11:30:23 +02:00
Florian Weimer 3b638095a5 nptl: Do not install libpthread.so and do not link tests with it 
Keep installing libpthread.a, so that -lpthread works.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-25 11:30:23 +02:00
Nicholas Piggin 7de36744ee powerpc: Fix handling of scv return error codes [BZ #27892] 
When using scv for templated ASM syscalls, current code interprets any
negative return value as error, but the only valid error codes are in
the range -4095..-1 according to the ABI.

This commit also fixes 'signal.gen.test' strace test, where the issue
was first identified.

Reviewed-by: Matheus Castanho <msc@linux.ibm.com>
 2021-05-24 17:01:40 -03:00
H.J. Lu 79aec84102 Properly check stack alignment [BZ #27901] 
1. Replace

if ((((uintptr_t) &_d) & (__alignof (double) - 1)) != 0)

which may be optimized out by compiler, with

int
__attribute__ ((weak, noclone, noinline))
is_aligned (void *p, int align)
{
  return (((uintptr_t) p) & (align - 1)) != 0;
}

2. Add TEST_STACK_ALIGN_INIT to TEST_STACK_ALIGN.
3. Add a common TEST_STACK_ALIGN_INIT to check 16-byte stack alignment
for both i386 and x86-64.
4. Update powerpc to use TEST_STACK_ALIGN_INIT.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
 2021-05-24 07:42:12 -07:00
Noah Goldstein 1b992204f6 x86: Improve memmove-vec-unaligned-erms.S 
This patch changes the condition for copy 4x VEC so that if length is
exactly equal to 4 * VEC_SIZE it will use the 4x VEC case instead of
8x VEC case.

Results For Skylake memcpy-avx2-erms
size, al1 , al2 , Cur T   , New T   , Win , New / Cur
128 , 0   , 0   , 9.137   , 6.873   , New , 75.22
128 , 7   , 0   , 12.933  , 7.732   , New , 59.79
128 , 0   , 7   , 11.852  , 6.76    , New , 57.04
128 , 7   , 7   , 12.587  , 6.808   , New , 54.09

Results For Icelake memcpy-evex-erms
size, al1 , al2 , Cur T   , New T   , Win , New / Cur
128 , 0   , 0   , 9.963   , 5.416   , New , 54.36
128 , 7   , 0   , 16.467  , 8.061   , New , 48.95
128 , 0   , 7   , 14.388  , 7.644   , New , 53.13
128 , 7   , 7   , 14.546  , 7.642   , New , 52.54

Results For Tigerlake memcpy-evex-erms
size, al1 , al2 , Cur T   , New T   , Win , New / Cur
128 , 0   , 0   , 8.979   , 4.95    , New , 55.13
128 , 7   , 0   , 14.245  , 7.122   , New , 50.0
128 , 0   , 7   , 12.668  , 6.675   , New , 52.69
128 , 7   , 7   , 13.042  , 6.802   , New , 52.15

Results For Skylake memmove-avx2-erms
size, al1 , al2 , Cur T   , New T   , Win , New / Cur
128 , 0   , 32  , 6.181   , 5.691   , New , 92.07
128 , 32  , 0   , 6.165   , 5.752   , New , 93.3
128 , 0   , 7   , 13.923  , 9.37    , New , 67.3
128 , 7   , 0   , 12.049  , 10.182  , New , 84.5

Results For Icelake memmove-evex-erms
size, al1 , al2 , Cur T   , New T   , Win , New / Cur
128 , 0   , 32  , 5.479   , 4.889   , New , 89.23
128 , 32  , 0   , 5.127   , 4.911   , New , 95.79
128 , 0   , 7   , 18.885  , 13.547  , New , 71.73
128 , 7   , 0   , 15.565  , 14.436  , New , 92.75

Results For Tigerlake memmove-evex-erms
size, al1 , al2 , Cur T   , New T   , Win , New / Cur
128 , 0   , 32  , 5.275   , 4.815   , New , 91.28
128 , 32  , 0   , 5.376   , 4.565   , New , 84.91
128 , 0   , 7   , 19.426  , 14.273  , New , 73.47
128 , 7   , 0   , 15.924  , 14.951  , New , 93.89

Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
 2021-05-23 22:50:49 -04:00
Florian Weimer 49e182c737 nptl: Remove remaining code from libpthread 
Only the placeholder compatibility symbols are left now.

The __errno_location symbol was removed (moved) using
scripts/move-symbol-to-libc.py.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-21 22:35:01 +02:00
Florian Weimer f47f1d91af nptl: Move pthread_create, thrd_create into libc 
The symbols were moved using scripts/move-symbol-to-libc.py.

The libpthread placeholder symbols need some changes because some
symbol versions have gone away completely.  But
__errno_location@@GLIBC_2.0 still exists, so the GLIBC_2.0 version
is still there.

The internal __pthread_create symbol now points to the correct
function, so the sysdeps/nptl/thrd_create.c override is no longer
necessary.

There was an issue how the hidden alias of pthread_getattr_default_np
was defined, so this commit cleans up that aspects and removes the
GLIBC_PRIVATE export altogether.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-21 22:35:00 +02:00
Florian Weimer d03511f48f nptl: Eliminate the __static_tls_size, __static_tls_align_m1 variables 
Use the  __nptl_tls_static_size_for_stack inline function instead,
and the GLRO (dl_tls_static_align) value directly.

The computation of GLRO (dl_tls_static_align)  in
_dl_determine_tlsoffset ensures that the alignment is at least
TLS_TCB_ALIGN, which at least STACK_ALIGN (see allocate_stack).
Therefore, the additional rounding-up step is removed.

ALso move the initialization of the default stack size from
__pthread_initialize_minimal_internal to __pthread_early_init.
This introduces an extra system call during single-threaded startup,
but this simplifies the initialization sequence.  No locking is
needed around the writes to __default_pthread_attr because the
process is single-threaded at this point.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-21 22:35:00 +02:00
Noah Goldstein 6abf27980a x86: Improve memset-vec-unaligned-erms.S 
No bug. This commit makes a few small improvements to
memset-vec-unaligned-erms.S. The changes are 1) only aligning to 64
instead of 128. Either alignment will perform equally well in a loop
and 128 just increases the odds of having to do an extra iteration
which can be significant overhead for small values. 2) Align some
targets and the loop. 3) Remove an ALU from the alignment process. 4)
Reorder the last 4x VEC so that they are stored after the loop. 5)
Move the condition for leq 8x VEC to before the alignment
process. test-memset and test-wmemset are both passing.

Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
 2021-05-20 17:28:33 -04:00
Florian Weimer f5e196b5a0 Hurd: Define ARCH_MIN_GUARD_SIZE in internal <pthread.h> 
This macro is always defined on Linux.

Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
 2021-05-20 18:56:57 +02:00
Florian Weimer 1805bf753f s390x: Check HWCAP bits against compiler flags 
When compiled with GCC 11.1 and -march=z14 -O3 build flags, running
ld.so (or any dynamically linked program) prints:

Fatal glibc error: CPU lacks VXE support (z14 or later required)

Co-Authored-By: Stefan Liebler <stli@linux.ibm.com>
Reviewed-by: Stefan Liebler <stli@linux.ibm.com>
 2021-05-19 11:09:57 +02:00
Florian Weimer d337345ce1 powerpc64le: Check HWCAP bits against compiler build flags 
When built with GCC 11.1 and -mcpu=power9, ld.so prints this error
message when running on POWER8:

Fatal glibc error: CPU lacks ISA 3.00 support (POWER9 or later required)
 2021-05-19 11:09:57 +02:00
Florian Weimer eb24865637 elf: Add hook for checking HWCAP bits after auxiliary vector parsing 
Reviewed-by: Stefan Liebler <stli@linux.ibm.com>
 2021-05-19 11:09:57 +02:00
Noah Goldstein 4ad473e97a x86: Optimize memcmp-evex-movbe.S 
No bug. This commit optimizes memcmp-evex.S. The optimizations include
adding a new vec compare path for small sizes, reorganizing the entry
control flow, removing some unnecissary ALU instructions from the main
loop, and most importantly replacing the heavy use of vpcmp + kand
logic with vpxor + vptern. test-memcmp and test-wmemcmp are both
passing.

Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
 2021-05-18 22:57:51 -04:00
Noah Goldstein 16d12015c5 x86: Optimize memcmp-avx2-movbe.S 
No bug. This commit optimizes memcmp-avx2.S. The optimizations include
adding a new vec compare path for small sizes, reorganizing the entry
control flow, and removing some unnecissary ALU instructions from the
main loop. test-memcmp and test-wmemcmp are both passing.

Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
 2021-05-18 22:57:44 -04:00
Adhemerval Zanella 3f500e7202 linux: Fix clock_getres fallback 
The tst-timespec_getres (e5ac7bd679) triggers an issue on 32-bit
architecture on Linux older than 5.1, where the fallback syscall
is used.

Checked on powerpc-linux-gnu.
 2021-05-18 16:59:56 -03:00
Samuel Thibault 4d4bb451d5 hurd: Add execveat 2021-05-18 09:36:00 +00:00
Joseph Myers e5ac7bd679 Add C2X timespec_getres 
ISO C2X adds a timespec_getres function alongside the C11
timespec_get, with functionality similar to that of POSIX clock_getres
(including allowing a NULL pointer to be passed to the function).
Implement this function for glibc, similarly to the implementation of
timespec_get.

This includes a basic test like that of timespec_get, but no
documentation in the manual, given that TIME_UTC and timespec_get
aren't documented in the manual at all.  The handling of 64-bit time
follows that in timespec_get; people maintaining patch series for
64-bit time will need to update them accordingly (to export
__timespec_getres64, redirect calls in time.h and run the test for
_TIME_BITS=64).

Tested for x86_64 and x86, and (previous version; only testcase
differs) with build-many-glibcs.py.
 2021-05-17 20:55:21 +00:00
Matheus Castanho 1a594aa986 powerpc: Add optimized rawmemchr for POWER10 
Reuse code for optimized strlen to implement a faster version of rawmemchr.
This takes advantage of the same benefits provided by the strlen implementation,
but needs some extra steps. __strlen_power10 code should be unchanged after this
change.

rawmemchr returns a pointer to the char found, while strlen returns only the
length, so we have to take that into account when preparing the return value.

To quickly check 64B, the loop on __strlen_power10 merges the whole block into
16B by using unsigned minimum vector operations (vminub) and checks if there are
any \0 on the resulting vector. The same code is used by rawmemchr if the char c
is 0. However, this approach does not work when c != 0.  We first need to
subtract each byte by c, so that the value we are looking for is converted to a
0, then taking the minimum and checking for nulls works again.

The new code branches after it has compared ~256 bytes and chooses which of the
two strategies above will be used in the main loop, based on the char c. This
extra branch adds some overhead (~5%) for length ~256, but is quickly amortized
by the faster loop for larger sizes.

Compared to __rawmemchr_power9, this version is ~20% faster for length < 256.
Because of the optimized main loop, the improvement becomes ~35% for c != 0
and ~50% for c = 0 for strings longer than 256.

Reviewed-by: Lucas A. M. Magalhaes <lamm@linux.ibm.com>
Reviewed-by: Raphael M Zinsly <rzinsly@linux.ibm.com>
 2021-05-17 10:30:35 -03:00
Florian Weimer 2d53566ec3 nptl: Move pthread_sigqueue into libc 
The symbol was moved using scripts/move-symbol-to-libc.py.

The GLIBC_2.11 version is now empty, so add a placeholder symbol.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-17 10:25:12 +02:00
Florian Weimer 56f823abd4 nptl: Move pthread_setschedprio into libc 
The symbol was moved using scripts/move-symbol-to-libc.py.

The GLIBC_2.3.4 version is now empty, so add a placeholder symbol.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-17 10:25:12 +02:00
Florian Weimer 8bc6a6d73c nptl: Move pthread_setname_np into libc 
The symbol was moved using scripts/move-symbol-to-libc.py.

Add __libpthread_version_placeholder@@GLIBC_2.12 for the targets
that need it.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-17 10:25:12 +02:00
Florian Weimer 7b300ec7f9 nptl: Move pthread_setaffinity_np into libc 
The symbol was moved using scripts/move-symbol-to-libc.py.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-17 10:25:12 +02:00
Florian Weimer c924e44acd nptl: Move pthread_getname_np into libc 
The symbol was moved using scripts/move-symbol-to-libc.py.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-17 10:25:12 +02:00
Florian Weimer 310e59e64c nptl: Move pthread_getcpuclockid into libc 
The symbol was moved using scripts/move-symbol-to-libc.py.

__libpthread_version_placeholder@@GLIBC_2.2 is needed by this change;
the Versions entry for GLIBC_2.2 in libpthread had leftover symbols
due to an error in a previous conflict resolution.  The condition
for the placeholder symbol is complicated because some architectures
have earlier symbols at the GLIBC_2.2 symbol versions, so the
placeholder is not required there (yet).

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-17 10:25:11 +02:00
Florian Weimer e948be4db3 nptl: Replace pthread_getcpuclockid with Linux implementation 
Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-17 10:25:11 +02:00
Florian Weimer 8f72bed1aa nptl: Move pthread_getattr_default_np into libc 
The symbol was moved using scripts/move-symbol-to-libc.py.

A new placeholder symbol __libpthread_version_placeholder@GLIBC_2.18
is needed to keep the GLIBC_2.18 symbol version in libpthread.
The __pthread_getattr_default_np@@GLIBC_PRIVATE export is used
from pthread_create.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-17 10:25:11 +02:00
Florian Weimer 9dc21009a4 elf: Move static TLS size and alignment into _rtld_global_ro 
This helps to clarify that the caching of these fields in libpthread
(in __static_tls_size, __static_tls_align_m1) is unnecessary.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-17 10:17:41 +02:00
Florian Weimer 0b3e92bdf3 elf: Remove DL_STATIC_INIT 
All users have been converted to the __rtld_static_init mechanism.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-17 10:08:19 +02:00
Florian Weimer b7fc189f7f powerpc: Remove _dl_var_init 
The generic __rtld_static_init code handles GLRO (dl_pagesize),
GLRO (dl_auxv), GLRO (dl_hwcap), GLRO (dl_hwcap2).
GLRO (dl_cache_line_size) is handled in an __rtld_static_init_arch
override.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-17 10:08:17 +02:00
Florian Weimer d0cae071f3 mips: Remove _dl_var_init 
The generic __rtld_static_init code handles GLRO (dl_pagesize).

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-17 10:08:14 +02:00
Florian Weimer 9da94f4594 m68k: Remove _dl_var_init 
The generic __rtld_static_init code handles GLRO (dl_pagesize).

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-17 10:08:12 +02:00
Florian Weimer b097f280cd ia64: Remove _dl_var_init 
The generic __rtld_static_init code handles GLRO (dl_pagesize)
and GLRO (dl_clktck).

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-17 10:08:09 +02:00
Florian Weimer 65e1340e32 arc: Remove _dl_var_init 
The generic __rtld_static_init code handles GLRO (dl_pagesize).

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-17 10:08:05 +02:00
Florian Weimer bdc90abc48 aarch64: Remove _dl_var_init 
The generic __rtld_static_init code handles GLRO (dl_pagesize).

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-17 10:07:44 +02:00
Florian Weimer 78b31cc834 elf: Partially initialize ld.so after static dlopen (bug 20802) 
After static dlopen, a copy of ld.so is loaded into the inner
namespace, but that copy is not initialized at all.  Some
architectures run into serious problems as result, which is why the
_dl_var_init mechanism was invented.  With libpthread moving into
libc and parts into ld.so, more architectures impacted, so it makes
sense to switch to a generic mechanism which performs the partial
initialization.

As a result, getauxval now works after static dlopen (bug 20802).

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-17 10:06:57 +02:00
Florian Weimer a78e5979a9 nptl: Move __nptl_initial_report_events into ld.so/startup code 
The initialization of the report_events TCB field is now performed
in __tls_init_tp instead of __pthread_initialize_minimal_internal
(in libpthread).

The events interface is difficult to test because GDB stopped using it
in 2015.  The td_thr_get_info change to ignore lookup issues is enough
to support GDB with this change.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-17 10:04:06 +02:00
Joseph Myers 7a7bcddeef Make sysdeps/generic/libc.abilist empty 
The __libc_single_threaded symbol was accidentally added to this file
in commit 706ad1e7af.
 2021-05-13 21:28:17 +00:00
Siddhesh Poyarekar 900962f37f linux/check_native: Always close socket on return 
The error paths of __check_native would leave the socket FD open on
return, resulting in an FD leak.  Rework function exit paths so that
the fd is always closed on return.
 2021-05-12 15:53:33 +05:30
Florian Weimer fec776b827 nptl: Move pthread_getconcurrency, pthread_setconcurrency into libc 
The symbols were moved using scripts/move-symbol-to-libc.py,
in one commit due to their dependency on the internal
__concurrency_level variable.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-11 20:33:14 +02:00
Florian Weimer d7c51fe4f0 nptl: Move pthread_cancel into libc 
The symbol was moved using scripts/move-symbol-to-libc.py.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-11 20:21:30 +02:00
Florian Weimer c4c53e0f56 nptl: Move __pthread_register_cancel_defer, __pthread_unregister_cancel_restore to libc 
The symbols were moved using scripts/move-symbol-to-libc.py.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-11 20:21:27 +02:00
Florian Weimer 3ec8b1c7a9 nptl: Move __pthread_register_cancel, __pthread_unregister_cancel to libc 
The symbols were moved using scripts/move-symbol-to-libc.py.

Also clean up some unwinder linking leftover in the same spot
in nptl/pthreadP.h.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-11 20:20:58 +02:00
Florian Weimer 870218fb30 nptl: Move pthread_attr_setstacksize into libc 
The symbol was moved using scripts/move-symbol-to-libc.py.

It is necessary to arrange for a
__libpthread_version_placeholder@GLIBC_2.6 on some of the powerpc
targets.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-11 19:33:20 +02:00
Florian Weimer 736c57c96c nptl: Move pthread_attr_setstackaddr into libc 
The symbol was moved using scripts/move-symbol-to-libc.py.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-11 19:33:19 +02:00
Florian Weimer b855e52bae nptl: Move pthread_attr_setstack into libc 
The symbol was moved using scripts/move-symbol-to-libc.py.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-11 19:33:17 +02:00
Florian Weimer da069d1714 nptl: Move pthread_attr_setguardsize into libc 
The symbol was moved using scripts/move-symbol-to-libc.py.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-11 19:33:15 +02:00
Florian Weimer ee092efed4 nptl: Move pthread_attr_getstacksize into libc 
The symbol was moved using scripts/move-symbol-to-libc.py.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-11 19:33:14 +02:00
Florian Weimer b5e75df2a5 nptl: Move pthread_attr_getstackaddr into libc 
The symbol was moved using scripts/move-symbol-to-libc.py.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-11 19:33:13 +02:00
Florian Weimer fb7abc3441 nptl: Move pthread_attr_getstack into libc 
The symbol was moved using scripts/move-symbol-to-libc.py.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 2021-05-11 19:33:11 +02:00