This patch removes the mknod and mknodat static wrapper and add the
symbols on the libc with the expected names.
Both the prototypes of the internal symbol linked by the static
wrappers and the inline redirectors are also removed from the installed
sys/stat.h header file. The wrapper implementation license LGPL
exception is also removed since it is no longer statically linked to
binaries.
Internally the _STAT_VER* definitions are moved to the arch-specific
xstatver.h file.
Checked with a build for all affected ABIs. I also checked on x86_64,
i686, powerpc, powerpc64le, sparcv9, sparc64, s390, and s390x.
Reviewed-by: Lukasz Majewski <lukma@denx.de>
This patch removes the stat, stat64, lstat, lstat64, fstat, fstat64,
fstatat, and fstatat64 static wrapper and add the symbol on the libc
with the expected names.
Both the prototypes of the internal symbol linked by the static
wrappers and the inline redirectors are also removed from the installed
sys/stat.h header file. The wrapper implementation license LGPL
exception is also removed since it is no longer statically linked to
binaries.
Internally the _STAT_VER* definitions are moved to a arch-specific
xstatver.h file. The internal defines that redirects internals
{f}stat{at} to their {f}xstat{at} counterparts are removed for Linux
(!NO_RTLD_HIDDEN). Hurd still requires them since {f}stat{at} pulls
extra objects that makes the loader build fail otherwise (I haven't
dig into why exactly).
Checked with a build for all affected ABIs. I also checked on x86_64,
i686, powerpc, powerpc64le, sparcv9, sparc64, s390, and s390x.
Reviewed-by: Lukasz Majewski <lukma@denx.de>
On 21/05/15 05:29, Siddhesh Poyarekar wrote:
> On Wed, May 20, 2015 at 06:55:02PM +0100, Szabolcs Nagy wrote:
>> i guess it's ok for consistency if i fix struct stat64
>> too to use __USE_XOPEN2K8.
>>
>> i will run some tests and come back with a patch
>
> I also think it would be appropriate to change this code in other
> architectures (microblaze and nacl IIRC) to make all of them
> consistent. It is a mechanical enough change IMO that all arch
> maintainer acks is not necessary.
>
here is the patch with consistent __USE_XOPEN2K8
ok to commit?
2015-05-21 Szabolcs Nagy <szabolcs.nagy@arm.com>
[BZ #18234]
* conform/data/sys/stat.h-data (struct stat): Add tests for st_atim,
st_mtim and st_ctim members.
* sysdeps/nacl/bits/stat.h (struct stat, struct stat64): Make
st_atim, st_ctim, st_mtim visible under __USE_XOPEN2K8 only.
* sysdeps/unix/sysv/linux/generic/bits/stat.h (struct stat,):
(struct stat64): Likewise.
* sysdeps/unix/sysv/linux/ia64/bits/stat.h (struct stat,):
(struct stat64): Likewise.
* sysdeps/unix/sysv/linux/microblaze/bits/stat.h (struct stat,):
(struct stat64): Likewise.
* sysdeps/unix/sysv/linux/bits/stat.h: Protect UTIME_NOW and
UTIME_OMIT only with __USE_ATFILE.
* sysdeps/unix/sysv/linux/ia64/bits/stat.h: Likewise.
* sysdeps/unix/sysv/linux/powerpc/bits/stat.h: Likewise.
* sysdeps/unix/sysv/linux/s390/bits/stat.h: Likewise.
* sysdeps/unix/sysv/linux/sparc/bits/stat.h: Likewise.
* sysdeps/unix/sysv/linux/x86_64/bits/stat.h: Likewise.
* io/sys/stat.h: Move mknodat definition into same conditional as
mknod.
* time/sys/time.h: futimesat is not among the functions accepted
into the POSIX standard.
2001-07-06 Paul Eggert <eggert@twinsun.com>
* manual/argp.texi: Remove ignored LGPL copyright notice; it's
not appropriate for documentation anyway.
* manual/libc-texinfo.sh: "Library General Public License" ->
"Lesser General Public License".
2001-07-06 Andreas Jaeger <aj@suse.de>
* All files under GPL/LGPL version 2: Place under LGPL version
2.1.
* sysdeps/unix/sysv/linux/ia64/bits/stat.h: Correct position of
st_blocks member in stat and stat64 structs.
Patch by Bill Nottingham <notting@redhat.com>.
2000-06-16 Jes Sorensen <jes@linuxcare.com>
* sysdeps/unix/sysv/linux/ia64/xstat.c: New file.
* sysdeps/unix/sysv/linux/ia64/fxstat.c: New file.
* sysdeps/unix/sysv/linux/ia64/lxstat.c: New file.
* sysdeps/unix/sysv/linux/ia64/xstatconv.c: Deleted.
* sysdeps/unix/sysv/linux/ia64/bits/stat.h: Update after latest
kernel change.
* sysdeps/unix/sysv/linux/ia64/bits/types.h: Make __ino_t,
__nlink_t and __blkcnt_t 64 bit to accomodate new kernel stat data
structure.
Change __fsblkcnt_t and __fsfilcnt_t to 64 bit to match kernel
implementation.
2000-06-15 Jes Sorensen <jes@linuxcare.com>
* sysdeps/unix/sysv/linux/ia64/kernel_stat.h: Deleted.
2000-06-08 Jes Sorensen <jes@linuxcare.com>
* sysdeps/unix/sysv/linux/ia64/mmap64.c: New file.
2000-06-12 Jes Sorensen <jes@linuxcare.com>
* sysdeps/unix/sysv/linux/ia64/kernel_stat.h: New file.
* sysdeps/unix/sysv/linux/ia64/xstatconv.c: New file.
* sysdeps/unix/sysv/linux/ia64/bits/stat.h: New file.
* sysdeps/unix/sysv/linux/ia64/fxstat64.c: New file.
* sysdeps/unix/sysv/linux/ia64/lxstat64.c: New file.
* sysdeps/unix/sysv/linux/ia64/xstat64.c: New file.
Adhemerval Zanella
Joseph Myers
Paul Eggert
Mike Frysinger
Szabolcs Nagy
Ulrich Drepper
Ulrich Drepper
Andreas Jaeger