qiurui
/
glibc
mirror of git://sourceware.org/git/glibc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove dead regex code 

* posix/regex_internal.c (re_node_set_insert):
Remove unnecessary assignment.  Reported by Tim Rühsen in:
https://lists.gnu.org/r/bug-gnulib/2019-08/msg00026.html
This commit is contained in:
Paul Eggert 2019-08-21 09:29:09 -07:00
parent 8a80ee5e2b
commit f615e3fced
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,5 +1,10 @@
2019-08-21 Paul Eggert <eggert@cs.ucla.edu> 2019-08-21 Paul Eggert <eggert@cs.ucla.edu>
Remove dead regex code
* posix/regex_internal.c (re_node_set_insert):
Remove unnecessary assignment. Reported by Tim Rühsen in:
https://lists.gnu.org/r/bug-gnulib/2019-08/msg00026.html
Fix bad pointer / leak in regex code Fix bad pointer / leak in regex code
This was found by Coverity (CID 1484201). [BZ#24844] This was found by Coverity (CID 1484201). [BZ#24844]
* posix/regex_internal.c (create_cd_newstate): Fix use of bad * posix/regex_internal.c (create_cd_newstate): Fix use of bad

1
posix/regex_internal.c
View File

@ -1311,7 +1311,6 @@ re_node_set_insert (re_node_set *set, Idx elem)
first element separately to skip a check in the inner loop. */ first element separately to skip a check in the inner loop. */
if (elem < set->elems[0]) if (elem < set->elems[0])
{ {
idx = 0;
for (idx = set->nelem; idx > 0; idx--) for (idx = set->nelem; idx > 0; idx--)
set->elems[idx] = set->elems[idx - 1]; set->elems[idx] = set->elems[idx - 1];
} }