qiurui
/
glibc
mirror of git://sourceware.org/git/glibc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix math/test-nearbyint-except for no-exceptions configurations. 

The test math/test-nearbyint-except conditions some of its tests on an
EXCEPTION_TESTS call, not not all that need such a condition.  This
patch fixes it to use such a conditional for all its tests and to
return 77 (UNSUPPORTED) if none of the floating-point types tested
support exceptions.

Tested for mips64 soft float (where the test previously failed and is
now UNSUPPORTED); also tested for x86_64 to make sure the test still
PASSes in exceptions-supported cases.

	* math/test-nearbyint-except.c: Include <stdbool.h>.
	(any_supported): New variable.
	(TEST_FUNC): Return early if !EXCEPTION_TESTS (FLOAT).  Otherwise
	set any_supported.
	(do_test): Return 77 if no floating-point type supported
	exceptions.
This commit is contained in:
Joseph Myers 2017-01-02 20:47:17 +00:00
parent f39cd196c6
commit e082ac7533
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ChangeLog
View File

@ -1,5 +1,12 @@
2017-01-02 Joseph Myers <joseph@codesourcery.com> 2017-01-02 Joseph Myers <joseph@codesourcery.com>
* math/test-nearbyint-except.c: Include <stdbool.h>.
(any_supported): New variable.
(TEST_FUNC): Return early if !EXCEPTION_TESTS (FLOAT). Otherwise
set any_supported.
(do_test): Return 77 if no floating-point type supported
exceptions.
* sysdeps/mips/math-tests.h (SNAN_TESTS_PRESERVE_PAYLOAD): Do not * sysdeps/mips/math-tests.h (SNAN_TESTS_PRESERVE_PAYLOAD): Do not
condition on [__mips_hard_float]. condition on [__mips_hard_float].

10
math/test-nearbyint-except.c
View File

@ -18,6 +18,7 @@
#include <fenv.h> #include <fenv.h>
#include <math.h> #include <math.h>
#include <stdbool.h>
#include <stdio.h> #include <stdio.h>
#include <math-tests.h> #include <math-tests.h>
@ -26,11 +27,16 @@
# define FE_INVALID 0 # define FE_INVALID 0
#endif #endif
static bool any_supported = false;
#define TEST_FUNC(NAME, FLOAT, SUFFIX) \ #define TEST_FUNC(NAME, FLOAT, SUFFIX) \
static int \ static int \
NAME (void) \ NAME (void) \
{ \ { \
int result = 0; \ int result = 0; \
if (!EXCEPTION_TESTS (FLOAT)) \
return 0; \
any_supported = true; \
volatile FLOAT a, b __attribute__ ((unused)); \ volatile FLOAT a, b __attribute__ ((unused)); \
a = 1.0; \ a = 1.0; \
/* nearbyint must not clear already-raised exceptions. */ \ /* nearbyint must not clear already-raised exceptions. */ \
@ -44,7 +50,7 @@ NAME (void) \
result = 1; \ result = 1; \
} \ } \
/* But it mustn't lose exceptions from sNaN arguments. */ \ /* But it mustn't lose exceptions from sNaN arguments. */ \
if (SNAN_TESTS (FLOAT) && EXCEPTION_TESTS (FLOAT)) \ if (SNAN_TESTS (FLOAT)) \
{ \ { \
static volatile FLOAT snan = __builtin_nans ## SUFFIX (""); \ static volatile FLOAT snan = __builtin_nans ## SUFFIX (""); \
volatile FLOAT c __attribute__ ((unused)); \ volatile FLOAT c __attribute__ ((unused)); \
@ -75,6 +81,8 @@ do_test (void)
#ifndef NO_LONG_DOUBLE #ifndef NO_LONG_DOUBLE
result |= ldouble_test (); result |= ldouble_test ();
#endif #endif
if (!any_supported)
return 77;
return result; return result;
} }