qiurui
/
glibc
mirror of git://sourceware.org/git/glibc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

stdio: Fix -Wtautological-constant-out-of-range-compare on clang 

clang emits an error while building vfprintf-internal for default
case:

error: result of comparison of constant 255 with expression of type
'char' is always true
[-Werror,-Wtautological-constant-out-of-range-compare]
          if (spec <= UCHAR_MAX

The test is indeed not required for default non-wide build.

Reviewed-by: Collin Funk <collin.funk1@gmail.com>
This commit is contained in:
Adhemerval Zanella 2025-10-17 16:13:01 -03:00
parent b9b28ce35f
commit ca3e2f12af
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
stdio-common/vfprintf-internal.c
View File

@ -1337,7 +1337,12 @@ printf_positional (struct Xprintf_buffer * buf, const CHAR_T *format,
/* Process format specifiers. */ /* Process format specifiers. */
do do
{ {
if (spec <= UCHAR_MAX # ifdef COMPILE_WPRINTF
# define CHECK_SPEC(spec) ((spec) <= UCHAR_MAX)
# else
# define CHECK_SPEC(spec) (true)
# endif
if (CHECK_SPEC (spec)
&& __printf_function_table != NULL && __printf_function_table != NULL
&& __printf_function_table[(size_t) spec] != NULL) && __printf_function_table[(size_t) spec] != NULL)
{ {