qiurui
/
glibc
mirror of git://sourceware.org/git/glibc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

support: Don't fail on fchown when spawning sgid processes 

In some cases (e.g. when podman creates user containers), the only other
group assigned to the executing user is nobody and fchown fails with it
because the group is not mapped.  Do not fail the test in this case,
instead exit as unsupported.

Reported-by: Frédéric Bérat <fberat@redhat.com>
Tested-by: Frédéric Bérat <fberat@redhat.com>
Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
(cherry picked from commit 6286cca2cb)
This commit is contained in:
Siddhesh Poyarekar 2023-06-01 07:23:15 -04:00 committed by Florian Weimer
parent 621c65ccf1
commit c9e44b6467
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
support/support_capture_subprocess.c
View File

@ -153,9 +153,18 @@ copy_and_spawn_sgid (const char *child_id, gid_t gid)
p += wrcount;
}
}
TEST_VERIFY (fchown (outfd, getuid (), gid) == 0);
bool chowned = false;
TEST_VERIFY ((chowned = fchown (outfd, getuid (), gid) == 0)
|| errno == EPERM);
if (support_record_failure_is_failed ())
goto err;
else if (!chowned)
{
ret = 77;
goto err;
}
TEST_VERIFY (fchmod (outfd, 02750) == 0);
if (support_record_failure_is_failed ())
goto err;
@ -192,8 +201,10 @@ err:
free (dirname);
}
if (ret == 77)
FAIL_UNSUPPORTED ("Failed to make sgid executable for test\n");
if (ret != 0)
FAIL_EXIT1("Failed to make sgid executable for test\n");
FAIL_EXIT1 ("Failed to make sgid executable for test\n");
return status;
}