qiurui
/
glibc
mirror of git://sourceware.org/git/glibc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

support: Use CHAR_MAX as maximum value 

On ABIs with defined 'char' was unsigned type, clang fails to build
support_process_state.c with:

  support_process_state.c:70:21: error: result of comparison of constant  -1 with expression of type 'char' is always false [-Werror,-Wtautological-constant-out-of-range-compare]
     70 |       if (cur_state == -1)
        |           ~~~~~~~~~ ^  ~~
  1 error generated.

Reviewed-by: Sam James <sam@gentoo.org>
This commit is contained in:
Adhemerval Zanella 2025-10-17 16:12:59 -03:00
parent 9d0b7ec87c
commit b0eb01ef48
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
support/support_process_state.c
View File

@ -59,7 +59,7 @@ support_process_state_wait (pid_t pid, enum support_process_state state)
for (;;)
{
char cur_state = -1;
char cur_state = CHAR_MAX;
while (xgetline (&line, &linesiz, fstatus) > 0)
if (strncmp (line, "State:", strlen ("State:")) == 0)
{
@ -67,7 +67,7 @@ support_process_state_wait (pid_t pid, enum support_process_state state)
break;
}
/* Fallback to nanosleep for invalid state. */
if (cur_state == -1)
if (cur_state == CHAR_MAX)
break;
for (size_t i = 0; i < array_length (process_states); ++i)