qiurui
/
glibc
mirror of git://sourceware.org/git/glibc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix MIPS __mips_isa_rev -Werror=undef build. 

I see an error

In file included from ../sysdeps/mips/include/sys/asm.h:20:0,
                 from ../sysdeps/mips/start.S:39:
../sysdeps/mips/sys/asm.h:421:5: error: "__mips_isa_rev" is not defined [-Werror=undef]
 #if __mips_isa_rev < 6
     ^
cc1: some warnings being treated as errors

in MIPS builds.  As sys/asm.h is an installed header, it seems better
to test for !defined __mips_isa_rev here, instead of defining it to 0
as done in sysdeps/unix/mips/sysdep.h, to avoid perturbing any code
outside glibc that tests whether __mips_isa_rev is defined; this patch
does so.

	* sysdeps/mips/sys/asm.h [__mips_isa_rev < 6]: Change condition to
	[!defined __mips_isa_rev || __mips_isa_rev < 6].
This commit is contained in:
Joseph Myers 2015-02-16 22:12:15 +00:00
parent 35264d1442
commit 86c56b164c
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
2015-02-16 Joseph Myers <joseph@codesourcery.com>
* sysdeps/mips/sys/asm.h [__mips_isa_rev < 6]: Change condition to
[!defined __mips_isa_rev || __mips_isa_rev < 6].
2015-02-16 Torvald Riegel <triegel@redhat.com>
* nptl/tst-cond25.c (cleanup): Explicitly check that the mutex is

2
sysdeps/mips/sys/asm.h
View File

@ -418,7 +418,7 @@ symbol = value
# define PTR_ADDI addi
# define PTR_SUB sub
# define PTR_SUBI subi
#if __mips_isa_rev < 6
#if !defined __mips_isa_rev || __mips_isa_rev < 6
# define PTR_ADDU add /* no u */
# define PTR_ADDIU addi /* no u */
# define PTR_SUBU sub /* no u */