qiurui
/
glibc
mirror of git://sourceware.org/git/glibc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

x86_64: Fix asm constraints in feraiseexcept (bug 30305) 

The divss instruction clobbers its first argument, and the constraints
need to reflect that.  Fortunately, with GCC 12, generated code does
not actually change, so there is no externally visible bug.

Suggested-by: Jakub Jelinek <jakub@redhat.com>
Reviewed-by: Noah Goldstein <goldstein.w.n@gmail.com>
(cherry picked from commit 5d1ccdda7b)
This commit is contained in:
Florian Weimer 2023-04-03 17:23:11 +02:00
parent 6a0d56b009
commit 71eb9cc1ff
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
NEWS
View File

@ -140,6 +140,7 @@ The following bugs are resolved with this release:
[29953] x86: Check minimum/maximum of non_temporal_threshold
[30053] time: strftime %s returns -1 after 2038 on 32 bits systems
[30151] gshadow: Matching sgetsgent, sgetsgent_r ERANGE handling
[30305] x86_64: Fix asm constraints in feraiseexcept
Version 2.34

4
sysdeps/x86_64/fpu/fraiseexcpt.c
View File

@ -33,7 +33,7 @@ __feraiseexcept (int excepts)
/* One example of an invalid operation is 0.0 / 0.0. */
float f = 0.0;
__asm__ __volatile__ ("divss %0, %0 " : : "x" (f));
__asm__ __volatile__ ("divss %0, %0 " : "+x" (f));
(void) &f;
}
@ -43,7 +43,7 @@ __feraiseexcept (int excepts)
float f = 1.0;
float g = 0.0;
__asm__ __volatile__ ("divss %1, %0" : : "x" (f), "x" (g));
__asm__ __volatile__ ("divss %1, %0" : "+x" (f) : "x" (g));
(void) &f;
}