qiurui
/
glibc
mirror of git://sourceware.org/git/glibc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[BZ #405] 

Update.
	* pthread_create.c (__pthread_create_2_1): Remember whether thread
	is created detached and if yes, do not try to free the stack in case
	the thread creation failed.
	* sysdeps/pthread/createthread.c (do_clone): Free stack here if clone
	call fails.  Don't depend on INTERNAL_SYSCALL_ERRNO return zero in
	case there has been no error.  [BZ #405]
This commit is contained in:
Ulrich Drepper 2004-09-24 18:22:04 +00:00
parent ebfa58bb23
commit 3f80a99b8f
2 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
nptl/ChangeLog
View File

@ -1,5 +1,12 @@
2004-09-24 Ulrich Drepper <drepper@redhat.com> 2004-09-24 Ulrich Drepper <drepper@redhat.com>
* pthread_create.c (__pthread_create_2_1): Remember whether thread
is created detached and if yes, do not try to free the stack in case
the thread creation failed.
* sysdeps/pthread/createthread.c (do_clone): Free stack here if clone
call fails. Don't depend on INTERNAL_SYSCALL_ERRNO return zero in
case there has been no error. [BZ #405]
* pthread_create.c (start_thread): Don't wait for scheduler data * pthread_create.c (start_thread): Don't wait for scheduler data
etc to be set at the beginning of the function. The cancellation etc to be set at the beginning of the function. The cancellation
infrastructure must have been set up. And enable async infrastructure must have been set up. And enable async

16
nptl/sysdeps/pthread/createthread.c
View File

@ -66,8 +66,16 @@ do_clone (struct pthread *pd, const struct pthread_attr *attr,
if (ARCH_CLONE (fct, STACK_VARIABLES_ARGS, clone_flags, if (ARCH_CLONE (fct, STACK_VARIABLES_ARGS, clone_flags,
pd, &pd->tid, TLS_VALUE, &pd->tid) == -1) pd, &pd->tid, TLS_VALUE, &pd->tid) == -1)
/* Failed. */ {
return errno; /* Failed. If the thread is detached, remove the TCB here since
the caller cannot do this. The caller remembered the thread
as detached and cannot reverify that it is not since it must
not access the thread descriptor again. */
if (IS_DETACHED (pd))
__deallocate_stack (pd);
return errno;
}
/* Now we have the possibility to set scheduling parameters etc. */ /* Now we have the possibility to set scheduling parameters etc. */
if (__builtin_expect (stopped != 0, 0)) if (__builtin_expect (stopped != 0, 0))
@ -95,7 +103,9 @@ do_clone (struct pthread *pd, const struct pthread_attr *attr,
(void) INTERNAL_SYSCALL (tkill, err2, 2, pd->tid, SIGCANCEL); (void) INTERNAL_SYSCALL (tkill, err2, 2, pd->tid, SIGCANCEL);
#endif #endif
return INTERNAL_SYSCALL_ERRNO (res, err); return (INTERNAL_SYSCALL_ERROR_P (res, err)
? INTERNAL_SYSCALL_ERRNO (res, err)
: 0);
} }
} }