qiurui
/
glibc
mirror of git://sourceware.org/git/glibc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make ABI tests generate .out files. 

If you rerun "make check" in a tree where some tests have already been
run, it will rerun ABI tests because those do not create an output
file.

This patch changes those tests to create .out files so they only get
rerun if the dependencies (on the ABI baselines and the generated
.symlist files) indicate they should be rerun.

Tested x86_64.

	* Makerules (check-abi-%): Change target to
	$(objpfx)check-abi-%.out.
	(check-abi target): Update dependencies.
	(check-abi-pattern variable): Redirect output of diff to $@.
	(check-abi variable): Likewise.
	* elf/Makefile (check-abi): Update dependencies.
This commit is contained in:
Joseph Myers 2014-02-12 20:51:13 +00:00
parent ace614b8a5
commit 1b6dd3f129
3 changed files with 21 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ChangeLog
View File

@ -1,5 +1,12 @@
2014-02-12 Joseph Myers <joseph@codesourcery.com> 2014-02-12 Joseph Myers <joseph@codesourcery.com>
* Makerules (check-abi-%): Change target to
$(objpfx)check-abi-%.out.
(check-abi target): Update dependencies.
(check-abi-pattern variable): Redirect output of diff to $@.
(check-abi variable): Likewise.
* elf/Makefile (check-abi): Update dependencies.
* soft-fp/op-common.h (_FP_DECL): Mark exponent as possibly * soft-fp/op-common.h (_FP_DECL): Mark exponent as possibly
unused. unused.
(_FP_PACK_SEMIRAW): Determine tininess based on rounding shifted (_FP_PACK_SEMIRAW): Determine tininess based on rounding shifted

22
Makerules
View File

@ -1193,21 +1193,25 @@ vpath %.abilist $(+sysdep_dirs)
generated += $(extra-libs:=.symlist) generated += $(extra-libs:=.symlist)
ifdef abilist-pattern ifdef abilist-pattern
check-abi-%: $(common-objpfx)config.make $(abilist-pattern) $(objpfx)%.symlist $(objpfx)check-abi-%.out: $(common-objpfx)config.make $(abilist-pattern) \
$(objpfx)%.symlist
$(check-abi-pattern) $(check-abi-pattern)
check-abi-%: $(common-objpfx)config.make $(abilist-pattern) \ $(objpfx)check-abi-%.out: $(common-objpfx)config.make $(abilist-pattern) \
$(common-objpfx)%.symlist $(common-objpfx)%.symlist
$(check-abi-pattern) $(check-abi-pattern)
endif endif
check-abi-%: $(common-objpfx)config.make %.abilist $(objpfx)%.symlist $(objpfx)check-abi-%.out: $(common-objpfx)config.make %.abilist \
$(objpfx)%.symlist
$(check-abi) $(check-abi)
check-abi-%: $(common-objpfx)config.make %.abilist $(common-objpfx)%.symlist $(objpfx)check-abi-%.out: $(common-objpfx)config.make %.abilist \
$(common-objpfx)%.symlist
$(check-abi) $(check-abi)
define check-abi-pattern define check-abi-pattern
diff -p -U 0 $(filter $(abilist-pattern),$^) $(filter %.symlist,$^) diff -p -U 0 $(filter $(abilist-pattern),$^) $(filter %.symlist,$^) \
> $@
endef endef
define check-abi define check-abi
diff -p -U 0 $(filter %.abilist,$^) $(filter %.symlist,$^) diff -p -U 0 $(filter %.abilist,$^) $(filter %.symlist,$^) > $@
endef endef
ifdef abilist-pattern ifdef abilist-pattern
@ -1239,7 +1243,7 @@ endef
.PHONY: update-abi check-abi .PHONY: update-abi check-abi
update-abi: $(patsubst %.so,update-abi-%,$(install-lib.so-versioned)) update-abi: $(patsubst %.so,update-abi-%,$(install-lib.so-versioned))
check-abi: $(patsubst %.so,check-abi-%,$(install-lib.so-versioned)) check-abi: $(patsubst %.so,$(objpfx)check-abi-%.out,$(install-lib.so-versioned))
ifdef subdir ifdef subdir
subdir_check-abi: check-abi subdir_check-abi: check-abi
subdir_update-abi: update-abi subdir_update-abi: update-abi
@ -1249,7 +1253,7 @@ update-abi: subdir_update-abi
endif endif
ifeq ($(subdir),elf) ifeq ($(subdir),elf)
check-abi: check-abi-libc check-abi: $(objpfx)check-abi-libc.out
update-abi: update-abi-libc update-abi: update-abi-libc
common-generated += libc.symlist common-generated += libc.symlist
endif endif

2
elf/Makefile
View File

@ -255,7 +255,7 @@ endif
include ../Rules include ../Rules
check-abi: check-abi-ld check-abi: $(objpfx)check-abi-ld.out
update-abi: update-abi-ld update-abi: update-abi-ld
ifeq (yes,$(build-shared)) ifeq (yes,$(build-shared))