qiurui
/
glibc
mirror of git://sourceware.org/git/glibc.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

debug: Add fortify dprintf tests 

Similar to other printf-like ones.

Checked on aarch64, armhf, x86_64, and i686.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
This commit is contained in:
Adhemerval Zanella 2023-12-21 15:59:17 -03:00
parent bf320000b4
commit 121aad59de
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
debug/tst-fortify.c
View File

@ -59,6 +59,8 @@
static char *temp_filename; static char *temp_filename;
static int temp_fd_dprintf;
static void static void
do_prepare (int argc, char *argv[]) do_prepare (int argc, char *argv[])
{ {
@ -76,6 +78,13 @@ do_prepare (int argc, char *argv[])
unlink (temp_filename); unlink (temp_filename);
exit (1); exit (1);
} }
temp_fd_dprintf = create_temp_file ("tst-chk2.", NULL);
if (temp_fd_dprintf == -1)
{
printf ("cannot create temporary file: %m\n");
exit (1);
}
} }
#define PREPARE do_prepare #define PREPARE do_prepare
@ -901,6 +910,10 @@ do_test (void)
|| n1 != 1 || n2 != 2) || n1 != 1 || n2 != 2)
FAIL (); FAIL ();
if (dprintf (temp_fd_dprintf, "%s%n%s%n", str2, &n1, str2, &n2) != 2
|| n1 != 1 || n2 != 2)
FAIL ();
strcpy (buf2 + 2, "%n%s%n"); strcpy (buf2 + 2, "%n%s%n");
/* When the format string is writable and contains %n, /* When the format string is writable and contains %n,
with -D_FORTIFY_SOURCE=2 it causes __chk_fail. */ with -D_FORTIFY_SOURCE=2 it causes __chk_fail. */
@ -914,6 +927,11 @@ do_test (void)
FAIL (); FAIL ();
CHK_FAIL2_END CHK_FAIL2_END
CHK_FAIL2_START
if (dprintf (temp_fd_dprintf, buf2, str2, &n1, str2, &n1) != 2)
FAIL ();
CHK_FAIL2_END
/* But if there is no %n, even writable format string /* But if there is no %n, even writable format string
should work. */ should work. */
buf2[6] = '\0'; buf2[6] = '\0';
@ -1263,6 +1281,10 @@ do_test (void)
snprintf (buf, buf_size, "%3$d\n", 1, 2, 3, 4); snprintf (buf, buf_size, "%3$d\n", 1, 2, 3, 4);
CHK_FAIL2_END CHK_FAIL2_END
CHK_FAIL2_START
dprintf (temp_fd_dprintf, "%3$d\n", 1, 2, 3, 4);
CHK_FAIL2_END
int sp[2]; int sp[2];
if (socketpair (PF_UNIX, SOCK_STREAM, 0, sp)) if (socketpair (PF_UNIX, SOCK_STREAM, 0, sp))
FAIL (); FAIL ();