resolv: Optimize inet_ntop
The benchtests/inet_ntop_ipv4 and benchtests/inet_ntop_ipv6 profile
shows that most of time is spent in costly sprint operations:
$ perf record ./benchtests/bench-inet_ntop_ipv4 && perf report --stdio
[...]
38.53% bench-inet_ntop libc.so [.] __printf_buffer
18.69% bench-inet_ntop libc.so [.] __printf_buffer_write
11.01% bench-inet_ntop libc.so [.] _itoa_word
8.02% bench-inet_ntop bench-inet_ntop_ipv4 [.] bench_start
6.99% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
3.86% bench-inet_ntop libc.so [.] __strchrnul_avx2
2.82% bench-inet_ntop libc.so [.] __strcpy_avx2
1.90% bench-inet_ntop libc.so [.] inet_ntop4
1.78% bench-inet_ntop libc.so [.] __vsprintf_internal
1.55% bench-inet_ntop libc.so [.] __sprintf_chk
1.18% bench-inet_ntop libc.so [.] __GI___inet_ntop
$ perf record ./benchtests/bench-inet_ntop_ipv6 && perf report --stdio
35.44% bench-inet_ntop libc.so [.] __printf_buffer
14.35% bench-inet_ntop libc.so [.] __printf_buffer_write
10.27% bench-inet_ntop libc.so [.] __GI___inet_ntop
7.93% bench-inet_ntop libc.so [.] _itoa_word
7.00% bench-inet_ntop libc.so [.] __sprintf_chk
6.20% bench-inet_ntop libc.so [.] __vsprintf_internal
5.26% bench-inet_ntop libc.so [.] __strchrnul_avx2
5.05% bench-inet_ntop bench-inet_ntop_ipv6 [.] bench_start
3.70% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
2.11% bench-inet_ntop libc.so [.] __printf_buffer_done
A new implementation is used instead:
* The printf usage is replaced with an expanded function that prints
either an IPv4 octet or an IPv6 quartet;
* The strcpy is replaced with a memcpy (since ABIs usually tends to
optimize the latter);
* For IPv6, the '::' shorthanding is done in-place instead of using
a temporary buffer.
* An temporary buffer is used iff the size if larger than
INET_ADDRSTRLEN/INET6_ADDRSTRLEN.
* Inline is used for both inet_ntop4 and inet_ntop6,
The code is significand rewrote, so I take this requires a new license.
The performance results on aarch64 Neoverse1 with gcc 14.2.1:
* master
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.43067e+09,
"iterations": 8e+06,
"reciprocal-throughput": 178.572,
"latency": 179.096,
"max-throughput": 5.59997e+06,
"min-throughput": 5.58359e+06
}
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.68539e+09,
"iterations": 4e+06,
"reciprocal-throughput": 421.307,
"latency": 421.388,
"max-throughput": 2.37357e+06,
"min-throughput": 2.37311e+06
}
}
* patched
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.06133e+09,
"iterations": 5.6e+07,
"reciprocal-throughput": 18.8482,
"latency": 19.0565,
"max-throughput": 5.30555e+07,
"min-throughput": 5.24755e+07
}
}
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.01246e+09,
"iterations": 2.4e+07,
"reciprocal-throughput": 42.5576,
"latency": 41.8139,
"max-throughput": 2.34976e+07,
"min-throughput": 2.39155e+07
}
}
Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: DJ Delorie <dj@redhat.com>
2025-06-04 20:42:43 +00:00
|
|
|
/* Convert IPv4/IPv6 addresses from binary to text form.
|
|
|
|
Copyright (C) 1996-2025 Free Software Foundation, Inc.
|
|
|
|
This file is part of the GNU C Library.
|
|
|
|
|
|
|
|
The GNU C Library is free software; you can redistribute it and/or
|
|
|
|
modify it under the terms of the GNU Lesser General Public
|
|
|
|
License as published by the Free Software Foundation; either
|
|
|
|
version 2.1 of the License, or (at your option) any later version.
|
|
|
|
|
|
|
|
The GNU C Library is distributed in the hope that it will be useful,
|
|
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
Lesser General Public License for more details.
|
|
|
|
|
|
|
|
You should have received a copy of the GNU Lesser General Public
|
|
|
|
License along with the GNU C Library; if not, see
|
|
|
|
<https://www.gnu.org/licenses/>. */
|
|
|
|
|
Wed May 22 22:10:01 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* stdlib/canonicalize.c: New file.
* stdlib/stdlib.h: Declare canonicalize_file_name, realpath.
* stdlib/Makefile (routines): Add canonicalize.
* posix/unistd.h: Declare __canonicalize_directory_name_internal.
Thu May 23 00:01:10 1996 Ulrich Drepper <drepper@cygnus.com>
* db/recno/rec_seq.c: Prevent `sccsid' definition by using the
same #if condition as in the other db files.
* intl/Makefile: Add -Wno-unused CFLAGS for compilation of
bindtextdom.c, finddomain.c, and localealias.c.
* intl/dcgettext.c: Don't define prototype for getcwd() when
compiling in glibc.
* libio/cleanup.c: Add prototype for _IO_register_cleanup.
* libio/filedoalloc.c, libio/fileops.c, libio/iopopen.c: Don't
define _POSIX_SOURCE unconditionally.
* libio/filedoalloc.c, libio/iopopen.c: Include <unistd.h> if
compiling in glibc.
* libio/fileops.c (_IO_file_close_it): Don't sync file, call
flush instead. This relaxes the rules from POSIX.1 about
changing the active handle a bit.
* libio/iofopncook.c (struct _IO_cookie_file): Move definition
into <libio.h>.
Add prototypes for local functions to prevent warnings.
* libio/iopopen.c: Change prototypes for _IO_fork, _IO_pipe, and
_IO_DUP2 to contain complete parameter list.
* libio/libio.h: Add definition of struct _IO_cookie_file.
* libio/libioP.h: Add prototypes for _IO_vasprintf, _IO_vdprintf,
and _IO_vsnprintf.
* libio/memstream.c: Include <stdio.h>.
* libio/stdio.h: Add prototypes for fopencookie,
__stdio_gen_tempname, __vfscanf, __vsscanf, and __vsnprintf.
* libio/strops.c: Avoid useless expression in `for' initializer.
* locale/findlocale.c: Add some casts to prevent warnings.
* locale/programs/locfile.c (write_locale_data): Don't use
double `/' in locale binary file.
* posix/unistd.h: Remove prototype for `reboot'.
Update from bind-4.9.4-T1A.
* resolv/Makefile (routines): Add inet_ntop and inet_pton.
* resolv/arpa/nameser.h: Add definition of IN6ADDRSZ.
* resolv/gethnamaddr.c, resolv/getnetnamadr.c, resolv/res_comp.c,
resolv/res_debug.c, resolv/res_init.c
* resolv/inet_ntop.c, resolv/inet_pton.c: New files.
* resolv/resolv.h: Add RES_USE_INET6 flag.
(__dn_isvalid): Renamed to __res_dnok.
Add prototypes for __res_ownok and __res_mailok.
* stdio-common/Makefile: Add -Wno-unused to CFLAGS for _itoa.c.
* stdio-common/getline.c, stdio-common/vfscanf.c,
sysdeps/posix/tempname.c: Don't use <ansidecl.h> anymore.
* sysdeps/unix/sysv/linux/Makefile [$subdir == misc]
(sysdep_routines): Add s_reboot.
(install-others): Add $(includedir)/sys/syscall.h.
New rule for $(includedir)/sys/syscall.h to produce from
<asm/unistd.h>.
* sysdeps/unix/sysv/linux/reboot.c: New file. Make single
argument function call 3 argument system call.
* sysdeps/unix/sysv/linux/sys/reboot.h: New file. Linux specific
definition for reboot function.
* sysdeps/unix/sysv/linux/syscall.h: Remove old and obsolete
comment.
* sysdeps/unix/sysv/linux/syscalls.list: Rename function for
reboot syscall to __syscall_reboot.
* wcsmbs/wchar.h: Protect prototypes for wcstof and wcstold by
__USE_GNU, not USE_GNU.
Tue May 21 21:55:49 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* locale/programs/charset.c, locale/programs/ld-collate.c:
Add casts to prevent warnings on 64-bit machines.
* locale/programs/ld-monetary.c: Don't do unnecessary tests for
int_frac_digits and frac_digits which only produce warnings.
Mon May 13 23:45:29 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* inet/arpa/inet.h: Backup return type of inet_addr to u_long.
* resolv/inet_addr.c: Likewise.
* resolv/Makefile (distribute): Add res_hconf.h
(routines): Add res_hconf.
* resolv/gethnamaddr.c: Add support for /etc/host.conf.
* resolv/res_init.c: Initialize /etc/host.conf reader.
* resolv/res_hconf.c, resolv/res_hconf.h: New files.
Implementation of reading /etc/host.conf.
Wed May 22 21:21:15 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* Rules (%.out rules): Prepend $($*-ENV) to the command.
* sysdeps/unix/sysv/linux/i386/brk.c (___brk_addr): Define as weak
alias for __curbrk.
Wed May 22 19:37:27 1996 Miles Bader <miles@gnu.ai.mit.edu>
* hurd/hurdexec.c (_hurd_exec): Pass INIT_TRACEMASK.
* hurd/hurdmsg.c (set_int): Support INIT_TRACEMASK.
Wed May 22 18:47:31 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* sysdeps/mach/hurd/getcwd.c
(_hurd_canonicalize_directory_name_internal): New function, broken out
of __getcwd.
(__getcwd): Use it.
(__canonicalize_directory_name_internal): New function using it.
* sysdeps/posix/getcwd.c (__canonicalize_directory_name_internal): New
function, broken out of __getcwd.
(__getcwd): Use it.
Wed May 22 18:14:05 1996 Miles Bader <miles@gnu.ai.mit.edu>
* string/argz-create.c (__argz_create): Correctly calculate length.
* string/argz-extract.c (__argz_extract): Add terminating 0 entry.
* hurd/hurdstartup.c (_hurd_startup): ... and don't so here.
[HAVE_VMSDIR_H]: Include "vmsdir.h".
(glob) [VMS]: Don't grok ~.
1996-05-23 03:15:42 +00:00
|
|
|
#include <arpa/inet.h>
|
|
|
|
#include <arpa/nameser.h>
|
|
|
|
#include <errno.h>
|
Update.
2000-07-18 Mark Kettenis <kettenis@gnu.org>
Update resolver code to BIND 8.2.3-T5B.
* resolv/Versions [GLIBC_2.2] (libc): Add __res_init and
__res_nclose.
[GLIBC_2.2] (libresolv): Add __dn_expand, __ns_samename,
__res_mkquery, __res_nsend, __res_query, __res_querydomain and
__res_search.
* resolv/Banner: BIND-8.2.3-T5B.
* resolv/base64.c: Update from BIND 8.2.3-T5B.
* resolv/herror.c: Likewise.
* resolv/inet_addr.c: Likewise.
* resolv/inet_net_ntop.c: Likewise.
* resolv/inet_net_pton.c: Likewise.
* resolv/inet_neta.c: Likewise.
* resolv/inet_ntop.c: Likewise.
* resolv/nsap_addr.c: Likewise.
* resolv/inet_pton.c: Likewise. Reject a few more more invalid
IPv6 addresses (ISC bug #520).
* resolv/ns_name.c: Avoid emitting RCS ID in object file.
* resolv/ns_parse.c: Likewise.
* resolv/ns_netint.c: Likewise.
* resolv/ns_samedomain.c: Likewise.
* resolv/ns_ttl.c: Likewise.
* resolv/ns_print.c: Update from BIND 8.2.3-T5B. Avoid emitting
RCS ID in object file.
* resolv/res_debug.c: Update from BIND 8.2.3-T5B.
* resolv/res_mkquery.c: Likewise.
* resolv/res_query.c: Likewise.
* resolv/res_init.c: Likewise.
(res_setoptions): Mark internal.
* resolv/res_send.c: Likewise.
[_LIBC]: Fully reinstate the code that avoids the FD_SETSIZE limit
by using poll instead.
* resolv/res_comp.c: Likewise.
[SHLIB_COMPAT (libresolv, GLIBC_2_0, GLIBC_2_2)]: Make dn_expand a
weak alias for __dn_expand.
* resolv/res_data.c: Likewise.
(res_close) [_LIBC]: Don't call res_nclose if RES_INIT isn't set
in _res.options. Avoids a potential security risk by avoiding a
close (0).
[SHLIB_COMPAT (libresolv, GLIBC_2_0, GLIBC_2_2)]: Make
res_mkquery, res_query, res_querydomain adn res_search weak
aliases for __res_mkquery, __res_query, __res_querydomain and
__res_search.
* resolv/res_libc.c: (_res): Don't initialize. Fix res_close
instead to avoid close(0).
(res_init): Always use the static resolver context.
[SHLIB_COMPAT (libc, GLIBC_2.0, GLIBC_2_2)]: Make res_init a weak
alias for __res_init.
* resolv/resolv.h: Update from BIND 8.2.3-T5B. Move definition of
RES_SET_H_ERRNO and accompanying comment to...
* include/resolv.h: ... here.
* resolv/arpa/namser.h: Update from BIND 8.2.3-T5B.
* resolv/arpa/nameser_compat.h: Likewise.
2000-07-19 22:03:58 +00:00
|
|
|
#include <string.h>
|
resolv: Optimize inet_ntop
The benchtests/inet_ntop_ipv4 and benchtests/inet_ntop_ipv6 profile
shows that most of time is spent in costly sprint operations:
$ perf record ./benchtests/bench-inet_ntop_ipv4 && perf report --stdio
[...]
38.53% bench-inet_ntop libc.so [.] __printf_buffer
18.69% bench-inet_ntop libc.so [.] __printf_buffer_write
11.01% bench-inet_ntop libc.so [.] _itoa_word
8.02% bench-inet_ntop bench-inet_ntop_ipv4 [.] bench_start
6.99% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
3.86% bench-inet_ntop libc.so [.] __strchrnul_avx2
2.82% bench-inet_ntop libc.so [.] __strcpy_avx2
1.90% bench-inet_ntop libc.so [.] inet_ntop4
1.78% bench-inet_ntop libc.so [.] __vsprintf_internal
1.55% bench-inet_ntop libc.so [.] __sprintf_chk
1.18% bench-inet_ntop libc.so [.] __GI___inet_ntop
$ perf record ./benchtests/bench-inet_ntop_ipv6 && perf report --stdio
35.44% bench-inet_ntop libc.so [.] __printf_buffer
14.35% bench-inet_ntop libc.so [.] __printf_buffer_write
10.27% bench-inet_ntop libc.so [.] __GI___inet_ntop
7.93% bench-inet_ntop libc.so [.] _itoa_word
7.00% bench-inet_ntop libc.so [.] __sprintf_chk
6.20% bench-inet_ntop libc.so [.] __vsprintf_internal
5.26% bench-inet_ntop libc.so [.] __strchrnul_avx2
5.05% bench-inet_ntop bench-inet_ntop_ipv6 [.] bench_start
3.70% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
2.11% bench-inet_ntop libc.so [.] __printf_buffer_done
A new implementation is used instead:
* The printf usage is replaced with an expanded function that prints
either an IPv4 octet or an IPv6 quartet;
* The strcpy is replaced with a memcpy (since ABIs usually tends to
optimize the latter);
* For IPv6, the '::' shorthanding is done in-place instead of using
a temporary buffer.
* An temporary buffer is used iff the size if larger than
INET_ADDRSTRLEN/INET6_ADDRSTRLEN.
* Inline is used for both inet_ntop4 and inet_ntop6,
The code is significand rewrote, so I take this requires a new license.
The performance results on aarch64 Neoverse1 with gcc 14.2.1:
* master
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.43067e+09,
"iterations": 8e+06,
"reciprocal-throughput": 178.572,
"latency": 179.096,
"max-throughput": 5.59997e+06,
"min-throughput": 5.58359e+06
}
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.68539e+09,
"iterations": 4e+06,
"reciprocal-throughput": 421.307,
"latency": 421.388,
"max-throughput": 2.37357e+06,
"min-throughput": 2.37311e+06
}
}
* patched
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.06133e+09,
"iterations": 5.6e+07,
"reciprocal-throughput": 18.8482,
"latency": 19.0565,
"max-throughput": 5.30555e+07,
"min-throughput": 5.24755e+07
}
}
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.01246e+09,
"iterations": 2.4e+07,
"reciprocal-throughput": 42.5576,
"latency": 41.8139,
"max-throughput": 2.34976e+07,
"min-throughput": 2.39155e+07
}
}
Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: DJ Delorie <dj@redhat.com>
2025-06-04 20:42:43 +00:00
|
|
|
#include <_itoa.h>
|
Wed May 22 22:10:01 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* stdlib/canonicalize.c: New file.
* stdlib/stdlib.h: Declare canonicalize_file_name, realpath.
* stdlib/Makefile (routines): Add canonicalize.
* posix/unistd.h: Declare __canonicalize_directory_name_internal.
Thu May 23 00:01:10 1996 Ulrich Drepper <drepper@cygnus.com>
* db/recno/rec_seq.c: Prevent `sccsid' definition by using the
same #if condition as in the other db files.
* intl/Makefile: Add -Wno-unused CFLAGS for compilation of
bindtextdom.c, finddomain.c, and localealias.c.
* intl/dcgettext.c: Don't define prototype for getcwd() when
compiling in glibc.
* libio/cleanup.c: Add prototype for _IO_register_cleanup.
* libio/filedoalloc.c, libio/fileops.c, libio/iopopen.c: Don't
define _POSIX_SOURCE unconditionally.
* libio/filedoalloc.c, libio/iopopen.c: Include <unistd.h> if
compiling in glibc.
* libio/fileops.c (_IO_file_close_it): Don't sync file, call
flush instead. This relaxes the rules from POSIX.1 about
changing the active handle a bit.
* libio/iofopncook.c (struct _IO_cookie_file): Move definition
into <libio.h>.
Add prototypes for local functions to prevent warnings.
* libio/iopopen.c: Change prototypes for _IO_fork, _IO_pipe, and
_IO_DUP2 to contain complete parameter list.
* libio/libio.h: Add definition of struct _IO_cookie_file.
* libio/libioP.h: Add prototypes for _IO_vasprintf, _IO_vdprintf,
and _IO_vsnprintf.
* libio/memstream.c: Include <stdio.h>.
* libio/stdio.h: Add prototypes for fopencookie,
__stdio_gen_tempname, __vfscanf, __vsscanf, and __vsnprintf.
* libio/strops.c: Avoid useless expression in `for' initializer.
* locale/findlocale.c: Add some casts to prevent warnings.
* locale/programs/locfile.c (write_locale_data): Don't use
double `/' in locale binary file.
* posix/unistd.h: Remove prototype for `reboot'.
Update from bind-4.9.4-T1A.
* resolv/Makefile (routines): Add inet_ntop and inet_pton.
* resolv/arpa/nameser.h: Add definition of IN6ADDRSZ.
* resolv/gethnamaddr.c, resolv/getnetnamadr.c, resolv/res_comp.c,
resolv/res_debug.c, resolv/res_init.c
* resolv/inet_ntop.c, resolv/inet_pton.c: New files.
* resolv/resolv.h: Add RES_USE_INET6 flag.
(__dn_isvalid): Renamed to __res_dnok.
Add prototypes for __res_ownok and __res_mailok.
* stdio-common/Makefile: Add -Wno-unused to CFLAGS for _itoa.c.
* stdio-common/getline.c, stdio-common/vfscanf.c,
sysdeps/posix/tempname.c: Don't use <ansidecl.h> anymore.
* sysdeps/unix/sysv/linux/Makefile [$subdir == misc]
(sysdep_routines): Add s_reboot.
(install-others): Add $(includedir)/sys/syscall.h.
New rule for $(includedir)/sys/syscall.h to produce from
<asm/unistd.h>.
* sysdeps/unix/sysv/linux/reboot.c: New file. Make single
argument function call 3 argument system call.
* sysdeps/unix/sysv/linux/sys/reboot.h: New file. Linux specific
definition for reboot function.
* sysdeps/unix/sysv/linux/syscall.h: Remove old and obsolete
comment.
* sysdeps/unix/sysv/linux/syscalls.list: Rename function for
reboot syscall to __syscall_reboot.
* wcsmbs/wchar.h: Protect prototypes for wcstof and wcstold by
__USE_GNU, not USE_GNU.
Tue May 21 21:55:49 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* locale/programs/charset.c, locale/programs/ld-collate.c:
Add casts to prevent warnings on 64-bit machines.
* locale/programs/ld-monetary.c: Don't do unnecessary tests for
int_frac_digits and frac_digits which only produce warnings.
Mon May 13 23:45:29 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* inet/arpa/inet.h: Backup return type of inet_addr to u_long.
* resolv/inet_addr.c: Likewise.
* resolv/Makefile (distribute): Add res_hconf.h
(routines): Add res_hconf.
* resolv/gethnamaddr.c: Add support for /etc/host.conf.
* resolv/res_init.c: Initialize /etc/host.conf reader.
* resolv/res_hconf.c, resolv/res_hconf.h: New files.
Implementation of reading /etc/host.conf.
Wed May 22 21:21:15 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* Rules (%.out rules): Prepend $($*-ENV) to the command.
* sysdeps/unix/sysv/linux/i386/brk.c (___brk_addr): Define as weak
alias for __curbrk.
Wed May 22 19:37:27 1996 Miles Bader <miles@gnu.ai.mit.edu>
* hurd/hurdexec.c (_hurd_exec): Pass INIT_TRACEMASK.
* hurd/hurdmsg.c (set_int): Support INIT_TRACEMASK.
Wed May 22 18:47:31 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* sysdeps/mach/hurd/getcwd.c
(_hurd_canonicalize_directory_name_internal): New function, broken out
of __getcwd.
(__getcwd): Use it.
(__canonicalize_directory_name_internal): New function using it.
* sysdeps/posix/getcwd.c (__canonicalize_directory_name_internal): New
function, broken out of __getcwd.
(__getcwd): Use it.
Wed May 22 18:14:05 1996 Miles Bader <miles@gnu.ai.mit.edu>
* string/argz-create.c (__argz_create): Correctly calculate length.
* string/argz-extract.c (__argz_extract): Add terminating 0 entry.
* hurd/hurdstartup.c (_hurd_startup): ... and don't so here.
[HAVE_VMSDIR_H]: Include "vmsdir.h".
(glob) [VMS]: Don't grok ~.
1996-05-23 03:15:42 +00:00
|
|
|
|
resolv: Optimize inet_ntop
The benchtests/inet_ntop_ipv4 and benchtests/inet_ntop_ipv6 profile
shows that most of time is spent in costly sprint operations:
$ perf record ./benchtests/bench-inet_ntop_ipv4 && perf report --stdio
[...]
38.53% bench-inet_ntop libc.so [.] __printf_buffer
18.69% bench-inet_ntop libc.so [.] __printf_buffer_write
11.01% bench-inet_ntop libc.so [.] _itoa_word
8.02% bench-inet_ntop bench-inet_ntop_ipv4 [.] bench_start
6.99% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
3.86% bench-inet_ntop libc.so [.] __strchrnul_avx2
2.82% bench-inet_ntop libc.so [.] __strcpy_avx2
1.90% bench-inet_ntop libc.so [.] inet_ntop4
1.78% bench-inet_ntop libc.so [.] __vsprintf_internal
1.55% bench-inet_ntop libc.so [.] __sprintf_chk
1.18% bench-inet_ntop libc.so [.] __GI___inet_ntop
$ perf record ./benchtests/bench-inet_ntop_ipv6 && perf report --stdio
35.44% bench-inet_ntop libc.so [.] __printf_buffer
14.35% bench-inet_ntop libc.so [.] __printf_buffer_write
10.27% bench-inet_ntop libc.so [.] __GI___inet_ntop
7.93% bench-inet_ntop libc.so [.] _itoa_word
7.00% bench-inet_ntop libc.so [.] __sprintf_chk
6.20% bench-inet_ntop libc.so [.] __vsprintf_internal
5.26% bench-inet_ntop libc.so [.] __strchrnul_avx2
5.05% bench-inet_ntop bench-inet_ntop_ipv6 [.] bench_start
3.70% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
2.11% bench-inet_ntop libc.so [.] __printf_buffer_done
A new implementation is used instead:
* The printf usage is replaced with an expanded function that prints
either an IPv4 octet or an IPv6 quartet;
* The strcpy is replaced with a memcpy (since ABIs usually tends to
optimize the latter);
* For IPv6, the '::' shorthanding is done in-place instead of using
a temporary buffer.
* An temporary buffer is used iff the size if larger than
INET_ADDRSTRLEN/INET6_ADDRSTRLEN.
* Inline is used for both inet_ntop4 and inet_ntop6,
The code is significand rewrote, so I take this requires a new license.
The performance results on aarch64 Neoverse1 with gcc 14.2.1:
* master
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.43067e+09,
"iterations": 8e+06,
"reciprocal-throughput": 178.572,
"latency": 179.096,
"max-throughput": 5.59997e+06,
"min-throughput": 5.58359e+06
}
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.68539e+09,
"iterations": 4e+06,
"reciprocal-throughput": 421.307,
"latency": 421.388,
"max-throughput": 2.37357e+06,
"min-throughput": 2.37311e+06
}
}
* patched
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.06133e+09,
"iterations": 5.6e+07,
"reciprocal-throughput": 18.8482,
"latency": 19.0565,
"max-throughput": 5.30555e+07,
"min-throughput": 5.24755e+07
}
}
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.01246e+09,
"iterations": 2.4e+07,
"reciprocal-throughput": 42.5576,
"latency": 41.8139,
"max-throughput": 2.34976e+07,
"min-throughput": 2.39155e+07
}
}
Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: DJ Delorie <dj@redhat.com>
2025-06-04 20:42:43 +00:00
|
|
|
static inline char *
|
|
|
|
put_uint8 (uint8_t word, char *tp)
|
Wed May 22 22:10:01 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* stdlib/canonicalize.c: New file.
* stdlib/stdlib.h: Declare canonicalize_file_name, realpath.
* stdlib/Makefile (routines): Add canonicalize.
* posix/unistd.h: Declare __canonicalize_directory_name_internal.
Thu May 23 00:01:10 1996 Ulrich Drepper <drepper@cygnus.com>
* db/recno/rec_seq.c: Prevent `sccsid' definition by using the
same #if condition as in the other db files.
* intl/Makefile: Add -Wno-unused CFLAGS for compilation of
bindtextdom.c, finddomain.c, and localealias.c.
* intl/dcgettext.c: Don't define prototype for getcwd() when
compiling in glibc.
* libio/cleanup.c: Add prototype for _IO_register_cleanup.
* libio/filedoalloc.c, libio/fileops.c, libio/iopopen.c: Don't
define _POSIX_SOURCE unconditionally.
* libio/filedoalloc.c, libio/iopopen.c: Include <unistd.h> if
compiling in glibc.
* libio/fileops.c (_IO_file_close_it): Don't sync file, call
flush instead. This relaxes the rules from POSIX.1 about
changing the active handle a bit.
* libio/iofopncook.c (struct _IO_cookie_file): Move definition
into <libio.h>.
Add prototypes for local functions to prevent warnings.
* libio/iopopen.c: Change prototypes for _IO_fork, _IO_pipe, and
_IO_DUP2 to contain complete parameter list.
* libio/libio.h: Add definition of struct _IO_cookie_file.
* libio/libioP.h: Add prototypes for _IO_vasprintf, _IO_vdprintf,
and _IO_vsnprintf.
* libio/memstream.c: Include <stdio.h>.
* libio/stdio.h: Add prototypes for fopencookie,
__stdio_gen_tempname, __vfscanf, __vsscanf, and __vsnprintf.
* libio/strops.c: Avoid useless expression in `for' initializer.
* locale/findlocale.c: Add some casts to prevent warnings.
* locale/programs/locfile.c (write_locale_data): Don't use
double `/' in locale binary file.
* posix/unistd.h: Remove prototype for `reboot'.
Update from bind-4.9.4-T1A.
* resolv/Makefile (routines): Add inet_ntop and inet_pton.
* resolv/arpa/nameser.h: Add definition of IN6ADDRSZ.
* resolv/gethnamaddr.c, resolv/getnetnamadr.c, resolv/res_comp.c,
resolv/res_debug.c, resolv/res_init.c
* resolv/inet_ntop.c, resolv/inet_pton.c: New files.
* resolv/resolv.h: Add RES_USE_INET6 flag.
(__dn_isvalid): Renamed to __res_dnok.
Add prototypes for __res_ownok and __res_mailok.
* stdio-common/Makefile: Add -Wno-unused to CFLAGS for _itoa.c.
* stdio-common/getline.c, stdio-common/vfscanf.c,
sysdeps/posix/tempname.c: Don't use <ansidecl.h> anymore.
* sysdeps/unix/sysv/linux/Makefile [$subdir == misc]
(sysdep_routines): Add s_reboot.
(install-others): Add $(includedir)/sys/syscall.h.
New rule for $(includedir)/sys/syscall.h to produce from
<asm/unistd.h>.
* sysdeps/unix/sysv/linux/reboot.c: New file. Make single
argument function call 3 argument system call.
* sysdeps/unix/sysv/linux/sys/reboot.h: New file. Linux specific
definition for reboot function.
* sysdeps/unix/sysv/linux/syscall.h: Remove old and obsolete
comment.
* sysdeps/unix/sysv/linux/syscalls.list: Rename function for
reboot syscall to __syscall_reboot.
* wcsmbs/wchar.h: Protect prototypes for wcstof and wcstold by
__USE_GNU, not USE_GNU.
Tue May 21 21:55:49 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* locale/programs/charset.c, locale/programs/ld-collate.c:
Add casts to prevent warnings on 64-bit machines.
* locale/programs/ld-monetary.c: Don't do unnecessary tests for
int_frac_digits and frac_digits which only produce warnings.
Mon May 13 23:45:29 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* inet/arpa/inet.h: Backup return type of inet_addr to u_long.
* resolv/inet_addr.c: Likewise.
* resolv/Makefile (distribute): Add res_hconf.h
(routines): Add res_hconf.
* resolv/gethnamaddr.c: Add support for /etc/host.conf.
* resolv/res_init.c: Initialize /etc/host.conf reader.
* resolv/res_hconf.c, resolv/res_hconf.h: New files.
Implementation of reading /etc/host.conf.
Wed May 22 21:21:15 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* Rules (%.out rules): Prepend $($*-ENV) to the command.
* sysdeps/unix/sysv/linux/i386/brk.c (___brk_addr): Define as weak
alias for __curbrk.
Wed May 22 19:37:27 1996 Miles Bader <miles@gnu.ai.mit.edu>
* hurd/hurdexec.c (_hurd_exec): Pass INIT_TRACEMASK.
* hurd/hurdmsg.c (set_int): Support INIT_TRACEMASK.
Wed May 22 18:47:31 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* sysdeps/mach/hurd/getcwd.c
(_hurd_canonicalize_directory_name_internal): New function, broken out
of __getcwd.
(__getcwd): Use it.
(__canonicalize_directory_name_internal): New function using it.
* sysdeps/posix/getcwd.c (__canonicalize_directory_name_internal): New
function, broken out of __getcwd.
(__getcwd): Use it.
Wed May 22 18:14:05 1996 Miles Bader <miles@gnu.ai.mit.edu>
* string/argz-create.c (__argz_create): Correctly calculate length.
* string/argz-extract.c (__argz_extract): Add terminating 0 entry.
* hurd/hurdstartup.c (_hurd_startup): ... and don't so here.
[HAVE_VMSDIR_H]: Include "vmsdir.h".
(glob) [VMS]: Don't grok ~.
1996-05-23 03:15:42 +00:00
|
|
|
{
|
resolv: Optimize inet_ntop
The benchtests/inet_ntop_ipv4 and benchtests/inet_ntop_ipv6 profile
shows that most of time is spent in costly sprint operations:
$ perf record ./benchtests/bench-inet_ntop_ipv4 && perf report --stdio
[...]
38.53% bench-inet_ntop libc.so [.] __printf_buffer
18.69% bench-inet_ntop libc.so [.] __printf_buffer_write
11.01% bench-inet_ntop libc.so [.] _itoa_word
8.02% bench-inet_ntop bench-inet_ntop_ipv4 [.] bench_start
6.99% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
3.86% bench-inet_ntop libc.so [.] __strchrnul_avx2
2.82% bench-inet_ntop libc.so [.] __strcpy_avx2
1.90% bench-inet_ntop libc.so [.] inet_ntop4
1.78% bench-inet_ntop libc.so [.] __vsprintf_internal
1.55% bench-inet_ntop libc.so [.] __sprintf_chk
1.18% bench-inet_ntop libc.so [.] __GI___inet_ntop
$ perf record ./benchtests/bench-inet_ntop_ipv6 && perf report --stdio
35.44% bench-inet_ntop libc.so [.] __printf_buffer
14.35% bench-inet_ntop libc.so [.] __printf_buffer_write
10.27% bench-inet_ntop libc.so [.] __GI___inet_ntop
7.93% bench-inet_ntop libc.so [.] _itoa_word
7.00% bench-inet_ntop libc.so [.] __sprintf_chk
6.20% bench-inet_ntop libc.so [.] __vsprintf_internal
5.26% bench-inet_ntop libc.so [.] __strchrnul_avx2
5.05% bench-inet_ntop bench-inet_ntop_ipv6 [.] bench_start
3.70% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
2.11% bench-inet_ntop libc.so [.] __printf_buffer_done
A new implementation is used instead:
* The printf usage is replaced with an expanded function that prints
either an IPv4 octet or an IPv6 quartet;
* The strcpy is replaced with a memcpy (since ABIs usually tends to
optimize the latter);
* For IPv6, the '::' shorthanding is done in-place instead of using
a temporary buffer.
* An temporary buffer is used iff the size if larger than
INET_ADDRSTRLEN/INET6_ADDRSTRLEN.
* Inline is used for both inet_ntop4 and inet_ntop6,
The code is significand rewrote, so I take this requires a new license.
The performance results on aarch64 Neoverse1 with gcc 14.2.1:
* master
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.43067e+09,
"iterations": 8e+06,
"reciprocal-throughput": 178.572,
"latency": 179.096,
"max-throughput": 5.59997e+06,
"min-throughput": 5.58359e+06
}
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.68539e+09,
"iterations": 4e+06,
"reciprocal-throughput": 421.307,
"latency": 421.388,
"max-throughput": 2.37357e+06,
"min-throughput": 2.37311e+06
}
}
* patched
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.06133e+09,
"iterations": 5.6e+07,
"reciprocal-throughput": 18.8482,
"latency": 19.0565,
"max-throughput": 5.30555e+07,
"min-throughput": 5.24755e+07
}
}
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.01246e+09,
"iterations": 2.4e+07,
"reciprocal-throughput": 42.5576,
"latency": 41.8139,
"max-throughput": 2.34976e+07,
"min-throughput": 2.39155e+07
}
}
Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: DJ Delorie <dj@redhat.com>
2025-06-04 20:42:43 +00:00
|
|
|
int s = 1;
|
|
|
|
if (word >= 10)
|
2025-06-04 20:42:42 +00:00
|
|
|
{
|
resolv: Optimize inet_ntop
The benchtests/inet_ntop_ipv4 and benchtests/inet_ntop_ipv6 profile
shows that most of time is spent in costly sprint operations:
$ perf record ./benchtests/bench-inet_ntop_ipv4 && perf report --stdio
[...]
38.53% bench-inet_ntop libc.so [.] __printf_buffer
18.69% bench-inet_ntop libc.so [.] __printf_buffer_write
11.01% bench-inet_ntop libc.so [.] _itoa_word
8.02% bench-inet_ntop bench-inet_ntop_ipv4 [.] bench_start
6.99% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
3.86% bench-inet_ntop libc.so [.] __strchrnul_avx2
2.82% bench-inet_ntop libc.so [.] __strcpy_avx2
1.90% bench-inet_ntop libc.so [.] inet_ntop4
1.78% bench-inet_ntop libc.so [.] __vsprintf_internal
1.55% bench-inet_ntop libc.so [.] __sprintf_chk
1.18% bench-inet_ntop libc.so [.] __GI___inet_ntop
$ perf record ./benchtests/bench-inet_ntop_ipv6 && perf report --stdio
35.44% bench-inet_ntop libc.so [.] __printf_buffer
14.35% bench-inet_ntop libc.so [.] __printf_buffer_write
10.27% bench-inet_ntop libc.so [.] __GI___inet_ntop
7.93% bench-inet_ntop libc.so [.] _itoa_word
7.00% bench-inet_ntop libc.so [.] __sprintf_chk
6.20% bench-inet_ntop libc.so [.] __vsprintf_internal
5.26% bench-inet_ntop libc.so [.] __strchrnul_avx2
5.05% bench-inet_ntop bench-inet_ntop_ipv6 [.] bench_start
3.70% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
2.11% bench-inet_ntop libc.so [.] __printf_buffer_done
A new implementation is used instead:
* The printf usage is replaced with an expanded function that prints
either an IPv4 octet or an IPv6 quartet;
* The strcpy is replaced with a memcpy (since ABIs usually tends to
optimize the latter);
* For IPv6, the '::' shorthanding is done in-place instead of using
a temporary buffer.
* An temporary buffer is used iff the size if larger than
INET_ADDRSTRLEN/INET6_ADDRSTRLEN.
* Inline is used for both inet_ntop4 and inet_ntop6,
The code is significand rewrote, so I take this requires a new license.
The performance results on aarch64 Neoverse1 with gcc 14.2.1:
* master
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.43067e+09,
"iterations": 8e+06,
"reciprocal-throughput": 178.572,
"latency": 179.096,
"max-throughput": 5.59997e+06,
"min-throughput": 5.58359e+06
}
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.68539e+09,
"iterations": 4e+06,
"reciprocal-throughput": 421.307,
"latency": 421.388,
"max-throughput": 2.37357e+06,
"min-throughput": 2.37311e+06
}
}
* patched
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.06133e+09,
"iterations": 5.6e+07,
"reciprocal-throughput": 18.8482,
"latency": 19.0565,
"max-throughput": 5.30555e+07,
"min-throughput": 5.24755e+07
}
}
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.01246e+09,
"iterations": 2.4e+07,
"reciprocal-throughput": 42.5576,
"latency": 41.8139,
"max-throughput": 2.34976e+07,
"min-throughput": 2.39155e+07
}
}
Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: DJ Delorie <dj@redhat.com>
2025-06-04 20:42:43 +00:00
|
|
|
if (word >= 100)
|
|
|
|
{
|
|
|
|
tp[2] = '0' + word % 10;
|
|
|
|
word /= 10;
|
|
|
|
s += 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
tp[1] = '0' + word % 10;
|
|
|
|
word /= 10;
|
|
|
|
s += 1;
|
2025-06-04 20:42:42 +00:00
|
|
|
}
|
resolv: Optimize inet_ntop
The benchtests/inet_ntop_ipv4 and benchtests/inet_ntop_ipv6 profile
shows that most of time is spent in costly sprint operations:
$ perf record ./benchtests/bench-inet_ntop_ipv4 && perf report --stdio
[...]
38.53% bench-inet_ntop libc.so [.] __printf_buffer
18.69% bench-inet_ntop libc.so [.] __printf_buffer_write
11.01% bench-inet_ntop libc.so [.] _itoa_word
8.02% bench-inet_ntop bench-inet_ntop_ipv4 [.] bench_start
6.99% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
3.86% bench-inet_ntop libc.so [.] __strchrnul_avx2
2.82% bench-inet_ntop libc.so [.] __strcpy_avx2
1.90% bench-inet_ntop libc.so [.] inet_ntop4
1.78% bench-inet_ntop libc.so [.] __vsprintf_internal
1.55% bench-inet_ntop libc.so [.] __sprintf_chk
1.18% bench-inet_ntop libc.so [.] __GI___inet_ntop
$ perf record ./benchtests/bench-inet_ntop_ipv6 && perf report --stdio
35.44% bench-inet_ntop libc.so [.] __printf_buffer
14.35% bench-inet_ntop libc.so [.] __printf_buffer_write
10.27% bench-inet_ntop libc.so [.] __GI___inet_ntop
7.93% bench-inet_ntop libc.so [.] _itoa_word
7.00% bench-inet_ntop libc.so [.] __sprintf_chk
6.20% bench-inet_ntop libc.so [.] __vsprintf_internal
5.26% bench-inet_ntop libc.so [.] __strchrnul_avx2
5.05% bench-inet_ntop bench-inet_ntop_ipv6 [.] bench_start
3.70% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
2.11% bench-inet_ntop libc.so [.] __printf_buffer_done
A new implementation is used instead:
* The printf usage is replaced with an expanded function that prints
either an IPv4 octet or an IPv6 quartet;
* The strcpy is replaced with a memcpy (since ABIs usually tends to
optimize the latter);
* For IPv6, the '::' shorthanding is done in-place instead of using
a temporary buffer.
* An temporary buffer is used iff the size if larger than
INET_ADDRSTRLEN/INET6_ADDRSTRLEN.
* Inline is used for both inet_ntop4 and inet_ntop6,
The code is significand rewrote, so I take this requires a new license.
The performance results on aarch64 Neoverse1 with gcc 14.2.1:
* master
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.43067e+09,
"iterations": 8e+06,
"reciprocal-throughput": 178.572,
"latency": 179.096,
"max-throughput": 5.59997e+06,
"min-throughput": 5.58359e+06
}
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.68539e+09,
"iterations": 4e+06,
"reciprocal-throughput": 421.307,
"latency": 421.388,
"max-throughput": 2.37357e+06,
"min-throughput": 2.37311e+06
}
}
* patched
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.06133e+09,
"iterations": 5.6e+07,
"reciprocal-throughput": 18.8482,
"latency": 19.0565,
"max-throughput": 5.30555e+07,
"min-throughput": 5.24755e+07
}
}
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.01246e+09,
"iterations": 2.4e+07,
"reciprocal-throughput": 42.5576,
"latency": 41.8139,
"max-throughput": 2.34976e+07,
"min-throughput": 2.39155e+07
}
}
Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: DJ Delorie <dj@redhat.com>
2025-06-04 20:42:43 +00:00
|
|
|
*tp = '0' + word;
|
|
|
|
return tp + s;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline char *
|
|
|
|
put_uint16 (uint16_t word, char *tp)
|
|
|
|
{
|
|
|
|
if (word >= 0x1000)
|
|
|
|
*tp++ = _itoa_lower_digits[(word >> 12) & 0xf];
|
|
|
|
if (word >= 0x100)
|
|
|
|
*tp++ = _itoa_lower_digits[(word >> 8) & 0xf];
|
|
|
|
if (word >= 0x10)
|
|
|
|
*tp++ = _itoa_lower_digits[(word >> 4) & 0xf];
|
|
|
|
*tp++ = _itoa_lower_digits[word & 0xf];
|
|
|
|
return tp;
|
|
|
|
}
|
|
|
|
|
|
|
|
static __always_inline char *
|
|
|
|
inet_ntop4_format (const uint8_t *src, char *dst)
|
|
|
|
{
|
|
|
|
dst = put_uint8 (src[0], dst);
|
|
|
|
*(dst++) = '.';
|
|
|
|
dst = put_uint8 (src[1], dst);
|
|
|
|
*(dst++) = '.';
|
|
|
|
dst = put_uint8 (src[2], dst);
|
|
|
|
*(dst++) = '.';
|
|
|
|
dst = put_uint8 (src[3], dst);
|
|
|
|
*dst++ = '\0';
|
|
|
|
return dst;
|
Wed May 22 22:10:01 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* stdlib/canonicalize.c: New file.
* stdlib/stdlib.h: Declare canonicalize_file_name, realpath.
* stdlib/Makefile (routines): Add canonicalize.
* posix/unistd.h: Declare __canonicalize_directory_name_internal.
Thu May 23 00:01:10 1996 Ulrich Drepper <drepper@cygnus.com>
* db/recno/rec_seq.c: Prevent `sccsid' definition by using the
same #if condition as in the other db files.
* intl/Makefile: Add -Wno-unused CFLAGS for compilation of
bindtextdom.c, finddomain.c, and localealias.c.
* intl/dcgettext.c: Don't define prototype for getcwd() when
compiling in glibc.
* libio/cleanup.c: Add prototype for _IO_register_cleanup.
* libio/filedoalloc.c, libio/fileops.c, libio/iopopen.c: Don't
define _POSIX_SOURCE unconditionally.
* libio/filedoalloc.c, libio/iopopen.c: Include <unistd.h> if
compiling in glibc.
* libio/fileops.c (_IO_file_close_it): Don't sync file, call
flush instead. This relaxes the rules from POSIX.1 about
changing the active handle a bit.
* libio/iofopncook.c (struct _IO_cookie_file): Move definition
into <libio.h>.
Add prototypes for local functions to prevent warnings.
* libio/iopopen.c: Change prototypes for _IO_fork, _IO_pipe, and
_IO_DUP2 to contain complete parameter list.
* libio/libio.h: Add definition of struct _IO_cookie_file.
* libio/libioP.h: Add prototypes for _IO_vasprintf, _IO_vdprintf,
and _IO_vsnprintf.
* libio/memstream.c: Include <stdio.h>.
* libio/stdio.h: Add prototypes for fopencookie,
__stdio_gen_tempname, __vfscanf, __vsscanf, and __vsnprintf.
* libio/strops.c: Avoid useless expression in `for' initializer.
* locale/findlocale.c: Add some casts to prevent warnings.
* locale/programs/locfile.c (write_locale_data): Don't use
double `/' in locale binary file.
* posix/unistd.h: Remove prototype for `reboot'.
Update from bind-4.9.4-T1A.
* resolv/Makefile (routines): Add inet_ntop and inet_pton.
* resolv/arpa/nameser.h: Add definition of IN6ADDRSZ.
* resolv/gethnamaddr.c, resolv/getnetnamadr.c, resolv/res_comp.c,
resolv/res_debug.c, resolv/res_init.c
* resolv/inet_ntop.c, resolv/inet_pton.c: New files.
* resolv/resolv.h: Add RES_USE_INET6 flag.
(__dn_isvalid): Renamed to __res_dnok.
Add prototypes for __res_ownok and __res_mailok.
* stdio-common/Makefile: Add -Wno-unused to CFLAGS for _itoa.c.
* stdio-common/getline.c, stdio-common/vfscanf.c,
sysdeps/posix/tempname.c: Don't use <ansidecl.h> anymore.
* sysdeps/unix/sysv/linux/Makefile [$subdir == misc]
(sysdep_routines): Add s_reboot.
(install-others): Add $(includedir)/sys/syscall.h.
New rule for $(includedir)/sys/syscall.h to produce from
<asm/unistd.h>.
* sysdeps/unix/sysv/linux/reboot.c: New file. Make single
argument function call 3 argument system call.
* sysdeps/unix/sysv/linux/sys/reboot.h: New file. Linux specific
definition for reboot function.
* sysdeps/unix/sysv/linux/syscall.h: Remove old and obsolete
comment.
* sysdeps/unix/sysv/linux/syscalls.list: Rename function for
reboot syscall to __syscall_reboot.
* wcsmbs/wchar.h: Protect prototypes for wcstof and wcstold by
__USE_GNU, not USE_GNU.
Tue May 21 21:55:49 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* locale/programs/charset.c, locale/programs/ld-collate.c:
Add casts to prevent warnings on 64-bit machines.
* locale/programs/ld-monetary.c: Don't do unnecessary tests for
int_frac_digits and frac_digits which only produce warnings.
Mon May 13 23:45:29 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* inet/arpa/inet.h: Backup return type of inet_addr to u_long.
* resolv/inet_addr.c: Likewise.
* resolv/Makefile (distribute): Add res_hconf.h
(routines): Add res_hconf.
* resolv/gethnamaddr.c: Add support for /etc/host.conf.
* resolv/res_init.c: Initialize /etc/host.conf reader.
* resolv/res_hconf.c, resolv/res_hconf.h: New files.
Implementation of reading /etc/host.conf.
Wed May 22 21:21:15 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* Rules (%.out rules): Prepend $($*-ENV) to the command.
* sysdeps/unix/sysv/linux/i386/brk.c (___brk_addr): Define as weak
alias for __curbrk.
Wed May 22 19:37:27 1996 Miles Bader <miles@gnu.ai.mit.edu>
* hurd/hurdexec.c (_hurd_exec): Pass INIT_TRACEMASK.
* hurd/hurdmsg.c (set_int): Support INIT_TRACEMASK.
Wed May 22 18:47:31 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* sysdeps/mach/hurd/getcwd.c
(_hurd_canonicalize_directory_name_internal): New function, broken out
of __getcwd.
(__getcwd): Use it.
(__canonicalize_directory_name_internal): New function using it.
* sysdeps/posix/getcwd.c (__canonicalize_directory_name_internal): New
function, broken out of __getcwd.
(__getcwd): Use it.
Wed May 22 18:14:05 1996 Miles Bader <miles@gnu.ai.mit.edu>
* string/argz-create.c (__argz_create): Correctly calculate length.
* string/argz-extract.c (__argz_extract): Add terminating 0 entry.
* hurd/hurdstartup.c (_hurd_startup): ... and don't so here.
[HAVE_VMSDIR_H]: Include "vmsdir.h".
(glob) [VMS]: Don't grok ~.
1996-05-23 03:15:42 +00:00
|
|
|
}
|
|
|
|
|
resolv: Optimize inet_ntop
The benchtests/inet_ntop_ipv4 and benchtests/inet_ntop_ipv6 profile
shows that most of time is spent in costly sprint operations:
$ perf record ./benchtests/bench-inet_ntop_ipv4 && perf report --stdio
[...]
38.53% bench-inet_ntop libc.so [.] __printf_buffer
18.69% bench-inet_ntop libc.so [.] __printf_buffer_write
11.01% bench-inet_ntop libc.so [.] _itoa_word
8.02% bench-inet_ntop bench-inet_ntop_ipv4 [.] bench_start
6.99% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
3.86% bench-inet_ntop libc.so [.] __strchrnul_avx2
2.82% bench-inet_ntop libc.so [.] __strcpy_avx2
1.90% bench-inet_ntop libc.so [.] inet_ntop4
1.78% bench-inet_ntop libc.so [.] __vsprintf_internal
1.55% bench-inet_ntop libc.so [.] __sprintf_chk
1.18% bench-inet_ntop libc.so [.] __GI___inet_ntop
$ perf record ./benchtests/bench-inet_ntop_ipv6 && perf report --stdio
35.44% bench-inet_ntop libc.so [.] __printf_buffer
14.35% bench-inet_ntop libc.so [.] __printf_buffer_write
10.27% bench-inet_ntop libc.so [.] __GI___inet_ntop
7.93% bench-inet_ntop libc.so [.] _itoa_word
7.00% bench-inet_ntop libc.so [.] __sprintf_chk
6.20% bench-inet_ntop libc.so [.] __vsprintf_internal
5.26% bench-inet_ntop libc.so [.] __strchrnul_avx2
5.05% bench-inet_ntop bench-inet_ntop_ipv6 [.] bench_start
3.70% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
2.11% bench-inet_ntop libc.so [.] __printf_buffer_done
A new implementation is used instead:
* The printf usage is replaced with an expanded function that prints
either an IPv4 octet or an IPv6 quartet;
* The strcpy is replaced with a memcpy (since ABIs usually tends to
optimize the latter);
* For IPv6, the '::' shorthanding is done in-place instead of using
a temporary buffer.
* An temporary buffer is used iff the size if larger than
INET_ADDRSTRLEN/INET6_ADDRSTRLEN.
* Inline is used for both inet_ntop4 and inet_ntop6,
The code is significand rewrote, so I take this requires a new license.
The performance results on aarch64 Neoverse1 with gcc 14.2.1:
* master
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.43067e+09,
"iterations": 8e+06,
"reciprocal-throughput": 178.572,
"latency": 179.096,
"max-throughput": 5.59997e+06,
"min-throughput": 5.58359e+06
}
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.68539e+09,
"iterations": 4e+06,
"reciprocal-throughput": 421.307,
"latency": 421.388,
"max-throughput": 2.37357e+06,
"min-throughput": 2.37311e+06
}
}
* patched
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.06133e+09,
"iterations": 5.6e+07,
"reciprocal-throughput": 18.8482,
"latency": 19.0565,
"max-throughput": 5.30555e+07,
"min-throughput": 5.24755e+07
}
}
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.01246e+09,
"iterations": 2.4e+07,
"reciprocal-throughput": 42.5576,
"latency": 41.8139,
"max-throughput": 2.34976e+07,
"min-throughput": 2.39155e+07
}
}
Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: DJ Delorie <dj@redhat.com>
2025-06-04 20:42:43 +00:00
|
|
|
static __always_inline const char *
|
|
|
|
inet_ntop4 (const uint8_t *src, char *dst, socklen_t size)
|
Wed May 22 22:10:01 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* stdlib/canonicalize.c: New file.
* stdlib/stdlib.h: Declare canonicalize_file_name, realpath.
* stdlib/Makefile (routines): Add canonicalize.
* posix/unistd.h: Declare __canonicalize_directory_name_internal.
Thu May 23 00:01:10 1996 Ulrich Drepper <drepper@cygnus.com>
* db/recno/rec_seq.c: Prevent `sccsid' definition by using the
same #if condition as in the other db files.
* intl/Makefile: Add -Wno-unused CFLAGS for compilation of
bindtextdom.c, finddomain.c, and localealias.c.
* intl/dcgettext.c: Don't define prototype for getcwd() when
compiling in glibc.
* libio/cleanup.c: Add prototype for _IO_register_cleanup.
* libio/filedoalloc.c, libio/fileops.c, libio/iopopen.c: Don't
define _POSIX_SOURCE unconditionally.
* libio/filedoalloc.c, libio/iopopen.c: Include <unistd.h> if
compiling in glibc.
* libio/fileops.c (_IO_file_close_it): Don't sync file, call
flush instead. This relaxes the rules from POSIX.1 about
changing the active handle a bit.
* libio/iofopncook.c (struct _IO_cookie_file): Move definition
into <libio.h>.
Add prototypes for local functions to prevent warnings.
* libio/iopopen.c: Change prototypes for _IO_fork, _IO_pipe, and
_IO_DUP2 to contain complete parameter list.
* libio/libio.h: Add definition of struct _IO_cookie_file.
* libio/libioP.h: Add prototypes for _IO_vasprintf, _IO_vdprintf,
and _IO_vsnprintf.
* libio/memstream.c: Include <stdio.h>.
* libio/stdio.h: Add prototypes for fopencookie,
__stdio_gen_tempname, __vfscanf, __vsscanf, and __vsnprintf.
* libio/strops.c: Avoid useless expression in `for' initializer.
* locale/findlocale.c: Add some casts to prevent warnings.
* locale/programs/locfile.c (write_locale_data): Don't use
double `/' in locale binary file.
* posix/unistd.h: Remove prototype for `reboot'.
Update from bind-4.9.4-T1A.
* resolv/Makefile (routines): Add inet_ntop and inet_pton.
* resolv/arpa/nameser.h: Add definition of IN6ADDRSZ.
* resolv/gethnamaddr.c, resolv/getnetnamadr.c, resolv/res_comp.c,
resolv/res_debug.c, resolv/res_init.c
* resolv/inet_ntop.c, resolv/inet_pton.c: New files.
* resolv/resolv.h: Add RES_USE_INET6 flag.
(__dn_isvalid): Renamed to __res_dnok.
Add prototypes for __res_ownok and __res_mailok.
* stdio-common/Makefile: Add -Wno-unused to CFLAGS for _itoa.c.
* stdio-common/getline.c, stdio-common/vfscanf.c,
sysdeps/posix/tempname.c: Don't use <ansidecl.h> anymore.
* sysdeps/unix/sysv/linux/Makefile [$subdir == misc]
(sysdep_routines): Add s_reboot.
(install-others): Add $(includedir)/sys/syscall.h.
New rule for $(includedir)/sys/syscall.h to produce from
<asm/unistd.h>.
* sysdeps/unix/sysv/linux/reboot.c: New file. Make single
argument function call 3 argument system call.
* sysdeps/unix/sysv/linux/sys/reboot.h: New file. Linux specific
definition for reboot function.
* sysdeps/unix/sysv/linux/syscall.h: Remove old and obsolete
comment.
* sysdeps/unix/sysv/linux/syscalls.list: Rename function for
reboot syscall to __syscall_reboot.
* wcsmbs/wchar.h: Protect prototypes for wcstof and wcstold by
__USE_GNU, not USE_GNU.
Tue May 21 21:55:49 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* locale/programs/charset.c, locale/programs/ld-collate.c:
Add casts to prevent warnings on 64-bit machines.
* locale/programs/ld-monetary.c: Don't do unnecessary tests for
int_frac_digits and frac_digits which only produce warnings.
Mon May 13 23:45:29 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* inet/arpa/inet.h: Backup return type of inet_addr to u_long.
* resolv/inet_addr.c: Likewise.
* resolv/Makefile (distribute): Add res_hconf.h
(routines): Add res_hconf.
* resolv/gethnamaddr.c: Add support for /etc/host.conf.
* resolv/res_init.c: Initialize /etc/host.conf reader.
* resolv/res_hconf.c, resolv/res_hconf.h: New files.
Implementation of reading /etc/host.conf.
Wed May 22 21:21:15 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* Rules (%.out rules): Prepend $($*-ENV) to the command.
* sysdeps/unix/sysv/linux/i386/brk.c (___brk_addr): Define as weak
alias for __curbrk.
Wed May 22 19:37:27 1996 Miles Bader <miles@gnu.ai.mit.edu>
* hurd/hurdexec.c (_hurd_exec): Pass INIT_TRACEMASK.
* hurd/hurdmsg.c (set_int): Support INIT_TRACEMASK.
Wed May 22 18:47:31 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* sysdeps/mach/hurd/getcwd.c
(_hurd_canonicalize_directory_name_internal): New function, broken out
of __getcwd.
(__getcwd): Use it.
(__canonicalize_directory_name_internal): New function using it.
* sysdeps/posix/getcwd.c (__canonicalize_directory_name_internal): New
function, broken out of __getcwd.
(__getcwd): Use it.
Wed May 22 18:14:05 1996 Miles Bader <miles@gnu.ai.mit.edu>
* string/argz-create.c (__argz_create): Correctly calculate length.
* string/argz-extract.c (__argz_extract): Add terminating 0 entry.
* hurd/hurdstartup.c (_hurd_startup): ... and don't so here.
[HAVE_VMSDIR_H]: Include "vmsdir.h".
(glob) [VMS]: Don't grok ~.
1996-05-23 03:15:42 +00:00
|
|
|
{
|
resolv: Optimize inet_ntop
The benchtests/inet_ntop_ipv4 and benchtests/inet_ntop_ipv6 profile
shows that most of time is spent in costly sprint operations:
$ perf record ./benchtests/bench-inet_ntop_ipv4 && perf report --stdio
[...]
38.53% bench-inet_ntop libc.so [.] __printf_buffer
18.69% bench-inet_ntop libc.so [.] __printf_buffer_write
11.01% bench-inet_ntop libc.so [.] _itoa_word
8.02% bench-inet_ntop bench-inet_ntop_ipv4 [.] bench_start
6.99% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
3.86% bench-inet_ntop libc.so [.] __strchrnul_avx2
2.82% bench-inet_ntop libc.so [.] __strcpy_avx2
1.90% bench-inet_ntop libc.so [.] inet_ntop4
1.78% bench-inet_ntop libc.so [.] __vsprintf_internal
1.55% bench-inet_ntop libc.so [.] __sprintf_chk
1.18% bench-inet_ntop libc.so [.] __GI___inet_ntop
$ perf record ./benchtests/bench-inet_ntop_ipv6 && perf report --stdio
35.44% bench-inet_ntop libc.so [.] __printf_buffer
14.35% bench-inet_ntop libc.so [.] __printf_buffer_write
10.27% bench-inet_ntop libc.so [.] __GI___inet_ntop
7.93% bench-inet_ntop libc.so [.] _itoa_word
7.00% bench-inet_ntop libc.so [.] __sprintf_chk
6.20% bench-inet_ntop libc.so [.] __vsprintf_internal
5.26% bench-inet_ntop libc.so [.] __strchrnul_avx2
5.05% bench-inet_ntop bench-inet_ntop_ipv6 [.] bench_start
3.70% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
2.11% bench-inet_ntop libc.so [.] __printf_buffer_done
A new implementation is used instead:
* The printf usage is replaced with an expanded function that prints
either an IPv4 octet or an IPv6 quartet;
* The strcpy is replaced with a memcpy (since ABIs usually tends to
optimize the latter);
* For IPv6, the '::' shorthanding is done in-place instead of using
a temporary buffer.
* An temporary buffer is used iff the size if larger than
INET_ADDRSTRLEN/INET6_ADDRSTRLEN.
* Inline is used for both inet_ntop4 and inet_ntop6,
The code is significand rewrote, so I take this requires a new license.
The performance results on aarch64 Neoverse1 with gcc 14.2.1:
* master
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.43067e+09,
"iterations": 8e+06,
"reciprocal-throughput": 178.572,
"latency": 179.096,
"max-throughput": 5.59997e+06,
"min-throughput": 5.58359e+06
}
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.68539e+09,
"iterations": 4e+06,
"reciprocal-throughput": 421.307,
"latency": 421.388,
"max-throughput": 2.37357e+06,
"min-throughput": 2.37311e+06
}
}
* patched
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.06133e+09,
"iterations": 5.6e+07,
"reciprocal-throughput": 18.8482,
"latency": 19.0565,
"max-throughput": 5.30555e+07,
"min-throughput": 5.24755e+07
}
}
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.01246e+09,
"iterations": 2.4e+07,
"reciprocal-throughput": 42.5576,
"latency": 41.8139,
"max-throughput": 2.34976e+07,
"min-throughput": 2.39155e+07
}
}
Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: DJ Delorie <dj@redhat.com>
2025-06-04 20:42:43 +00:00
|
|
|
if (size >= INET_ADDRSTRLEN)
|
|
|
|
{
|
|
|
|
inet_ntop4_format (src, dst);
|
|
|
|
return dst;
|
|
|
|
}
|
Wed May 22 22:10:01 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* stdlib/canonicalize.c: New file.
* stdlib/stdlib.h: Declare canonicalize_file_name, realpath.
* stdlib/Makefile (routines): Add canonicalize.
* posix/unistd.h: Declare __canonicalize_directory_name_internal.
Thu May 23 00:01:10 1996 Ulrich Drepper <drepper@cygnus.com>
* db/recno/rec_seq.c: Prevent `sccsid' definition by using the
same #if condition as in the other db files.
* intl/Makefile: Add -Wno-unused CFLAGS for compilation of
bindtextdom.c, finddomain.c, and localealias.c.
* intl/dcgettext.c: Don't define prototype for getcwd() when
compiling in glibc.
* libio/cleanup.c: Add prototype for _IO_register_cleanup.
* libio/filedoalloc.c, libio/fileops.c, libio/iopopen.c: Don't
define _POSIX_SOURCE unconditionally.
* libio/filedoalloc.c, libio/iopopen.c: Include <unistd.h> if
compiling in glibc.
* libio/fileops.c (_IO_file_close_it): Don't sync file, call
flush instead. This relaxes the rules from POSIX.1 about
changing the active handle a bit.
* libio/iofopncook.c (struct _IO_cookie_file): Move definition
into <libio.h>.
Add prototypes for local functions to prevent warnings.
* libio/iopopen.c: Change prototypes for _IO_fork, _IO_pipe, and
_IO_DUP2 to contain complete parameter list.
* libio/libio.h: Add definition of struct _IO_cookie_file.
* libio/libioP.h: Add prototypes for _IO_vasprintf, _IO_vdprintf,
and _IO_vsnprintf.
* libio/memstream.c: Include <stdio.h>.
* libio/stdio.h: Add prototypes for fopencookie,
__stdio_gen_tempname, __vfscanf, __vsscanf, and __vsnprintf.
* libio/strops.c: Avoid useless expression in `for' initializer.
* locale/findlocale.c: Add some casts to prevent warnings.
* locale/programs/locfile.c (write_locale_data): Don't use
double `/' in locale binary file.
* posix/unistd.h: Remove prototype for `reboot'.
Update from bind-4.9.4-T1A.
* resolv/Makefile (routines): Add inet_ntop and inet_pton.
* resolv/arpa/nameser.h: Add definition of IN6ADDRSZ.
* resolv/gethnamaddr.c, resolv/getnetnamadr.c, resolv/res_comp.c,
resolv/res_debug.c, resolv/res_init.c
* resolv/inet_ntop.c, resolv/inet_pton.c: New files.
* resolv/resolv.h: Add RES_USE_INET6 flag.
(__dn_isvalid): Renamed to __res_dnok.
Add prototypes for __res_ownok and __res_mailok.
* stdio-common/Makefile: Add -Wno-unused to CFLAGS for _itoa.c.
* stdio-common/getline.c, stdio-common/vfscanf.c,
sysdeps/posix/tempname.c: Don't use <ansidecl.h> anymore.
* sysdeps/unix/sysv/linux/Makefile [$subdir == misc]
(sysdep_routines): Add s_reboot.
(install-others): Add $(includedir)/sys/syscall.h.
New rule for $(includedir)/sys/syscall.h to produce from
<asm/unistd.h>.
* sysdeps/unix/sysv/linux/reboot.c: New file. Make single
argument function call 3 argument system call.
* sysdeps/unix/sysv/linux/sys/reboot.h: New file. Linux specific
definition for reboot function.
* sysdeps/unix/sysv/linux/syscall.h: Remove old and obsolete
comment.
* sysdeps/unix/sysv/linux/syscalls.list: Rename function for
reboot syscall to __syscall_reboot.
* wcsmbs/wchar.h: Protect prototypes for wcstof and wcstold by
__USE_GNU, not USE_GNU.
Tue May 21 21:55:49 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* locale/programs/charset.c, locale/programs/ld-collate.c:
Add casts to prevent warnings on 64-bit machines.
* locale/programs/ld-monetary.c: Don't do unnecessary tests for
int_frac_digits and frac_digits which only produce warnings.
Mon May 13 23:45:29 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* inet/arpa/inet.h: Backup return type of inet_addr to u_long.
* resolv/inet_addr.c: Likewise.
* resolv/Makefile (distribute): Add res_hconf.h
(routines): Add res_hconf.
* resolv/gethnamaddr.c: Add support for /etc/host.conf.
* resolv/res_init.c: Initialize /etc/host.conf reader.
* resolv/res_hconf.c, resolv/res_hconf.h: New files.
Implementation of reading /etc/host.conf.
Wed May 22 21:21:15 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* Rules (%.out rules): Prepend $($*-ENV) to the command.
* sysdeps/unix/sysv/linux/i386/brk.c (___brk_addr): Define as weak
alias for __curbrk.
Wed May 22 19:37:27 1996 Miles Bader <miles@gnu.ai.mit.edu>
* hurd/hurdexec.c (_hurd_exec): Pass INIT_TRACEMASK.
* hurd/hurdmsg.c (set_int): Support INIT_TRACEMASK.
Wed May 22 18:47:31 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* sysdeps/mach/hurd/getcwd.c
(_hurd_canonicalize_directory_name_internal): New function, broken out
of __getcwd.
(__getcwd): Use it.
(__canonicalize_directory_name_internal): New function using it.
* sysdeps/posix/getcwd.c (__canonicalize_directory_name_internal): New
function, broken out of __getcwd.
(__getcwd): Use it.
Wed May 22 18:14:05 1996 Miles Bader <miles@gnu.ai.mit.edu>
* string/argz-create.c (__argz_create): Correctly calculate length.
* string/argz-extract.c (__argz_extract): Add terminating 0 entry.
* hurd/hurdstartup.c (_hurd_startup): ... and don't so here.
[HAVE_VMSDIR_H]: Include "vmsdir.h".
(glob) [VMS]: Don't grok ~.
1996-05-23 03:15:42 +00:00
|
|
|
|
resolv: Optimize inet_ntop
The benchtests/inet_ntop_ipv4 and benchtests/inet_ntop_ipv6 profile
shows that most of time is spent in costly sprint operations:
$ perf record ./benchtests/bench-inet_ntop_ipv4 && perf report --stdio
[...]
38.53% bench-inet_ntop libc.so [.] __printf_buffer
18.69% bench-inet_ntop libc.so [.] __printf_buffer_write
11.01% bench-inet_ntop libc.so [.] _itoa_word
8.02% bench-inet_ntop bench-inet_ntop_ipv4 [.] bench_start
6.99% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
3.86% bench-inet_ntop libc.so [.] __strchrnul_avx2
2.82% bench-inet_ntop libc.so [.] __strcpy_avx2
1.90% bench-inet_ntop libc.so [.] inet_ntop4
1.78% bench-inet_ntop libc.so [.] __vsprintf_internal
1.55% bench-inet_ntop libc.so [.] __sprintf_chk
1.18% bench-inet_ntop libc.so [.] __GI___inet_ntop
$ perf record ./benchtests/bench-inet_ntop_ipv6 && perf report --stdio
35.44% bench-inet_ntop libc.so [.] __printf_buffer
14.35% bench-inet_ntop libc.so [.] __printf_buffer_write
10.27% bench-inet_ntop libc.so [.] __GI___inet_ntop
7.93% bench-inet_ntop libc.so [.] _itoa_word
7.00% bench-inet_ntop libc.so [.] __sprintf_chk
6.20% bench-inet_ntop libc.so [.] __vsprintf_internal
5.26% bench-inet_ntop libc.so [.] __strchrnul_avx2
5.05% bench-inet_ntop bench-inet_ntop_ipv6 [.] bench_start
3.70% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
2.11% bench-inet_ntop libc.so [.] __printf_buffer_done
A new implementation is used instead:
* The printf usage is replaced with an expanded function that prints
either an IPv4 octet or an IPv6 quartet;
* The strcpy is replaced with a memcpy (since ABIs usually tends to
optimize the latter);
* For IPv6, the '::' shorthanding is done in-place instead of using
a temporary buffer.
* An temporary buffer is used iff the size if larger than
INET_ADDRSTRLEN/INET6_ADDRSTRLEN.
* Inline is used for both inet_ntop4 and inet_ntop6,
The code is significand rewrote, so I take this requires a new license.
The performance results on aarch64 Neoverse1 with gcc 14.2.1:
* master
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.43067e+09,
"iterations": 8e+06,
"reciprocal-throughput": 178.572,
"latency": 179.096,
"max-throughput": 5.59997e+06,
"min-throughput": 5.58359e+06
}
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.68539e+09,
"iterations": 4e+06,
"reciprocal-throughput": 421.307,
"latency": 421.388,
"max-throughput": 2.37357e+06,
"min-throughput": 2.37311e+06
}
}
* patched
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.06133e+09,
"iterations": 5.6e+07,
"reciprocal-throughput": 18.8482,
"latency": 19.0565,
"max-throughput": 5.30555e+07,
"min-throughput": 5.24755e+07
}
}
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.01246e+09,
"iterations": 2.4e+07,
"reciprocal-throughput": 42.5576,
"latency": 41.8139,
"max-throughput": 2.34976e+07,
"min-throughput": 2.39155e+07
}
}
Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: DJ Delorie <dj@redhat.com>
2025-06-04 20:42:43 +00:00
|
|
|
char tmp[INET_ADDRSTRLEN];
|
|
|
|
char *tp = inet_ntop4_format (src, tmp);
|
|
|
|
socklen_t tmp_s = tp - tmp;
|
|
|
|
if (tmp_s > size)
|
2025-06-04 20:42:42 +00:00
|
|
|
{
|
|
|
|
__set_errno (ENOSPC);
|
resolv: Optimize inet_ntop
The benchtests/inet_ntop_ipv4 and benchtests/inet_ntop_ipv6 profile
shows that most of time is spent in costly sprint operations:
$ perf record ./benchtests/bench-inet_ntop_ipv4 && perf report --stdio
[...]
38.53% bench-inet_ntop libc.so [.] __printf_buffer
18.69% bench-inet_ntop libc.so [.] __printf_buffer_write
11.01% bench-inet_ntop libc.so [.] _itoa_word
8.02% bench-inet_ntop bench-inet_ntop_ipv4 [.] bench_start
6.99% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
3.86% bench-inet_ntop libc.so [.] __strchrnul_avx2
2.82% bench-inet_ntop libc.so [.] __strcpy_avx2
1.90% bench-inet_ntop libc.so [.] inet_ntop4
1.78% bench-inet_ntop libc.so [.] __vsprintf_internal
1.55% bench-inet_ntop libc.so [.] __sprintf_chk
1.18% bench-inet_ntop libc.so [.] __GI___inet_ntop
$ perf record ./benchtests/bench-inet_ntop_ipv6 && perf report --stdio
35.44% bench-inet_ntop libc.so [.] __printf_buffer
14.35% bench-inet_ntop libc.so [.] __printf_buffer_write
10.27% bench-inet_ntop libc.so [.] __GI___inet_ntop
7.93% bench-inet_ntop libc.so [.] _itoa_word
7.00% bench-inet_ntop libc.so [.] __sprintf_chk
6.20% bench-inet_ntop libc.so [.] __vsprintf_internal
5.26% bench-inet_ntop libc.so [.] __strchrnul_avx2
5.05% bench-inet_ntop bench-inet_ntop_ipv6 [.] bench_start
3.70% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
2.11% bench-inet_ntop libc.so [.] __printf_buffer_done
A new implementation is used instead:
* The printf usage is replaced with an expanded function that prints
either an IPv4 octet or an IPv6 quartet;
* The strcpy is replaced with a memcpy (since ABIs usually tends to
optimize the latter);
* For IPv6, the '::' shorthanding is done in-place instead of using
a temporary buffer.
* An temporary buffer is used iff the size if larger than
INET_ADDRSTRLEN/INET6_ADDRSTRLEN.
* Inline is used for both inet_ntop4 and inet_ntop6,
The code is significand rewrote, so I take this requires a new license.
The performance results on aarch64 Neoverse1 with gcc 14.2.1:
* master
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.43067e+09,
"iterations": 8e+06,
"reciprocal-throughput": 178.572,
"latency": 179.096,
"max-throughput": 5.59997e+06,
"min-throughput": 5.58359e+06
}
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.68539e+09,
"iterations": 4e+06,
"reciprocal-throughput": 421.307,
"latency": 421.388,
"max-throughput": 2.37357e+06,
"min-throughput": 2.37311e+06
}
}
* patched
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.06133e+09,
"iterations": 5.6e+07,
"reciprocal-throughput": 18.8482,
"latency": 19.0565,
"max-throughput": 5.30555e+07,
"min-throughput": 5.24755e+07
}
}
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.01246e+09,
"iterations": 2.4e+07,
"reciprocal-throughput": 42.5576,
"latency": 41.8139,
"max-throughput": 2.34976e+07,
"min-throughput": 2.39155e+07
}
}
Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: DJ Delorie <dj@redhat.com>
2025-06-04 20:42:43 +00:00
|
|
|
return NULL;
|
2025-06-04 20:42:42 +00:00
|
|
|
}
|
resolv: Optimize inet_ntop
The benchtests/inet_ntop_ipv4 and benchtests/inet_ntop_ipv6 profile
shows that most of time is spent in costly sprint operations:
$ perf record ./benchtests/bench-inet_ntop_ipv4 && perf report --stdio
[...]
38.53% bench-inet_ntop libc.so [.] __printf_buffer
18.69% bench-inet_ntop libc.so [.] __printf_buffer_write
11.01% bench-inet_ntop libc.so [.] _itoa_word
8.02% bench-inet_ntop bench-inet_ntop_ipv4 [.] bench_start
6.99% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
3.86% bench-inet_ntop libc.so [.] __strchrnul_avx2
2.82% bench-inet_ntop libc.so [.] __strcpy_avx2
1.90% bench-inet_ntop libc.so [.] inet_ntop4
1.78% bench-inet_ntop libc.so [.] __vsprintf_internal
1.55% bench-inet_ntop libc.so [.] __sprintf_chk
1.18% bench-inet_ntop libc.so [.] __GI___inet_ntop
$ perf record ./benchtests/bench-inet_ntop_ipv6 && perf report --stdio
35.44% bench-inet_ntop libc.so [.] __printf_buffer
14.35% bench-inet_ntop libc.so [.] __printf_buffer_write
10.27% bench-inet_ntop libc.so [.] __GI___inet_ntop
7.93% bench-inet_ntop libc.so [.] _itoa_word
7.00% bench-inet_ntop libc.so [.] __sprintf_chk
6.20% bench-inet_ntop libc.so [.] __vsprintf_internal
5.26% bench-inet_ntop libc.so [.] __strchrnul_avx2
5.05% bench-inet_ntop bench-inet_ntop_ipv6 [.] bench_start
3.70% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
2.11% bench-inet_ntop libc.so [.] __printf_buffer_done
A new implementation is used instead:
* The printf usage is replaced with an expanded function that prints
either an IPv4 octet or an IPv6 quartet;
* The strcpy is replaced with a memcpy (since ABIs usually tends to
optimize the latter);
* For IPv6, the '::' shorthanding is done in-place instead of using
a temporary buffer.
* An temporary buffer is used iff the size if larger than
INET_ADDRSTRLEN/INET6_ADDRSTRLEN.
* Inline is used for both inet_ntop4 and inet_ntop6,
The code is significand rewrote, so I take this requires a new license.
The performance results on aarch64 Neoverse1 with gcc 14.2.1:
* master
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.43067e+09,
"iterations": 8e+06,
"reciprocal-throughput": 178.572,
"latency": 179.096,
"max-throughput": 5.59997e+06,
"min-throughput": 5.58359e+06
}
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.68539e+09,
"iterations": 4e+06,
"reciprocal-throughput": 421.307,
"latency": 421.388,
"max-throughput": 2.37357e+06,
"min-throughput": 2.37311e+06
}
}
* patched
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.06133e+09,
"iterations": 5.6e+07,
"reciprocal-throughput": 18.8482,
"latency": 19.0565,
"max-throughput": 5.30555e+07,
"min-throughput": 5.24755e+07
}
}
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.01246e+09,
"iterations": 2.4e+07,
"reciprocal-throughput": 42.5576,
"latency": 41.8139,
"max-throughput": 2.34976e+07,
"min-throughput": 2.39155e+07
}
}
Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: DJ Delorie <dj@redhat.com>
2025-06-04 20:42:43 +00:00
|
|
|
return memcpy (dst, tmp, tmp_s);
|
Wed May 22 22:10:01 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* stdlib/canonicalize.c: New file.
* stdlib/stdlib.h: Declare canonicalize_file_name, realpath.
* stdlib/Makefile (routines): Add canonicalize.
* posix/unistd.h: Declare __canonicalize_directory_name_internal.
Thu May 23 00:01:10 1996 Ulrich Drepper <drepper@cygnus.com>
* db/recno/rec_seq.c: Prevent `sccsid' definition by using the
same #if condition as in the other db files.
* intl/Makefile: Add -Wno-unused CFLAGS for compilation of
bindtextdom.c, finddomain.c, and localealias.c.
* intl/dcgettext.c: Don't define prototype for getcwd() when
compiling in glibc.
* libio/cleanup.c: Add prototype for _IO_register_cleanup.
* libio/filedoalloc.c, libio/fileops.c, libio/iopopen.c: Don't
define _POSIX_SOURCE unconditionally.
* libio/filedoalloc.c, libio/iopopen.c: Include <unistd.h> if
compiling in glibc.
* libio/fileops.c (_IO_file_close_it): Don't sync file, call
flush instead. This relaxes the rules from POSIX.1 about
changing the active handle a bit.
* libio/iofopncook.c (struct _IO_cookie_file): Move definition
into <libio.h>.
Add prototypes for local functions to prevent warnings.
* libio/iopopen.c: Change prototypes for _IO_fork, _IO_pipe, and
_IO_DUP2 to contain complete parameter list.
* libio/libio.h: Add definition of struct _IO_cookie_file.
* libio/libioP.h: Add prototypes for _IO_vasprintf, _IO_vdprintf,
and _IO_vsnprintf.
* libio/memstream.c: Include <stdio.h>.
* libio/stdio.h: Add prototypes for fopencookie,
__stdio_gen_tempname, __vfscanf, __vsscanf, and __vsnprintf.
* libio/strops.c: Avoid useless expression in `for' initializer.
* locale/findlocale.c: Add some casts to prevent warnings.
* locale/programs/locfile.c (write_locale_data): Don't use
double `/' in locale binary file.
* posix/unistd.h: Remove prototype for `reboot'.
Update from bind-4.9.4-T1A.
* resolv/Makefile (routines): Add inet_ntop and inet_pton.
* resolv/arpa/nameser.h: Add definition of IN6ADDRSZ.
* resolv/gethnamaddr.c, resolv/getnetnamadr.c, resolv/res_comp.c,
resolv/res_debug.c, resolv/res_init.c
* resolv/inet_ntop.c, resolv/inet_pton.c: New files.
* resolv/resolv.h: Add RES_USE_INET6 flag.
(__dn_isvalid): Renamed to __res_dnok.
Add prototypes for __res_ownok and __res_mailok.
* stdio-common/Makefile: Add -Wno-unused to CFLAGS for _itoa.c.
* stdio-common/getline.c, stdio-common/vfscanf.c,
sysdeps/posix/tempname.c: Don't use <ansidecl.h> anymore.
* sysdeps/unix/sysv/linux/Makefile [$subdir == misc]
(sysdep_routines): Add s_reboot.
(install-others): Add $(includedir)/sys/syscall.h.
New rule for $(includedir)/sys/syscall.h to produce from
<asm/unistd.h>.
* sysdeps/unix/sysv/linux/reboot.c: New file. Make single
argument function call 3 argument system call.
* sysdeps/unix/sysv/linux/sys/reboot.h: New file. Linux specific
definition for reboot function.
* sysdeps/unix/sysv/linux/syscall.h: Remove old and obsolete
comment.
* sysdeps/unix/sysv/linux/syscalls.list: Rename function for
reboot syscall to __syscall_reboot.
* wcsmbs/wchar.h: Protect prototypes for wcstof and wcstold by
__USE_GNU, not USE_GNU.
Tue May 21 21:55:49 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* locale/programs/charset.c, locale/programs/ld-collate.c:
Add casts to prevent warnings on 64-bit machines.
* locale/programs/ld-monetary.c: Don't do unnecessary tests for
int_frac_digits and frac_digits which only produce warnings.
Mon May 13 23:45:29 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* inet/arpa/inet.h: Backup return type of inet_addr to u_long.
* resolv/inet_addr.c: Likewise.
* resolv/Makefile (distribute): Add res_hconf.h
(routines): Add res_hconf.
* resolv/gethnamaddr.c: Add support for /etc/host.conf.
* resolv/res_init.c: Initialize /etc/host.conf reader.
* resolv/res_hconf.c, resolv/res_hconf.h: New files.
Implementation of reading /etc/host.conf.
Wed May 22 21:21:15 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* Rules (%.out rules): Prepend $($*-ENV) to the command.
* sysdeps/unix/sysv/linux/i386/brk.c (___brk_addr): Define as weak
alias for __curbrk.
Wed May 22 19:37:27 1996 Miles Bader <miles@gnu.ai.mit.edu>
* hurd/hurdexec.c (_hurd_exec): Pass INIT_TRACEMASK.
* hurd/hurdmsg.c (set_int): Support INIT_TRACEMASK.
Wed May 22 18:47:31 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* sysdeps/mach/hurd/getcwd.c
(_hurd_canonicalize_directory_name_internal): New function, broken out
of __getcwd.
(__getcwd): Use it.
(__canonicalize_directory_name_internal): New function using it.
* sysdeps/posix/getcwd.c (__canonicalize_directory_name_internal): New
function, broken out of __getcwd.
(__getcwd): Use it.
Wed May 22 18:14:05 1996 Miles Bader <miles@gnu.ai.mit.edu>
* string/argz-create.c (__argz_create): Correctly calculate length.
* string/argz-extract.c (__argz_extract): Add terminating 0 entry.
* hurd/hurdstartup.c (_hurd_startup): ... and don't so here.
[HAVE_VMSDIR_H]: Include "vmsdir.h".
(glob) [VMS]: Don't grok ~.
1996-05-23 03:15:42 +00:00
|
|
|
}
|
|
|
|
|
resolv: Optimize inet_ntop
The benchtests/inet_ntop_ipv4 and benchtests/inet_ntop_ipv6 profile
shows that most of time is spent in costly sprint operations:
$ perf record ./benchtests/bench-inet_ntop_ipv4 && perf report --stdio
[...]
38.53% bench-inet_ntop libc.so [.] __printf_buffer
18.69% bench-inet_ntop libc.so [.] __printf_buffer_write
11.01% bench-inet_ntop libc.so [.] _itoa_word
8.02% bench-inet_ntop bench-inet_ntop_ipv4 [.] bench_start
6.99% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
3.86% bench-inet_ntop libc.so [.] __strchrnul_avx2
2.82% bench-inet_ntop libc.so [.] __strcpy_avx2
1.90% bench-inet_ntop libc.so [.] inet_ntop4
1.78% bench-inet_ntop libc.so [.] __vsprintf_internal
1.55% bench-inet_ntop libc.so [.] __sprintf_chk
1.18% bench-inet_ntop libc.so [.] __GI___inet_ntop
$ perf record ./benchtests/bench-inet_ntop_ipv6 && perf report --stdio
35.44% bench-inet_ntop libc.so [.] __printf_buffer
14.35% bench-inet_ntop libc.so [.] __printf_buffer_write
10.27% bench-inet_ntop libc.so [.] __GI___inet_ntop
7.93% bench-inet_ntop libc.so [.] _itoa_word
7.00% bench-inet_ntop libc.so [.] __sprintf_chk
6.20% bench-inet_ntop libc.so [.] __vsprintf_internal
5.26% bench-inet_ntop libc.so [.] __strchrnul_avx2
5.05% bench-inet_ntop bench-inet_ntop_ipv6 [.] bench_start
3.70% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
2.11% bench-inet_ntop libc.so [.] __printf_buffer_done
A new implementation is used instead:
* The printf usage is replaced with an expanded function that prints
either an IPv4 octet or an IPv6 quartet;
* The strcpy is replaced with a memcpy (since ABIs usually tends to
optimize the latter);
* For IPv6, the '::' shorthanding is done in-place instead of using
a temporary buffer.
* An temporary buffer is used iff the size if larger than
INET_ADDRSTRLEN/INET6_ADDRSTRLEN.
* Inline is used for both inet_ntop4 and inet_ntop6,
The code is significand rewrote, so I take this requires a new license.
The performance results on aarch64 Neoverse1 with gcc 14.2.1:
* master
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.43067e+09,
"iterations": 8e+06,
"reciprocal-throughput": 178.572,
"latency": 179.096,
"max-throughput": 5.59997e+06,
"min-throughput": 5.58359e+06
}
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.68539e+09,
"iterations": 4e+06,
"reciprocal-throughput": 421.307,
"latency": 421.388,
"max-throughput": 2.37357e+06,
"min-throughput": 2.37311e+06
}
}
* patched
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.06133e+09,
"iterations": 5.6e+07,
"reciprocal-throughput": 18.8482,
"latency": 19.0565,
"max-throughput": 5.30555e+07,
"min-throughput": 5.24755e+07
}
}
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.01246e+09,
"iterations": 2.4e+07,
"reciprocal-throughput": 42.5576,
"latency": 41.8139,
"max-throughput": 2.34976e+07,
"min-throughput": 2.39155e+07
}
}
Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: DJ Delorie <dj@redhat.com>
2025-06-04 20:42:43 +00:00
|
|
|
struct best_t
|
Wed May 22 22:10:01 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* stdlib/canonicalize.c: New file.
* stdlib/stdlib.h: Declare canonicalize_file_name, realpath.
* stdlib/Makefile (routines): Add canonicalize.
* posix/unistd.h: Declare __canonicalize_directory_name_internal.
Thu May 23 00:01:10 1996 Ulrich Drepper <drepper@cygnus.com>
* db/recno/rec_seq.c: Prevent `sccsid' definition by using the
same #if condition as in the other db files.
* intl/Makefile: Add -Wno-unused CFLAGS for compilation of
bindtextdom.c, finddomain.c, and localealias.c.
* intl/dcgettext.c: Don't define prototype for getcwd() when
compiling in glibc.
* libio/cleanup.c: Add prototype for _IO_register_cleanup.
* libio/filedoalloc.c, libio/fileops.c, libio/iopopen.c: Don't
define _POSIX_SOURCE unconditionally.
* libio/filedoalloc.c, libio/iopopen.c: Include <unistd.h> if
compiling in glibc.
* libio/fileops.c (_IO_file_close_it): Don't sync file, call
flush instead. This relaxes the rules from POSIX.1 about
changing the active handle a bit.
* libio/iofopncook.c (struct _IO_cookie_file): Move definition
into <libio.h>.
Add prototypes for local functions to prevent warnings.
* libio/iopopen.c: Change prototypes for _IO_fork, _IO_pipe, and
_IO_DUP2 to contain complete parameter list.
* libio/libio.h: Add definition of struct _IO_cookie_file.
* libio/libioP.h: Add prototypes for _IO_vasprintf, _IO_vdprintf,
and _IO_vsnprintf.
* libio/memstream.c: Include <stdio.h>.
* libio/stdio.h: Add prototypes for fopencookie,
__stdio_gen_tempname, __vfscanf, __vsscanf, and __vsnprintf.
* libio/strops.c: Avoid useless expression in `for' initializer.
* locale/findlocale.c: Add some casts to prevent warnings.
* locale/programs/locfile.c (write_locale_data): Don't use
double `/' in locale binary file.
* posix/unistd.h: Remove prototype for `reboot'.
Update from bind-4.9.4-T1A.
* resolv/Makefile (routines): Add inet_ntop and inet_pton.
* resolv/arpa/nameser.h: Add definition of IN6ADDRSZ.
* resolv/gethnamaddr.c, resolv/getnetnamadr.c, resolv/res_comp.c,
resolv/res_debug.c, resolv/res_init.c
* resolv/inet_ntop.c, resolv/inet_pton.c: New files.
* resolv/resolv.h: Add RES_USE_INET6 flag.
(__dn_isvalid): Renamed to __res_dnok.
Add prototypes for __res_ownok and __res_mailok.
* stdio-common/Makefile: Add -Wno-unused to CFLAGS for _itoa.c.
* stdio-common/getline.c, stdio-common/vfscanf.c,
sysdeps/posix/tempname.c: Don't use <ansidecl.h> anymore.
* sysdeps/unix/sysv/linux/Makefile [$subdir == misc]
(sysdep_routines): Add s_reboot.
(install-others): Add $(includedir)/sys/syscall.h.
New rule for $(includedir)/sys/syscall.h to produce from
<asm/unistd.h>.
* sysdeps/unix/sysv/linux/reboot.c: New file. Make single
argument function call 3 argument system call.
* sysdeps/unix/sysv/linux/sys/reboot.h: New file. Linux specific
definition for reboot function.
* sysdeps/unix/sysv/linux/syscall.h: Remove old and obsolete
comment.
* sysdeps/unix/sysv/linux/syscalls.list: Rename function for
reboot syscall to __syscall_reboot.
* wcsmbs/wchar.h: Protect prototypes for wcstof and wcstold by
__USE_GNU, not USE_GNU.
Tue May 21 21:55:49 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* locale/programs/charset.c, locale/programs/ld-collate.c:
Add casts to prevent warnings on 64-bit machines.
* locale/programs/ld-monetary.c: Don't do unnecessary tests for
int_frac_digits and frac_digits which only produce warnings.
Mon May 13 23:45:29 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* inet/arpa/inet.h: Backup return type of inet_addr to u_long.
* resolv/inet_addr.c: Likewise.
* resolv/Makefile (distribute): Add res_hconf.h
(routines): Add res_hconf.
* resolv/gethnamaddr.c: Add support for /etc/host.conf.
* resolv/res_init.c: Initialize /etc/host.conf reader.
* resolv/res_hconf.c, resolv/res_hconf.h: New files.
Implementation of reading /etc/host.conf.
Wed May 22 21:21:15 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* Rules (%.out rules): Prepend $($*-ENV) to the command.
* sysdeps/unix/sysv/linux/i386/brk.c (___brk_addr): Define as weak
alias for __curbrk.
Wed May 22 19:37:27 1996 Miles Bader <miles@gnu.ai.mit.edu>
* hurd/hurdexec.c (_hurd_exec): Pass INIT_TRACEMASK.
* hurd/hurdmsg.c (set_int): Support INIT_TRACEMASK.
Wed May 22 18:47:31 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* sysdeps/mach/hurd/getcwd.c
(_hurd_canonicalize_directory_name_internal): New function, broken out
of __getcwd.
(__getcwd): Use it.
(__canonicalize_directory_name_internal): New function using it.
* sysdeps/posix/getcwd.c (__canonicalize_directory_name_internal): New
function, broken out of __getcwd.
(__getcwd): Use it.
Wed May 22 18:14:05 1996 Miles Bader <miles@gnu.ai.mit.edu>
* string/argz-create.c (__argz_create): Correctly calculate length.
* string/argz-extract.c (__argz_extract): Add terminating 0 entry.
* hurd/hurdstartup.c (_hurd_startup): ... and don't so here.
[HAVE_VMSDIR_H]: Include "vmsdir.h".
(glob) [VMS]: Don't grok ~.
1996-05-23 03:15:42 +00:00
|
|
|
{
|
resolv: Optimize inet_ntop
The benchtests/inet_ntop_ipv4 and benchtests/inet_ntop_ipv6 profile
shows that most of time is spent in costly sprint operations:
$ perf record ./benchtests/bench-inet_ntop_ipv4 && perf report --stdio
[...]
38.53% bench-inet_ntop libc.so [.] __printf_buffer
18.69% bench-inet_ntop libc.so [.] __printf_buffer_write
11.01% bench-inet_ntop libc.so [.] _itoa_word
8.02% bench-inet_ntop bench-inet_ntop_ipv4 [.] bench_start
6.99% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
3.86% bench-inet_ntop libc.so [.] __strchrnul_avx2
2.82% bench-inet_ntop libc.so [.] __strcpy_avx2
1.90% bench-inet_ntop libc.so [.] inet_ntop4
1.78% bench-inet_ntop libc.so [.] __vsprintf_internal
1.55% bench-inet_ntop libc.so [.] __sprintf_chk
1.18% bench-inet_ntop libc.so [.] __GI___inet_ntop
$ perf record ./benchtests/bench-inet_ntop_ipv6 && perf report --stdio
35.44% bench-inet_ntop libc.so [.] __printf_buffer
14.35% bench-inet_ntop libc.so [.] __printf_buffer_write
10.27% bench-inet_ntop libc.so [.] __GI___inet_ntop
7.93% bench-inet_ntop libc.so [.] _itoa_word
7.00% bench-inet_ntop libc.so [.] __sprintf_chk
6.20% bench-inet_ntop libc.so [.] __vsprintf_internal
5.26% bench-inet_ntop libc.so [.] __strchrnul_avx2
5.05% bench-inet_ntop bench-inet_ntop_ipv6 [.] bench_start
3.70% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
2.11% bench-inet_ntop libc.so [.] __printf_buffer_done
A new implementation is used instead:
* The printf usage is replaced with an expanded function that prints
either an IPv4 octet or an IPv6 quartet;
* The strcpy is replaced with a memcpy (since ABIs usually tends to
optimize the latter);
* For IPv6, the '::' shorthanding is done in-place instead of using
a temporary buffer.
* An temporary buffer is used iff the size if larger than
INET_ADDRSTRLEN/INET6_ADDRSTRLEN.
* Inline is used for both inet_ntop4 and inet_ntop6,
The code is significand rewrote, so I take this requires a new license.
The performance results on aarch64 Neoverse1 with gcc 14.2.1:
* master
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.43067e+09,
"iterations": 8e+06,
"reciprocal-throughput": 178.572,
"latency": 179.096,
"max-throughput": 5.59997e+06,
"min-throughput": 5.58359e+06
}
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.68539e+09,
"iterations": 4e+06,
"reciprocal-throughput": 421.307,
"latency": 421.388,
"max-throughput": 2.37357e+06,
"min-throughput": 2.37311e+06
}
}
* patched
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.06133e+09,
"iterations": 5.6e+07,
"reciprocal-throughput": 18.8482,
"latency": 19.0565,
"max-throughput": 5.30555e+07,
"min-throughput": 5.24755e+07
}
}
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.01246e+09,
"iterations": 2.4e+07,
"reciprocal-throughput": 42.5576,
"latency": 41.8139,
"max-throughput": 2.34976e+07,
"min-throughput": 2.39155e+07
}
}
Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: DJ Delorie <dj@redhat.com>
2025-06-04 20:42:43 +00:00
|
|
|
int base;
|
|
|
|
int len;
|
|
|
|
};
|
|
|
|
|
|
|
|
static inline uint16_t
|
|
|
|
in6_addr_addr16 (const struct in6_addr *src, int idx)
|
|
|
|
{
|
|
|
|
const struct { uint16_t x; } __attribute__((__packed__)) *pptr =
|
|
|
|
(typeof(pptr))(&src->s6_addr16[idx]);
|
|
|
|
return ntohs (pptr->x);
|
|
|
|
}
|
|
|
|
|
|
|
|
static __always_inline char *
|
|
|
|
inet_ntop6_format (const struct in6_addr *src, struct best_t best, char *dst)
|
|
|
|
{
|
|
|
|
char *tp = dst;
|
|
|
|
for (int i = 0; i < (NS_IN6ADDRSZ / NS_INT16SZ); i++)
|
2025-06-04 20:42:42 +00:00
|
|
|
{
|
resolv: Optimize inet_ntop
The benchtests/inet_ntop_ipv4 and benchtests/inet_ntop_ipv6 profile
shows that most of time is spent in costly sprint operations:
$ perf record ./benchtests/bench-inet_ntop_ipv4 && perf report --stdio
[...]
38.53% bench-inet_ntop libc.so [.] __printf_buffer
18.69% bench-inet_ntop libc.so [.] __printf_buffer_write
11.01% bench-inet_ntop libc.so [.] _itoa_word
8.02% bench-inet_ntop bench-inet_ntop_ipv4 [.] bench_start
6.99% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
3.86% bench-inet_ntop libc.so [.] __strchrnul_avx2
2.82% bench-inet_ntop libc.so [.] __strcpy_avx2
1.90% bench-inet_ntop libc.so [.] inet_ntop4
1.78% bench-inet_ntop libc.so [.] __vsprintf_internal
1.55% bench-inet_ntop libc.so [.] __sprintf_chk
1.18% bench-inet_ntop libc.so [.] __GI___inet_ntop
$ perf record ./benchtests/bench-inet_ntop_ipv6 && perf report --stdio
35.44% bench-inet_ntop libc.so [.] __printf_buffer
14.35% bench-inet_ntop libc.so [.] __printf_buffer_write
10.27% bench-inet_ntop libc.so [.] __GI___inet_ntop
7.93% bench-inet_ntop libc.so [.] _itoa_word
7.00% bench-inet_ntop libc.so [.] __sprintf_chk
6.20% bench-inet_ntop libc.so [.] __vsprintf_internal
5.26% bench-inet_ntop libc.so [.] __strchrnul_avx2
5.05% bench-inet_ntop bench-inet_ntop_ipv6 [.] bench_start
3.70% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
2.11% bench-inet_ntop libc.so [.] __printf_buffer_done
A new implementation is used instead:
* The printf usage is replaced with an expanded function that prints
either an IPv4 octet or an IPv6 quartet;
* The strcpy is replaced with a memcpy (since ABIs usually tends to
optimize the latter);
* For IPv6, the '::' shorthanding is done in-place instead of using
a temporary buffer.
* An temporary buffer is used iff the size if larger than
INET_ADDRSTRLEN/INET6_ADDRSTRLEN.
* Inline is used for both inet_ntop4 and inet_ntop6,
The code is significand rewrote, so I take this requires a new license.
The performance results on aarch64 Neoverse1 with gcc 14.2.1:
* master
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.43067e+09,
"iterations": 8e+06,
"reciprocal-throughput": 178.572,
"latency": 179.096,
"max-throughput": 5.59997e+06,
"min-throughput": 5.58359e+06
}
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.68539e+09,
"iterations": 4e+06,
"reciprocal-throughput": 421.307,
"latency": 421.388,
"max-throughput": 2.37357e+06,
"min-throughput": 2.37311e+06
}
}
* patched
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.06133e+09,
"iterations": 5.6e+07,
"reciprocal-throughput": 18.8482,
"latency": 19.0565,
"max-throughput": 5.30555e+07,
"min-throughput": 5.24755e+07
}
}
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.01246e+09,
"iterations": 2.4e+07,
"reciprocal-throughput": 42.5576,
"latency": 41.8139,
"max-throughput": 2.34976e+07,
"min-throughput": 2.39155e+07
}
}
Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: DJ Delorie <dj@redhat.com>
2025-06-04 20:42:43 +00:00
|
|
|
/* Are we inside the best run of 0x00's? */
|
|
|
|
if (best.base != -1 && i >= best.base && i < (best.base + best.len))
|
|
|
|
{
|
|
|
|
if (i == best.base)
|
|
|
|
*tp++ = ':';
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
/* Are we following an initial run of 0x00s or any real hex? */
|
|
|
|
if (i != 0)
|
|
|
|
*tp++ = ':';
|
|
|
|
/* Is this address an encapsulated IPv4? */
|
|
|
|
if (i == 6 && best.base == 0
|
|
|
|
&& (best.len == 6 || (best.len == 5
|
|
|
|
&& in6_addr_addr16 (src, 5) == 0xffff)))
|
|
|
|
{
|
|
|
|
if (!inet_ntop4 (src->s6_addr + 12, tp,
|
|
|
|
INET6_ADDRSTRLEN - (tp - dst)))
|
|
|
|
return NULL;
|
|
|
|
tp += strlen (tp);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
tp = put_uint16 (in6_addr_addr16 (src, i), tp);
|
|
|
|
}
|
|
|
|
/* Was it a trailing run of 0x00's? */
|
|
|
|
if (best.base != -1 && (best.base + best.len) == (NS_IN6ADDRSZ / NS_INT16SZ))
|
|
|
|
*tp++ = ':';
|
|
|
|
*tp++ = '\0';
|
|
|
|
|
|
|
|
return tp;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline const char *
|
|
|
|
inet_ntop6 (const struct in6_addr *src, char *dst, socklen_t size)
|
|
|
|
{
|
|
|
|
struct best_t best = { -1, 0 }, cur = { -1, 0 };
|
|
|
|
|
|
|
|
/* ind the longest run of 0x00's in src[] for :: shorthanding. */
|
|
|
|
for (int i = 0; i < (NS_IN6ADDRSZ / NS_INT16SZ); i++)
|
|
|
|
{
|
|
|
|
if (in6_addr_addr16 (src, i) == 0)
|
2025-06-04 20:42:42 +00:00
|
|
|
{
|
|
|
|
if (cur.base == -1)
|
|
|
|
cur.base = i, cur.len = 1;
|
|
|
|
else
|
|
|
|
cur.len++;
|
Wed May 22 22:10:01 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* stdlib/canonicalize.c: New file.
* stdlib/stdlib.h: Declare canonicalize_file_name, realpath.
* stdlib/Makefile (routines): Add canonicalize.
* posix/unistd.h: Declare __canonicalize_directory_name_internal.
Thu May 23 00:01:10 1996 Ulrich Drepper <drepper@cygnus.com>
* db/recno/rec_seq.c: Prevent `sccsid' definition by using the
same #if condition as in the other db files.
* intl/Makefile: Add -Wno-unused CFLAGS for compilation of
bindtextdom.c, finddomain.c, and localealias.c.
* intl/dcgettext.c: Don't define prototype for getcwd() when
compiling in glibc.
* libio/cleanup.c: Add prototype for _IO_register_cleanup.
* libio/filedoalloc.c, libio/fileops.c, libio/iopopen.c: Don't
define _POSIX_SOURCE unconditionally.
* libio/filedoalloc.c, libio/iopopen.c: Include <unistd.h> if
compiling in glibc.
* libio/fileops.c (_IO_file_close_it): Don't sync file, call
flush instead. This relaxes the rules from POSIX.1 about
changing the active handle a bit.
* libio/iofopncook.c (struct _IO_cookie_file): Move definition
into <libio.h>.
Add prototypes for local functions to prevent warnings.
* libio/iopopen.c: Change prototypes for _IO_fork, _IO_pipe, and
_IO_DUP2 to contain complete parameter list.
* libio/libio.h: Add definition of struct _IO_cookie_file.
* libio/libioP.h: Add prototypes for _IO_vasprintf, _IO_vdprintf,
and _IO_vsnprintf.
* libio/memstream.c: Include <stdio.h>.
* libio/stdio.h: Add prototypes for fopencookie,
__stdio_gen_tempname, __vfscanf, __vsscanf, and __vsnprintf.
* libio/strops.c: Avoid useless expression in `for' initializer.
* locale/findlocale.c: Add some casts to prevent warnings.
* locale/programs/locfile.c (write_locale_data): Don't use
double `/' in locale binary file.
* posix/unistd.h: Remove prototype for `reboot'.
Update from bind-4.9.4-T1A.
* resolv/Makefile (routines): Add inet_ntop and inet_pton.
* resolv/arpa/nameser.h: Add definition of IN6ADDRSZ.
* resolv/gethnamaddr.c, resolv/getnetnamadr.c, resolv/res_comp.c,
resolv/res_debug.c, resolv/res_init.c
* resolv/inet_ntop.c, resolv/inet_pton.c: New files.
* resolv/resolv.h: Add RES_USE_INET6 flag.
(__dn_isvalid): Renamed to __res_dnok.
Add prototypes for __res_ownok and __res_mailok.
* stdio-common/Makefile: Add -Wno-unused to CFLAGS for _itoa.c.
* stdio-common/getline.c, stdio-common/vfscanf.c,
sysdeps/posix/tempname.c: Don't use <ansidecl.h> anymore.
* sysdeps/unix/sysv/linux/Makefile [$subdir == misc]
(sysdep_routines): Add s_reboot.
(install-others): Add $(includedir)/sys/syscall.h.
New rule for $(includedir)/sys/syscall.h to produce from
<asm/unistd.h>.
* sysdeps/unix/sysv/linux/reboot.c: New file. Make single
argument function call 3 argument system call.
* sysdeps/unix/sysv/linux/sys/reboot.h: New file. Linux specific
definition for reboot function.
* sysdeps/unix/sysv/linux/syscall.h: Remove old and obsolete
comment.
* sysdeps/unix/sysv/linux/syscalls.list: Rename function for
reboot syscall to __syscall_reboot.
* wcsmbs/wchar.h: Protect prototypes for wcstof and wcstold by
__USE_GNU, not USE_GNU.
Tue May 21 21:55:49 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* locale/programs/charset.c, locale/programs/ld-collate.c:
Add casts to prevent warnings on 64-bit machines.
* locale/programs/ld-monetary.c: Don't do unnecessary tests for
int_frac_digits and frac_digits which only produce warnings.
Mon May 13 23:45:29 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* inet/arpa/inet.h: Backup return type of inet_addr to u_long.
* resolv/inet_addr.c: Likewise.
* resolv/Makefile (distribute): Add res_hconf.h
(routines): Add res_hconf.
* resolv/gethnamaddr.c: Add support for /etc/host.conf.
* resolv/res_init.c: Initialize /etc/host.conf reader.
* resolv/res_hconf.c, resolv/res_hconf.h: New files.
Implementation of reading /etc/host.conf.
Wed May 22 21:21:15 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* Rules (%.out rules): Prepend $($*-ENV) to the command.
* sysdeps/unix/sysv/linux/i386/brk.c (___brk_addr): Define as weak
alias for __curbrk.
Wed May 22 19:37:27 1996 Miles Bader <miles@gnu.ai.mit.edu>
* hurd/hurdexec.c (_hurd_exec): Pass INIT_TRACEMASK.
* hurd/hurdmsg.c (set_int): Support INIT_TRACEMASK.
Wed May 22 18:47:31 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* sysdeps/mach/hurd/getcwd.c
(_hurd_canonicalize_directory_name_internal): New function, broken out
of __getcwd.
(__getcwd): Use it.
(__canonicalize_directory_name_internal): New function using it.
* sysdeps/posix/getcwd.c (__canonicalize_directory_name_internal): New
function, broken out of __getcwd.
(__getcwd): Use it.
Wed May 22 18:14:05 1996 Miles Bader <miles@gnu.ai.mit.edu>
* string/argz-create.c (__argz_create): Correctly calculate length.
* string/argz-extract.c (__argz_extract): Add terminating 0 entry.
* hurd/hurdstartup.c (_hurd_startup): ... and don't so here.
[HAVE_VMSDIR_H]: Include "vmsdir.h".
(glob) [VMS]: Don't grok ~.
1996-05-23 03:15:42 +00:00
|
|
|
}
|
2025-06-04 20:42:42 +00:00
|
|
|
else
|
|
|
|
{
|
|
|
|
if (cur.base != -1)
|
|
|
|
{
|
|
|
|
if (best.base == -1 || cur.len > best.len)
|
|
|
|
best = cur;
|
|
|
|
cur.base = -1;
|
|
|
|
}
|
Wed May 22 22:10:01 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* stdlib/canonicalize.c: New file.
* stdlib/stdlib.h: Declare canonicalize_file_name, realpath.
* stdlib/Makefile (routines): Add canonicalize.
* posix/unistd.h: Declare __canonicalize_directory_name_internal.
Thu May 23 00:01:10 1996 Ulrich Drepper <drepper@cygnus.com>
* db/recno/rec_seq.c: Prevent `sccsid' definition by using the
same #if condition as in the other db files.
* intl/Makefile: Add -Wno-unused CFLAGS for compilation of
bindtextdom.c, finddomain.c, and localealias.c.
* intl/dcgettext.c: Don't define prototype for getcwd() when
compiling in glibc.
* libio/cleanup.c: Add prototype for _IO_register_cleanup.
* libio/filedoalloc.c, libio/fileops.c, libio/iopopen.c: Don't
define _POSIX_SOURCE unconditionally.
* libio/filedoalloc.c, libio/iopopen.c: Include <unistd.h> if
compiling in glibc.
* libio/fileops.c (_IO_file_close_it): Don't sync file, call
flush instead. This relaxes the rules from POSIX.1 about
changing the active handle a bit.
* libio/iofopncook.c (struct _IO_cookie_file): Move definition
into <libio.h>.
Add prototypes for local functions to prevent warnings.
* libio/iopopen.c: Change prototypes for _IO_fork, _IO_pipe, and
_IO_DUP2 to contain complete parameter list.
* libio/libio.h: Add definition of struct _IO_cookie_file.
* libio/libioP.h: Add prototypes for _IO_vasprintf, _IO_vdprintf,
and _IO_vsnprintf.
* libio/memstream.c: Include <stdio.h>.
* libio/stdio.h: Add prototypes for fopencookie,
__stdio_gen_tempname, __vfscanf, __vsscanf, and __vsnprintf.
* libio/strops.c: Avoid useless expression in `for' initializer.
* locale/findlocale.c: Add some casts to prevent warnings.
* locale/programs/locfile.c (write_locale_data): Don't use
double `/' in locale binary file.
* posix/unistd.h: Remove prototype for `reboot'.
Update from bind-4.9.4-T1A.
* resolv/Makefile (routines): Add inet_ntop and inet_pton.
* resolv/arpa/nameser.h: Add definition of IN6ADDRSZ.
* resolv/gethnamaddr.c, resolv/getnetnamadr.c, resolv/res_comp.c,
resolv/res_debug.c, resolv/res_init.c
* resolv/inet_ntop.c, resolv/inet_pton.c: New files.
* resolv/resolv.h: Add RES_USE_INET6 flag.
(__dn_isvalid): Renamed to __res_dnok.
Add prototypes for __res_ownok and __res_mailok.
* stdio-common/Makefile: Add -Wno-unused to CFLAGS for _itoa.c.
* stdio-common/getline.c, stdio-common/vfscanf.c,
sysdeps/posix/tempname.c: Don't use <ansidecl.h> anymore.
* sysdeps/unix/sysv/linux/Makefile [$subdir == misc]
(sysdep_routines): Add s_reboot.
(install-others): Add $(includedir)/sys/syscall.h.
New rule for $(includedir)/sys/syscall.h to produce from
<asm/unistd.h>.
* sysdeps/unix/sysv/linux/reboot.c: New file. Make single
argument function call 3 argument system call.
* sysdeps/unix/sysv/linux/sys/reboot.h: New file. Linux specific
definition for reboot function.
* sysdeps/unix/sysv/linux/syscall.h: Remove old and obsolete
comment.
* sysdeps/unix/sysv/linux/syscalls.list: Rename function for
reboot syscall to __syscall_reboot.
* wcsmbs/wchar.h: Protect prototypes for wcstof and wcstold by
__USE_GNU, not USE_GNU.
Tue May 21 21:55:49 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* locale/programs/charset.c, locale/programs/ld-collate.c:
Add casts to prevent warnings on 64-bit machines.
* locale/programs/ld-monetary.c: Don't do unnecessary tests for
int_frac_digits and frac_digits which only produce warnings.
Mon May 13 23:45:29 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* inet/arpa/inet.h: Backup return type of inet_addr to u_long.
* resolv/inet_addr.c: Likewise.
* resolv/Makefile (distribute): Add res_hconf.h
(routines): Add res_hconf.
* resolv/gethnamaddr.c: Add support for /etc/host.conf.
* resolv/res_init.c: Initialize /etc/host.conf reader.
* resolv/res_hconf.c, resolv/res_hconf.h: New files.
Implementation of reading /etc/host.conf.
Wed May 22 21:21:15 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* Rules (%.out rules): Prepend $($*-ENV) to the command.
* sysdeps/unix/sysv/linux/i386/brk.c (___brk_addr): Define as weak
alias for __curbrk.
Wed May 22 19:37:27 1996 Miles Bader <miles@gnu.ai.mit.edu>
* hurd/hurdexec.c (_hurd_exec): Pass INIT_TRACEMASK.
* hurd/hurdmsg.c (set_int): Support INIT_TRACEMASK.
Wed May 22 18:47:31 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* sysdeps/mach/hurd/getcwd.c
(_hurd_canonicalize_directory_name_internal): New function, broken out
of __getcwd.
(__getcwd): Use it.
(__canonicalize_directory_name_internal): New function using it.
* sysdeps/posix/getcwd.c (__canonicalize_directory_name_internal): New
function, broken out of __getcwd.
(__getcwd): Use it.
Wed May 22 18:14:05 1996 Miles Bader <miles@gnu.ai.mit.edu>
* string/argz-create.c (__argz_create): Correctly calculate length.
* string/argz-extract.c (__argz_extract): Add terminating 0 entry.
* hurd/hurdstartup.c (_hurd_startup): ... and don't so here.
[HAVE_VMSDIR_H]: Include "vmsdir.h".
(glob) [VMS]: Don't grok ~.
1996-05-23 03:15:42 +00:00
|
|
|
}
|
2025-06-04 20:42:42 +00:00
|
|
|
}
|
|
|
|
if (cur.base != -1)
|
|
|
|
{
|
|
|
|
if (best.base == -1 || cur.len > best.len)
|
|
|
|
best = cur;
|
|
|
|
}
|
|
|
|
if (best.base != -1 && best.len < 2)
|
|
|
|
best.base = -1;
|
Wed May 22 22:10:01 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* stdlib/canonicalize.c: New file.
* stdlib/stdlib.h: Declare canonicalize_file_name, realpath.
* stdlib/Makefile (routines): Add canonicalize.
* posix/unistd.h: Declare __canonicalize_directory_name_internal.
Thu May 23 00:01:10 1996 Ulrich Drepper <drepper@cygnus.com>
* db/recno/rec_seq.c: Prevent `sccsid' definition by using the
same #if condition as in the other db files.
* intl/Makefile: Add -Wno-unused CFLAGS for compilation of
bindtextdom.c, finddomain.c, and localealias.c.
* intl/dcgettext.c: Don't define prototype for getcwd() when
compiling in glibc.
* libio/cleanup.c: Add prototype for _IO_register_cleanup.
* libio/filedoalloc.c, libio/fileops.c, libio/iopopen.c: Don't
define _POSIX_SOURCE unconditionally.
* libio/filedoalloc.c, libio/iopopen.c: Include <unistd.h> if
compiling in glibc.
* libio/fileops.c (_IO_file_close_it): Don't sync file, call
flush instead. This relaxes the rules from POSIX.1 about
changing the active handle a bit.
* libio/iofopncook.c (struct _IO_cookie_file): Move definition
into <libio.h>.
Add prototypes for local functions to prevent warnings.
* libio/iopopen.c: Change prototypes for _IO_fork, _IO_pipe, and
_IO_DUP2 to contain complete parameter list.
* libio/libio.h: Add definition of struct _IO_cookie_file.
* libio/libioP.h: Add prototypes for _IO_vasprintf, _IO_vdprintf,
and _IO_vsnprintf.
* libio/memstream.c: Include <stdio.h>.
* libio/stdio.h: Add prototypes for fopencookie,
__stdio_gen_tempname, __vfscanf, __vsscanf, and __vsnprintf.
* libio/strops.c: Avoid useless expression in `for' initializer.
* locale/findlocale.c: Add some casts to prevent warnings.
* locale/programs/locfile.c (write_locale_data): Don't use
double `/' in locale binary file.
* posix/unistd.h: Remove prototype for `reboot'.
Update from bind-4.9.4-T1A.
* resolv/Makefile (routines): Add inet_ntop and inet_pton.
* resolv/arpa/nameser.h: Add definition of IN6ADDRSZ.
* resolv/gethnamaddr.c, resolv/getnetnamadr.c, resolv/res_comp.c,
resolv/res_debug.c, resolv/res_init.c
* resolv/inet_ntop.c, resolv/inet_pton.c: New files.
* resolv/resolv.h: Add RES_USE_INET6 flag.
(__dn_isvalid): Renamed to __res_dnok.
Add prototypes for __res_ownok and __res_mailok.
* stdio-common/Makefile: Add -Wno-unused to CFLAGS for _itoa.c.
* stdio-common/getline.c, stdio-common/vfscanf.c,
sysdeps/posix/tempname.c: Don't use <ansidecl.h> anymore.
* sysdeps/unix/sysv/linux/Makefile [$subdir == misc]
(sysdep_routines): Add s_reboot.
(install-others): Add $(includedir)/sys/syscall.h.
New rule for $(includedir)/sys/syscall.h to produce from
<asm/unistd.h>.
* sysdeps/unix/sysv/linux/reboot.c: New file. Make single
argument function call 3 argument system call.
* sysdeps/unix/sysv/linux/sys/reboot.h: New file. Linux specific
definition for reboot function.
* sysdeps/unix/sysv/linux/syscall.h: Remove old and obsolete
comment.
* sysdeps/unix/sysv/linux/syscalls.list: Rename function for
reboot syscall to __syscall_reboot.
* wcsmbs/wchar.h: Protect prototypes for wcstof and wcstold by
__USE_GNU, not USE_GNU.
Tue May 21 21:55:49 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* locale/programs/charset.c, locale/programs/ld-collate.c:
Add casts to prevent warnings on 64-bit machines.
* locale/programs/ld-monetary.c: Don't do unnecessary tests for
int_frac_digits and frac_digits which only produce warnings.
Mon May 13 23:45:29 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* inet/arpa/inet.h: Backup return type of inet_addr to u_long.
* resolv/inet_addr.c: Likewise.
* resolv/Makefile (distribute): Add res_hconf.h
(routines): Add res_hconf.
* resolv/gethnamaddr.c: Add support for /etc/host.conf.
* resolv/res_init.c: Initialize /etc/host.conf reader.
* resolv/res_hconf.c, resolv/res_hconf.h: New files.
Implementation of reading /etc/host.conf.
Wed May 22 21:21:15 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* Rules (%.out rules): Prepend $($*-ENV) to the command.
* sysdeps/unix/sysv/linux/i386/brk.c (___brk_addr): Define as weak
alias for __curbrk.
Wed May 22 19:37:27 1996 Miles Bader <miles@gnu.ai.mit.edu>
* hurd/hurdexec.c (_hurd_exec): Pass INIT_TRACEMASK.
* hurd/hurdmsg.c (set_int): Support INIT_TRACEMASK.
Wed May 22 18:47:31 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* sysdeps/mach/hurd/getcwd.c
(_hurd_canonicalize_directory_name_internal): New function, broken out
of __getcwd.
(__getcwd): Use it.
(__canonicalize_directory_name_internal): New function using it.
* sysdeps/posix/getcwd.c (__canonicalize_directory_name_internal): New
function, broken out of __getcwd.
(__getcwd): Use it.
Wed May 22 18:14:05 1996 Miles Bader <miles@gnu.ai.mit.edu>
* string/argz-create.c (__argz_create): Correctly calculate length.
* string/argz-extract.c (__argz_extract): Add terminating 0 entry.
* hurd/hurdstartup.c (_hurd_startup): ... and don't so here.
[HAVE_VMSDIR_H]: Include "vmsdir.h".
(glob) [VMS]: Don't grok ~.
1996-05-23 03:15:42 +00:00
|
|
|
|
resolv: Optimize inet_ntop
The benchtests/inet_ntop_ipv4 and benchtests/inet_ntop_ipv6 profile
shows that most of time is spent in costly sprint operations:
$ perf record ./benchtests/bench-inet_ntop_ipv4 && perf report --stdio
[...]
38.53% bench-inet_ntop libc.so [.] __printf_buffer
18.69% bench-inet_ntop libc.so [.] __printf_buffer_write
11.01% bench-inet_ntop libc.so [.] _itoa_word
8.02% bench-inet_ntop bench-inet_ntop_ipv4 [.] bench_start
6.99% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
3.86% bench-inet_ntop libc.so [.] __strchrnul_avx2
2.82% bench-inet_ntop libc.so [.] __strcpy_avx2
1.90% bench-inet_ntop libc.so [.] inet_ntop4
1.78% bench-inet_ntop libc.so [.] __vsprintf_internal
1.55% bench-inet_ntop libc.so [.] __sprintf_chk
1.18% bench-inet_ntop libc.so [.] __GI___inet_ntop
$ perf record ./benchtests/bench-inet_ntop_ipv6 && perf report --stdio
35.44% bench-inet_ntop libc.so [.] __printf_buffer
14.35% bench-inet_ntop libc.so [.] __printf_buffer_write
10.27% bench-inet_ntop libc.so [.] __GI___inet_ntop
7.93% bench-inet_ntop libc.so [.] _itoa_word
7.00% bench-inet_ntop libc.so [.] __sprintf_chk
6.20% bench-inet_ntop libc.so [.] __vsprintf_internal
5.26% bench-inet_ntop libc.so [.] __strchrnul_avx2
5.05% bench-inet_ntop bench-inet_ntop_ipv6 [.] bench_start
3.70% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
2.11% bench-inet_ntop libc.so [.] __printf_buffer_done
A new implementation is used instead:
* The printf usage is replaced with an expanded function that prints
either an IPv4 octet or an IPv6 quartet;
* The strcpy is replaced with a memcpy (since ABIs usually tends to
optimize the latter);
* For IPv6, the '::' shorthanding is done in-place instead of using
a temporary buffer.
* An temporary buffer is used iff the size if larger than
INET_ADDRSTRLEN/INET6_ADDRSTRLEN.
* Inline is used for both inet_ntop4 and inet_ntop6,
The code is significand rewrote, so I take this requires a new license.
The performance results on aarch64 Neoverse1 with gcc 14.2.1:
* master
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.43067e+09,
"iterations": 8e+06,
"reciprocal-throughput": 178.572,
"latency": 179.096,
"max-throughput": 5.59997e+06,
"min-throughput": 5.58359e+06
}
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.68539e+09,
"iterations": 4e+06,
"reciprocal-throughput": 421.307,
"latency": 421.388,
"max-throughput": 2.37357e+06,
"min-throughput": 2.37311e+06
}
}
* patched
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.06133e+09,
"iterations": 5.6e+07,
"reciprocal-throughput": 18.8482,
"latency": 19.0565,
"max-throughput": 5.30555e+07,
"min-throughput": 5.24755e+07
}
}
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.01246e+09,
"iterations": 2.4e+07,
"reciprocal-throughput": 42.5576,
"latency": 41.8139,
"max-throughput": 2.34976e+07,
"min-throughput": 2.39155e+07
}
}
Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: DJ Delorie <dj@redhat.com>
2025-06-04 20:42:43 +00:00
|
|
|
if (size >= INET6_ADDRSTRLEN)
|
2025-06-04 20:42:42 +00:00
|
|
|
{
|
resolv: Optimize inet_ntop
The benchtests/inet_ntop_ipv4 and benchtests/inet_ntop_ipv6 profile
shows that most of time is spent in costly sprint operations:
$ perf record ./benchtests/bench-inet_ntop_ipv4 && perf report --stdio
[...]
38.53% bench-inet_ntop libc.so [.] __printf_buffer
18.69% bench-inet_ntop libc.so [.] __printf_buffer_write
11.01% bench-inet_ntop libc.so [.] _itoa_word
8.02% bench-inet_ntop bench-inet_ntop_ipv4 [.] bench_start
6.99% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
3.86% bench-inet_ntop libc.so [.] __strchrnul_avx2
2.82% bench-inet_ntop libc.so [.] __strcpy_avx2
1.90% bench-inet_ntop libc.so [.] inet_ntop4
1.78% bench-inet_ntop libc.so [.] __vsprintf_internal
1.55% bench-inet_ntop libc.so [.] __sprintf_chk
1.18% bench-inet_ntop libc.so [.] __GI___inet_ntop
$ perf record ./benchtests/bench-inet_ntop_ipv6 && perf report --stdio
35.44% bench-inet_ntop libc.so [.] __printf_buffer
14.35% bench-inet_ntop libc.so [.] __printf_buffer_write
10.27% bench-inet_ntop libc.so [.] __GI___inet_ntop
7.93% bench-inet_ntop libc.so [.] _itoa_word
7.00% bench-inet_ntop libc.so [.] __sprintf_chk
6.20% bench-inet_ntop libc.so [.] __vsprintf_internal
5.26% bench-inet_ntop libc.so [.] __strchrnul_avx2
5.05% bench-inet_ntop bench-inet_ntop_ipv6 [.] bench_start
3.70% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
2.11% bench-inet_ntop libc.so [.] __printf_buffer_done
A new implementation is used instead:
* The printf usage is replaced with an expanded function that prints
either an IPv4 octet or an IPv6 quartet;
* The strcpy is replaced with a memcpy (since ABIs usually tends to
optimize the latter);
* For IPv6, the '::' shorthanding is done in-place instead of using
a temporary buffer.
* An temporary buffer is used iff the size if larger than
INET_ADDRSTRLEN/INET6_ADDRSTRLEN.
* Inline is used for both inet_ntop4 and inet_ntop6,
The code is significand rewrote, so I take this requires a new license.
The performance results on aarch64 Neoverse1 with gcc 14.2.1:
* master
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.43067e+09,
"iterations": 8e+06,
"reciprocal-throughput": 178.572,
"latency": 179.096,
"max-throughput": 5.59997e+06,
"min-throughput": 5.58359e+06
}
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.68539e+09,
"iterations": 4e+06,
"reciprocal-throughput": 421.307,
"latency": 421.388,
"max-throughput": 2.37357e+06,
"min-throughput": 2.37311e+06
}
}
* patched
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.06133e+09,
"iterations": 5.6e+07,
"reciprocal-throughput": 18.8482,
"latency": 19.0565,
"max-throughput": 5.30555e+07,
"min-throughput": 5.24755e+07
}
}
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.01246e+09,
"iterations": 2.4e+07,
"reciprocal-throughput": 42.5576,
"latency": 41.8139,
"max-throughput": 2.34976e+07,
"min-throughput": 2.39155e+07
}
}
Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: DJ Delorie <dj@redhat.com>
2025-06-04 20:42:43 +00:00
|
|
|
inet_ntop6_format (src, best, dst);
|
|
|
|
return dst;
|
2025-06-04 20:42:42 +00:00
|
|
|
}
|
|
|
|
|
resolv: Optimize inet_ntop
The benchtests/inet_ntop_ipv4 and benchtests/inet_ntop_ipv6 profile
shows that most of time is spent in costly sprint operations:
$ perf record ./benchtests/bench-inet_ntop_ipv4 && perf report --stdio
[...]
38.53% bench-inet_ntop libc.so [.] __printf_buffer
18.69% bench-inet_ntop libc.so [.] __printf_buffer_write
11.01% bench-inet_ntop libc.so [.] _itoa_word
8.02% bench-inet_ntop bench-inet_ntop_ipv4 [.] bench_start
6.99% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
3.86% bench-inet_ntop libc.so [.] __strchrnul_avx2
2.82% bench-inet_ntop libc.so [.] __strcpy_avx2
1.90% bench-inet_ntop libc.so [.] inet_ntop4
1.78% bench-inet_ntop libc.so [.] __vsprintf_internal
1.55% bench-inet_ntop libc.so [.] __sprintf_chk
1.18% bench-inet_ntop libc.so [.] __GI___inet_ntop
$ perf record ./benchtests/bench-inet_ntop_ipv6 && perf report --stdio
35.44% bench-inet_ntop libc.so [.] __printf_buffer
14.35% bench-inet_ntop libc.so [.] __printf_buffer_write
10.27% bench-inet_ntop libc.so [.] __GI___inet_ntop
7.93% bench-inet_ntop libc.so [.] _itoa_word
7.00% bench-inet_ntop libc.so [.] __sprintf_chk
6.20% bench-inet_ntop libc.so [.] __vsprintf_internal
5.26% bench-inet_ntop libc.so [.] __strchrnul_avx2
5.05% bench-inet_ntop bench-inet_ntop_ipv6 [.] bench_start
3.70% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
2.11% bench-inet_ntop libc.so [.] __printf_buffer_done
A new implementation is used instead:
* The printf usage is replaced with an expanded function that prints
either an IPv4 octet or an IPv6 quartet;
* The strcpy is replaced with a memcpy (since ABIs usually tends to
optimize the latter);
* For IPv6, the '::' shorthanding is done in-place instead of using
a temporary buffer.
* An temporary buffer is used iff the size if larger than
INET_ADDRSTRLEN/INET6_ADDRSTRLEN.
* Inline is used for both inet_ntop4 and inet_ntop6,
The code is significand rewrote, so I take this requires a new license.
The performance results on aarch64 Neoverse1 with gcc 14.2.1:
* master
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.43067e+09,
"iterations": 8e+06,
"reciprocal-throughput": 178.572,
"latency": 179.096,
"max-throughput": 5.59997e+06,
"min-throughput": 5.58359e+06
}
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.68539e+09,
"iterations": 4e+06,
"reciprocal-throughput": 421.307,
"latency": 421.388,
"max-throughput": 2.37357e+06,
"min-throughput": 2.37311e+06
}
}
* patched
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.06133e+09,
"iterations": 5.6e+07,
"reciprocal-throughput": 18.8482,
"latency": 19.0565,
"max-throughput": 5.30555e+07,
"min-throughput": 5.24755e+07
}
}
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.01246e+09,
"iterations": 2.4e+07,
"reciprocal-throughput": 42.5576,
"latency": 41.8139,
"max-throughput": 2.34976e+07,
"min-throughput": 2.39155e+07
}
}
Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: DJ Delorie <dj@redhat.com>
2025-06-04 20:42:43 +00:00
|
|
|
char tmp[INET6_ADDRSTRLEN];
|
|
|
|
char *tp = inet_ntop6_format (src, best, tmp);
|
|
|
|
|
|
|
|
socklen_t tmp_s = tp - tmp;
|
|
|
|
if (tmp_s > size)
|
2025-06-04 20:42:42 +00:00
|
|
|
{
|
|
|
|
__set_errno (ENOSPC);
|
|
|
|
return (NULL);
|
|
|
|
}
|
resolv: Optimize inet_ntop
The benchtests/inet_ntop_ipv4 and benchtests/inet_ntop_ipv6 profile
shows that most of time is spent in costly sprint operations:
$ perf record ./benchtests/bench-inet_ntop_ipv4 && perf report --stdio
[...]
38.53% bench-inet_ntop libc.so [.] __printf_buffer
18.69% bench-inet_ntop libc.so [.] __printf_buffer_write
11.01% bench-inet_ntop libc.so [.] _itoa_word
8.02% bench-inet_ntop bench-inet_ntop_ipv4 [.] bench_start
6.99% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
3.86% bench-inet_ntop libc.so [.] __strchrnul_avx2
2.82% bench-inet_ntop libc.so [.] __strcpy_avx2
1.90% bench-inet_ntop libc.so [.] inet_ntop4
1.78% bench-inet_ntop libc.so [.] __vsprintf_internal
1.55% bench-inet_ntop libc.so [.] __sprintf_chk
1.18% bench-inet_ntop libc.so [.] __GI___inet_ntop
$ perf record ./benchtests/bench-inet_ntop_ipv6 && perf report --stdio
35.44% bench-inet_ntop libc.so [.] __printf_buffer
14.35% bench-inet_ntop libc.so [.] __printf_buffer_write
10.27% bench-inet_ntop libc.so [.] __GI___inet_ntop
7.93% bench-inet_ntop libc.so [.] _itoa_word
7.00% bench-inet_ntop libc.so [.] __sprintf_chk
6.20% bench-inet_ntop libc.so [.] __vsprintf_internal
5.26% bench-inet_ntop libc.so [.] __strchrnul_avx2
5.05% bench-inet_ntop bench-inet_ntop_ipv6 [.] bench_start
3.70% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
2.11% bench-inet_ntop libc.so [.] __printf_buffer_done
A new implementation is used instead:
* The printf usage is replaced with an expanded function that prints
either an IPv4 octet or an IPv6 quartet;
* The strcpy is replaced with a memcpy (since ABIs usually tends to
optimize the latter);
* For IPv6, the '::' shorthanding is done in-place instead of using
a temporary buffer.
* An temporary buffer is used iff the size if larger than
INET_ADDRSTRLEN/INET6_ADDRSTRLEN.
* Inline is used for both inet_ntop4 and inet_ntop6,
The code is significand rewrote, so I take this requires a new license.
The performance results on aarch64 Neoverse1 with gcc 14.2.1:
* master
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.43067e+09,
"iterations": 8e+06,
"reciprocal-throughput": 178.572,
"latency": 179.096,
"max-throughput": 5.59997e+06,
"min-throughput": 5.58359e+06
}
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.68539e+09,
"iterations": 4e+06,
"reciprocal-throughput": 421.307,
"latency": 421.388,
"max-throughput": 2.37357e+06,
"min-throughput": 2.37311e+06
}
}
* patched
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.06133e+09,
"iterations": 5.6e+07,
"reciprocal-throughput": 18.8482,
"latency": 19.0565,
"max-throughput": 5.30555e+07,
"min-throughput": 5.24755e+07
}
}
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.01246e+09,
"iterations": 2.4e+07,
"reciprocal-throughput": 42.5576,
"latency": 41.8139,
"max-throughput": 2.34976e+07,
"min-throughput": 2.39155e+07
}
}
Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: DJ Delorie <dj@redhat.com>
2025-06-04 20:42:43 +00:00
|
|
|
return memcpy (dst, tmp, tmp_s);
|
|
|
|
}
|
|
|
|
|
|
|
|
const char *
|
|
|
|
__inet_ntop (int af, const void *src, char *dst, socklen_t size)
|
|
|
|
{
|
|
|
|
switch (af)
|
|
|
|
{
|
|
|
|
case AF_INET:
|
|
|
|
return (inet_ntop4 (src, dst, size));
|
|
|
|
case AF_INET6:
|
|
|
|
return (inet_ntop6 (src, dst, size));
|
|
|
|
default:
|
|
|
|
__set_errno (EAFNOSUPPORT);
|
|
|
|
return (NULL);
|
|
|
|
}
|
Wed May 22 22:10:01 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* stdlib/canonicalize.c: New file.
* stdlib/stdlib.h: Declare canonicalize_file_name, realpath.
* stdlib/Makefile (routines): Add canonicalize.
* posix/unistd.h: Declare __canonicalize_directory_name_internal.
Thu May 23 00:01:10 1996 Ulrich Drepper <drepper@cygnus.com>
* db/recno/rec_seq.c: Prevent `sccsid' definition by using the
same #if condition as in the other db files.
* intl/Makefile: Add -Wno-unused CFLAGS for compilation of
bindtextdom.c, finddomain.c, and localealias.c.
* intl/dcgettext.c: Don't define prototype for getcwd() when
compiling in glibc.
* libio/cleanup.c: Add prototype for _IO_register_cleanup.
* libio/filedoalloc.c, libio/fileops.c, libio/iopopen.c: Don't
define _POSIX_SOURCE unconditionally.
* libio/filedoalloc.c, libio/iopopen.c: Include <unistd.h> if
compiling in glibc.
* libio/fileops.c (_IO_file_close_it): Don't sync file, call
flush instead. This relaxes the rules from POSIX.1 about
changing the active handle a bit.
* libio/iofopncook.c (struct _IO_cookie_file): Move definition
into <libio.h>.
Add prototypes for local functions to prevent warnings.
* libio/iopopen.c: Change prototypes for _IO_fork, _IO_pipe, and
_IO_DUP2 to contain complete parameter list.
* libio/libio.h: Add definition of struct _IO_cookie_file.
* libio/libioP.h: Add prototypes for _IO_vasprintf, _IO_vdprintf,
and _IO_vsnprintf.
* libio/memstream.c: Include <stdio.h>.
* libio/stdio.h: Add prototypes for fopencookie,
__stdio_gen_tempname, __vfscanf, __vsscanf, and __vsnprintf.
* libio/strops.c: Avoid useless expression in `for' initializer.
* locale/findlocale.c: Add some casts to prevent warnings.
* locale/programs/locfile.c (write_locale_data): Don't use
double `/' in locale binary file.
* posix/unistd.h: Remove prototype for `reboot'.
Update from bind-4.9.4-T1A.
* resolv/Makefile (routines): Add inet_ntop and inet_pton.
* resolv/arpa/nameser.h: Add definition of IN6ADDRSZ.
* resolv/gethnamaddr.c, resolv/getnetnamadr.c, resolv/res_comp.c,
resolv/res_debug.c, resolv/res_init.c
* resolv/inet_ntop.c, resolv/inet_pton.c: New files.
* resolv/resolv.h: Add RES_USE_INET6 flag.
(__dn_isvalid): Renamed to __res_dnok.
Add prototypes for __res_ownok and __res_mailok.
* stdio-common/Makefile: Add -Wno-unused to CFLAGS for _itoa.c.
* stdio-common/getline.c, stdio-common/vfscanf.c,
sysdeps/posix/tempname.c: Don't use <ansidecl.h> anymore.
* sysdeps/unix/sysv/linux/Makefile [$subdir == misc]
(sysdep_routines): Add s_reboot.
(install-others): Add $(includedir)/sys/syscall.h.
New rule for $(includedir)/sys/syscall.h to produce from
<asm/unistd.h>.
* sysdeps/unix/sysv/linux/reboot.c: New file. Make single
argument function call 3 argument system call.
* sysdeps/unix/sysv/linux/sys/reboot.h: New file. Linux specific
definition for reboot function.
* sysdeps/unix/sysv/linux/syscall.h: Remove old and obsolete
comment.
* sysdeps/unix/sysv/linux/syscalls.list: Rename function for
reboot syscall to __syscall_reboot.
* wcsmbs/wchar.h: Protect prototypes for wcstof and wcstold by
__USE_GNU, not USE_GNU.
Tue May 21 21:55:49 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* locale/programs/charset.c, locale/programs/ld-collate.c:
Add casts to prevent warnings on 64-bit machines.
* locale/programs/ld-monetary.c: Don't do unnecessary tests for
int_frac_digits and frac_digits which only produce warnings.
Mon May 13 23:45:29 1996 David Mosberger-Tang <davidm@AZStarNet.com>
* inet/arpa/inet.h: Backup return type of inet_addr to u_long.
* resolv/inet_addr.c: Likewise.
* resolv/Makefile (distribute): Add res_hconf.h
(routines): Add res_hconf.
* resolv/gethnamaddr.c: Add support for /etc/host.conf.
* resolv/res_init.c: Initialize /etc/host.conf reader.
* resolv/res_hconf.c, resolv/res_hconf.h: New files.
Implementation of reading /etc/host.conf.
Wed May 22 21:21:15 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* Rules (%.out rules): Prepend $($*-ENV) to the command.
* sysdeps/unix/sysv/linux/i386/brk.c (___brk_addr): Define as weak
alias for __curbrk.
Wed May 22 19:37:27 1996 Miles Bader <miles@gnu.ai.mit.edu>
* hurd/hurdexec.c (_hurd_exec): Pass INIT_TRACEMASK.
* hurd/hurdmsg.c (set_int): Support INIT_TRACEMASK.
Wed May 22 18:47:31 1996 Roland McGrath <roland@delasyd.gnu.ai.mit.edu>
* sysdeps/mach/hurd/getcwd.c
(_hurd_canonicalize_directory_name_internal): New function, broken out
of __getcwd.
(__getcwd): Use it.
(__canonicalize_directory_name_internal): New function using it.
* sysdeps/posix/getcwd.c (__canonicalize_directory_name_internal): New
function, broken out of __getcwd.
(__getcwd): Use it.
Wed May 22 18:14:05 1996 Miles Bader <miles@gnu.ai.mit.edu>
* string/argz-create.c (__argz_create): Correctly calculate length.
* string/argz-extract.c (__argz_extract): Add terminating 0 entry.
* hurd/hurdstartup.c (_hurd_startup): ... and don't so here.
[HAVE_VMSDIR_H]: Include "vmsdir.h".
(glob) [VMS]: Don't grok ~.
1996-05-23 03:15:42 +00:00
|
|
|
}
|
resolv: Optimize inet_ntop
The benchtests/inet_ntop_ipv4 and benchtests/inet_ntop_ipv6 profile
shows that most of time is spent in costly sprint operations:
$ perf record ./benchtests/bench-inet_ntop_ipv4 && perf report --stdio
[...]
38.53% bench-inet_ntop libc.so [.] __printf_buffer
18.69% bench-inet_ntop libc.so [.] __printf_buffer_write
11.01% bench-inet_ntop libc.so [.] _itoa_word
8.02% bench-inet_ntop bench-inet_ntop_ipv4 [.] bench_start
6.99% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
3.86% bench-inet_ntop libc.so [.] __strchrnul_avx2
2.82% bench-inet_ntop libc.so [.] __strcpy_avx2
1.90% bench-inet_ntop libc.so [.] inet_ntop4
1.78% bench-inet_ntop libc.so [.] __vsprintf_internal
1.55% bench-inet_ntop libc.so [.] __sprintf_chk
1.18% bench-inet_ntop libc.so [.] __GI___inet_ntop
$ perf record ./benchtests/bench-inet_ntop_ipv6 && perf report --stdio
35.44% bench-inet_ntop libc.so [.] __printf_buffer
14.35% bench-inet_ntop libc.so [.] __printf_buffer_write
10.27% bench-inet_ntop libc.so [.] __GI___inet_ntop
7.93% bench-inet_ntop libc.so [.] _itoa_word
7.00% bench-inet_ntop libc.so [.] __sprintf_chk
6.20% bench-inet_ntop libc.so [.] __vsprintf_internal
5.26% bench-inet_ntop libc.so [.] __strchrnul_avx2
5.05% bench-inet_ntop bench-inet_ntop_ipv6 [.] bench_start
3.70% bench-inet_ntop libc.so [.] __memmove_avx_unaligned_erms
2.11% bench-inet_ntop libc.so [.] __printf_buffer_done
A new implementation is used instead:
* The printf usage is replaced with an expanded function that prints
either an IPv4 octet or an IPv6 quartet;
* The strcpy is replaced with a memcpy (since ABIs usually tends to
optimize the latter);
* For IPv6, the '::' shorthanding is done in-place instead of using
a temporary buffer.
* An temporary buffer is used iff the size if larger than
INET_ADDRSTRLEN/INET6_ADDRSTRLEN.
* Inline is used for both inet_ntop4 and inet_ntop6,
The code is significand rewrote, so I take this requires a new license.
The performance results on aarch64 Neoverse1 with gcc 14.2.1:
* master
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.43067e+09,
"iterations": 8e+06,
"reciprocal-throughput": 178.572,
"latency": 179.096,
"max-throughput": 5.59997e+06,
"min-throughput": 5.58359e+06
}
aarch64-linux-gnu-master$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.68539e+09,
"iterations": 4e+06,
"reciprocal-throughput": 421.307,
"latency": 421.388,
"max-throughput": 2.37357e+06,
"min-throughput": 2.37311e+06
}
}
* patched
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv4
"inet_ntop_ipv4": {
"workload-ipv4-random": {
"duration": 1.06133e+09,
"iterations": 5.6e+07,
"reciprocal-throughput": 18.8482,
"latency": 19.0565,
"max-throughput": 5.30555e+07,
"min-throughput": 5.24755e+07
}
}
aarch64-linux-gnu$ ./benchtests/bench-inet_ntop_ipv6
"inet_ntop_ipv6": {
"workload-ipv6-random": {
"duration": 1.01246e+09,
"iterations": 2.4e+07,
"reciprocal-throughput": 42.5576,
"latency": 41.8139,
"max-throughput": 2.34976e+07,
"min-throughput": 2.39155e+07
}
}
Checked on aarch64-linux-gnu and x86_64-linux-gnu.
Reviewed-by: DJ Delorie <dj@redhat.com>
2025-06-04 20:42:43 +00:00
|
|
|
libc_hidden_def (__inet_ntop)
|
|
|
|
weak_alias (__inet_ntop, inet_ntop)
|