Powere management - make it conditional, enable on UEFI targets, else disabled

config/boards/README.md

@@ -63,6 +63,11 @@ If you are unsure about the documentation then invoke `$ grep -r -A5 -B5 "BUILD_
     - Values:
         - yes: Include (default)
         - no: Do NO include
+- **POWER_MANAGEMENT_FEATURES** (boolean): Controls whether system sleep functionality (suspend, hibernate, hybrid sleep) is allowed on the built image.
+    - Values:
+         - yes: Enable power-management sleep features (allow systemd sleep modes)
+         - no: Disable all sleep modes (default), as suspend/hibernate are unstable
+      on most single-board computers
 - **HAS_VIDEO_OUTPUT** ( boolean ): defines whether the system has video output such as eye candy, bootsplash, etc..
 	- Values:
 		- yes: Enable video-related configuration

config/sources/families/include/uefi_common.inc

@@ -10,6 +10,7 @@ declare -g SERIALCON="${SERIALCON:-tty1}"            # Consistent serial console
 declare -g UEFI_GRUB_TIMEOUT=${UEFI_GRUB_TIMEOUT:-3} # Default 3-seconds timeout for GRUB menu.
 declare -g BOARD_FIRMWARE_INSTALL="-full"            # Install full firmware for UEFI boards
 declare -g DISTRO_GENERIC_KERNEL=no
+declare -g POWER_MANAGEMENT_FEATURES=yes             # Suspend and resume might work well in UEFI, elsewhere is disabled by default
 
 case "${BRANCH}" in
 

lib/functions/rootfs/distro-specific.sh

@@ -35,16 +35,25 @@ function install_distribution_specific() {
 		truncate --size=0 "${SDCARD}"/etc/apt/apt.conf.d/20apt-esm-hook.conf
 	fi
 
-	# Add power management override
+	# Add power-management override.
-	# suspend / resume is very fragile on most of those board - lets disable it system wide
+	# Suspend / hibernate / hybrid-sleep are known to be unreliable or completely
-	mkdir -p "${SDCARD}/etc/systemd/sleep.conf.d"
+	# non-functional on the majority of single board computers due to incomplete
-	cat <<- EOF > "${SDCARD}/etc/systemd/sleep.conf.d/00-disable.conf"
+	# vendor kernels, broken device drivers, or lack of proper firmware support.
-	[Sleep]
+	# To avoid random lockups, data loss, or boards failing to wake up, we disable
-	AllowSuspend=no
+	# all systemd sleep modes by default.
-	AllowHibernation=no
+	# Users who understand the risks and have hardware that supports stable sleep
-	AllowHybridSleep=no
+	# states can re-enable them by setting:
-	AllowSuspendThenHibernate=no
+	#     POWER_MANAGEMENT_FEATURES=yes
-	EOF
+	if [[ "${POWER_MANAGEMENT_FEATURES:-"no"}" != "yes" ]]; then
+		mkdir -p "${SDCARD}/etc/systemd/sleep.conf.d"
+		cat <<- EOF > "${SDCARD}/etc/systemd/sleep.conf.d/00-disable.conf"
+		[Sleep]
+		AllowSuspend=no
+		AllowHibernation=no
+		AllowHybridSleep=no
+		AllowSuspendThenHibernate=no
+		EOF
+	fi
 
 	# install our base-files package (this replaces the original from Debian/Ubuntu)
 	if [[ "${KEEP_ORIGINAL_OS_RELEASE:-"no"}" != "yes" ]]; then