Xiaolong Huang fffc2f3c34 net: qrtr: fix another OOB Read in qrtr_endpoint_post ... BugLink: https://bugs.launchpad.net/bugs/1944756 commit 7e78c597c3 upstream. This check was incomplete, did not consider size is 0: if (len != ALIGN(size, 4) + hdrlen) goto err; if size from qrtr_hdr is 0, the result of ALIGN(size, 4) will be 0, In case of len == hdrlen and size == 0 in header this check won't fail and if (cb->type == QRTR_TYPE_NEW_SERVER) { /* Remote node endpoint can bridge other distant nodes */ const struct qrtr_ctrl_pkt *pkt = data + hdrlen; qrtr_node_assign(node, le32_to_cpu(pkt->server.node)); } will also read out of bound from data, which is hdrlen allocated block. Fixes: 194ccc8829 ("net: qrtr: Support decoding incoming v2 packets") Fixes: ad9d24c942 ("net: qrtr: fix OOB Read in qrtr_endpoint_post") Signed-off-by: Xiaolong Huang <butterflyhuangxx@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Kamal Mostafa <kamal@canonical.com> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>		2021-10-01 11:31:03 +02:00
..
Kconfig	…
Makefile	…
qrtr.c	net: qrtr: fix another OOB Read in qrtr_endpoint_post	2021-10-01 11:31:03 +02:00
qrtr.h	…
smd.c	…
tun.c	net: qrtr: Fix memory leak in qrtr_tun_open	2021-04-14 18:31:43 +02:00