Gao Xiang 326611ff40 lib/lz4: explicitly support in-place decompression ... BugLink: https://bugs.launchpad.net/bugs/1932957 commit 89b158635a upstream. LZ4 final literal copy could be overlapped when doing in-place decompression, so it's unsafe to just use memcpy() on an optimized memcpy approach but memmove() instead. Upstream LZ4 has updated this years ago [1] (and the impact is non-sensible [2] plus only a few bytes remain), this commit just synchronizes LZ4 upstream code to the kernel side as well. It can be observed as EROFS in-place decompression failure on specific files when X86_FEATURE_ERMS is unsupported, memcpy() optimization of commit 59daa706fb ("x86, mem: Optimize memcpy by avoiding memory false dependece") will be enabled then. Currently most modern x86-CPUs support ERMS, these CPUs just use "rep movsb" approach so no problem at all. However, it can still be verified with forcely disabling ERMS feature... arch/x86/lib/memcpy_64.S: ALTERNATIVE_2 "jmp memcpy_orig", "", X86_FEATURE_REP_GOOD, \ - "jmp memcpy_erms", X86_FEATURE_ERMS + "jmp memcpy_orig", X86_FEATURE_ERMS We didn't observe any strange on arm64/arm/x86 platform before since most memcpy() would behave in an increasing address order ("copy upwards" [3]) and it's the correct order of in-place decompression but it really needs an update to memmove() for sure considering it's an undefined behavior according to the standard and some unique optimization already exists in the kernel. [1] 33cb8518ac [2] https://github.com/lz4/lz4/pull/717#issuecomment-497818921 [3] https://sourceware.org/bugzilla/show_bug.cgi?id=12518 Link: https://lkml.kernel.org/r/20201122030749.2698994-1-hsiangkao@redhat.com Signed-off-by: Gao Xiang <hsiangkao@redhat.com> Reviewed-by: Nick Terrell <terrelln@fb.com> Cc: Yann Collet <yann.collet.73@gmail.com> Cc: Miao Xie <miaoxie@huawei.com> Cc: Chao Yu <yuchao0@huawei.com> Cc: Li Guifu <bluce.liguifu@huawei.com> Cc: Guo Xuenan <guoxuenan@huawei.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Kamal Mostafa <kamal@canonical.com> Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>		2021-07-15 19:27:11 +02:00
..
842	…
crypto	crypto: sha256 - Remove sha256/224_init code duplication	2019-09-05 14:54:54 +10:00
dim	lib/dim: Fix -Wunused-const-variable warnings	2019-07-25 11:34:39 -07:00
fonts	Fonts: Replace discarded const qualifier	2020-12-10 12:05:48 +01:00
livepatch	…
lz4	lib/lz4: explicitly support in-place decompression	2021-07-15 19:27:11 +02:00
lzo	lib/lzo: fix ambiguous encoding bug in lzo-rle	2020-08-08 01:53:12 -04:00
math	…
mpi	lib/mpi: Fix 64-bit MIPS build with Clang	2020-08-08 01:53:12 -04:00
raid6	lib/raid6: Let $(UNROLL) rules work with macOS userland	2021-02-19 16:44:48 +01:00
reed_solomon	…
vdso	lib/vdso: Make clock_getres() POSIX compliant again	2019-10-23 14:48:23 +02:00
xz	lib/xz: fix XZ_DYNALLOC to avoid useless memory reallocations	2019-11-15 18:34:00 -08:00
zlib_deflate	lib/zlib: add zlib_deflate_dfltcc_enabled() function	2020-03-07 08:42:39 -06:00
zlib_dfltcc	lib/zlib: add zlib_deflate_dfltcc_enabled() function	2020-03-07 08:42:39 -06:00
zlib_inflate	lib/zlib: remove outdated and incorrect pre-increment optimization	2020-08-08 01:53:12 -04:00
zstd	lib/zstd/mem.h: replace __inline by inline	2019-09-15 19:42:16 +02:00
.gitignore	…
Kconfig	lib/zlib: add s390 hardware support for kernel zlib_deflate	2020-03-07 08:42:00 -06:00
Kconfig.debug	kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()	2020-11-09 14:47:16 +01:00
Kconfig.kasan	kasan: add memory corruption identification for software tag-based mode	2019-09-24 15:54:07 -07:00
Kconfig.kgdb	…
Kconfig.ubsan	…
Makefile	avoid __memcat_p link failure	2021-05-19 10:53:23 +02:00
argv_split.c	…
ashldi3.c	…
ashrdi3.c	…
asn1_decoder.c	…
assoc_array.c	…
atomic64.c	…
atomic64_test.c	…
audit.c	…
bcd.c	…
bch.c	…
bitmap.c	cpumask: Implement cpumask_or_equal()	2019-07-25 15:47:37 +02:00
bitrev.c	…
bsearch.c	…
btree.c	…
bucket_locks.c	…
bug.c	bug: Remove redundant condition check in report_bug	2021-05-26 15:39:19 +02:00
build_OID_registry	…
bust_spinlocks.c	…
chacha.c	…
check_signature.c	…
checksum.c	…
clz_ctz.c	…
clz_tab.c	…
cmdline.c	…
cmpdi2.c	…
compat_audit.c	…
cpu_rmap.c	…
cpumask.c	…
crc-ccitt.c	…
crc-itu-t.c	…
crc-t10dif.c	crc-t10dif: Fix potential crypto notify dead-lock	2020-09-04 16:28:56 -03:00
crc4.c	…
crc7.c	…
crc8.c	…
crc16.c	…
crc32.c	lib/crc32.c: fix trivial typo in preprocessor condition	2020-11-09 14:49:00 +01:00
crc32defs.h	…
crc32test.c	lib/crc32test: remove extra local_irq_disable/enable	2020-12-10 12:05:50 +01:00
crc64.c	…
ctype.c	…
debug_info.c	…
debug_locks.c	…
debugobjects.c	debugobjects: Fix various data races	2020-02-24 16:20:00 +01:00
dec_and_lock.c	…
decompress.c	…
decompress_bunzip2.c	…
decompress_inflate.c	lib/zlib: add s390 hardware support for kernel zlib_inflate	2020-03-07 08:42:30 -06:00
decompress_unlz4.c	UBUNTU: SAUCE: lib/decompress_unlz4.c: correctly handle zero-padding around initrds.	2021-01-18 17:26:31 +01:00
decompress_unlzma.c	…
decompress_unlzo.c	…
decompress_unxz.c	…
devres.c	devres: keep both device name and resource name in pretty name	2020-09-04 16:30:00 -03:00
digsig.c	…
dump_stack.c	dump_stack: avoid the livelock of the dump_lock	2019-11-06 08:47:50 -08:00
dynamic_debug.c	dyndbg: fix a BUG_ON in ddebug_describe_flags	2020-09-04 16:29:03 -03:00
dynamic_queue_limits.c	…
earlycpio.c	…
error-inject.c	…
errseq.c	…
extable.c	lib/extable.c: add missing prototypes	2019-09-25 17:51:39 -07:00
fault-inject.c	…
fdt.c	…
fdt_empty_tree.c	…
fdt_ro.c	…
fdt_rw.c	…
fdt_strerror.c	…
fdt_sw.c	…
fdt_wip.c	…
find_bit.c	uapi: rename ext2_swab() to swab() and share globally in swab.h	2020-05-05 12:32:22 +02:00
find_bit_benchmark.c	…
flex_proportions.c	…
gen_crc32table.c	…
gen_crc64table.c	…
genalloc.c	lib/genalloc: fix the overflow when size is too big	2021-02-19 16:43:37 +01:00
generic-radix-tree.c	lib/generic-radix-tree.c: add kmemleak annotations	2019-10-14 15:04:00 -07:00
glob.c	…
globtest.c	…
hexdump.c	lib/hexdump: make print_hex_dump_bytes() a nop on !DEBUG builds	2019-09-25 17:51:39 -07:00
hweight.c	…
idr.c	ida: Free allocated bitmap in error path	2020-11-09 14:48:55 +01:00
inflate.c	…
interval_tree.c	…
interval_tree_test.c	…
iomap.c	…
iomap_copy.c	…
iommu-helper.c	…
ioremap.c	mm/ioremap: probe platform for p4d huge map support	2019-07-16 19:23:22 -07:00
iov_iter.c	udp: fix skb_copy_and_csum_datagram with odd segment sizes	2021-03-24 11:14:33 +01:00
irq_poll.c	…
irq_regs.c	…
is_single_threaded.c	…
kasprintf.c	…
kfifo.c	Partially revert "kfifo: fix kfifo_alloc() and kfifo_init()"	2019-08-30 18:47:15 -07:00
klist.c	…
kobject.c	kobject: Restore old behaviour of kobject_del(NULL)	2020-11-09 14:46:47 +01:00
kobject_uevent.c	kobject_uevent: remove warning in init_uevent_argv()	2021-06-18 15:02:22 +02:00
kstrtox.c	…
kstrtox.h	…
libcrc32c.c	…
list_debug.c	…
list_sort.c	…
llist.c	…
locking-selftest-hardirq.h	…
locking-selftest-mutex.h	…
locking-selftest-rlock-hardirq.h	…
locking-selftest-rlock-softirq.h	…
locking-selftest-rlock.h	…
locking-selftest-rsem.h	…
locking-selftest-rtmutex.h	…
locking-selftest-softirq.h	…
locking-selftest-spin-hardirq.h	…
locking-selftest-spin-softirq.h	…
locking-selftest-spin.h	…
locking-selftest-wlock-hardirq.h	…
locking-selftest-wlock-softirq.h	…
locking-selftest-wlock.h	…
locking-selftest-wsem.h	…
locking-selftest.c	…
lockref.c	…
logic_pio.c	PCI: Fix pci_register_io_range() memory leak	2021-04-14 18:31:56 +02:00
lru_cache.c	…
lshrdi3.c	…
memcat_p.c	…
memory-notifier-error-inject.c	…
memweight.c	…
muldi3.c	…
net_utils.c	…
netdev-notifier-error-inject.c	…
nlattr.c	net: fix nla_strcmp to handle more then one trailing null character	2021-06-18 15:02:15 +02:00
nmi_backtrace.c	…
nodemask.c	…
notifier-error-inject.c	…
notifier-error-inject.h	…
objagg.c	…
of-reconfig-notifier-error-inject.c	…
oid_registry.c	…
once.c	…
packing.c	…
parman.c	…
parser.c	…
pci_iomap.c	…
percpu-refcount.c	Merge branch 'for-5.3' of git://git.kernel.org/pub/scm/linux/kernel/git/dennis/percpu	2019-07-14 16:17:18 -07:00
percpu_counter.c	…
percpu_test.c	…
plist.c	…
pm-notifier-error-inject.c	…
radix-tree.c	idr: Fix idr_alloc_u32 on 32-bit systems	2019-11-03 06:36:50 -05:00
random32.c	random32: make prandom_u32() output unpredictable	2020-12-10 12:06:15 +01:00
ratelimit.c	…
rbtree.c	lib/rbtree: avoid generating code twice for the cached versions	2019-07-16 19:23:22 -07:00
rbtree_test.c	augmented rbtree: add new RB_DECLARE_CALLBACKS_MAX macro	2019-09-25 17:51:39 -07:00
refcount.c	…
rhashtable.c	…
sbitmap.c	sbitmap: only queue kyber's wait callback if not already active	2020-01-30 16:23:16 +01:00
scatterlist.c	sgl_alloc_order: fix memory leak	2020-12-10 12:03:00 +01:00
seq_buf.c	…
sg_pool.c	…
sg_split.c	lib: scatterlist: Fix to support no mapped sg	2019-08-08 07:45:01 -06:00
sha1.c	…
show_mem.c	mm: remove quicklist page table caches	2019-09-24 15:54:09 -07:00
siphash.c	…
smp_processor_id.c	…
sort.c	media: lib/sort.c: implement sort() variant taking context argument	2019-08-19 13:14:53 -03:00
stackdepot.c	lib: stackdepot: turn depot_lock spinlock to raw_spinlock	2021-06-18 15:02:25 +02:00
stmp_device.c	…
string.c	lib/string.c: implement stpcpy	2020-11-09 14:48:03 +01:00
string_helpers.c	lib/string_helpers: fix some kerneldoc warnings	2019-07-16 19:23:22 -07:00
strncpy_from_user.c	lib: Reduce user_access_begin() boundaries in strncpy_from_user() and strnlen_user()	2020-01-30 16:28:22 +01:00
strnlen_user.c	lib: Reduce user_access_begin() boundaries in strncpy_from_user() and strnlen_user()	2020-01-30 16:28:22 +01:00
syscall.c	lib/syscall: fix syscall registers retrieval on 32-bit platforms	2021-01-20 14:25:04 +01:00
test-kstrtox.c	…
test-string_helpers.c	…
test_bitfield.c	…
test_bitmap.c	…
test_blackhole_dev.c	…
test_bpf.c	UBUNTU: SAUCE: test_bpf: remove expected fail for Ctx heavy transformations test on s390	2019-11-25 14:56:41 +01:00
test_debug_virtual.c	…
test_firmware.c	test_firmware: add support for request_firmware_into_buf	2019-09-04 13:31:28 +02:00
test_hash.c	…
test_hexdump.c	…
test_ida.c	…
test_kasan.c	kasan: stop tests being eliminated as dead code with FORTIFY_SOURCE	2020-08-08 01:53:12 -04:00
test_kmod.c	test_kmod: avoid potential double free in trigger_config_run_type()	2020-09-04 16:30:10 -03:00
test_list_sort.c	…
test_memcat_p.c	…
test_meminit.c	lib/test_meminit: add a kmem_cache_alloc_bulk() test	2019-10-14 15:04:01 -07:00
test_module.c	…
test_objagg.c	test_objagg: Fix potential memory leak in error handling	2020-08-08 01:53:12 -04:00
test_overflow.c	lib/test_overflow.c: avoid tainting the kernel and fix wrap size	2019-07-16 19:23:22 -07:00
test_parman.c	…
test_printf.c	vsprintf: don't obfuscate NULL and error pointers	2020-06-22 17:22:42 -03:00
test_rhashtable.c	…
test_siphash.c	…
test_sort.c	…
test_stackinit.c	…
test_static_key_base.c	…
test_static_keys.c	…
test_string.c	lib/test_string.c: add some testcases for strchr and strnchr	2019-07-16 19:23:22 -07:00
test_strscpy.c	…
test_sysctl.c	…
test_ubsan.c	…
test_user_copy.c	usercopy: Avoid soft lockups in test_check_nonzero_user()	2019-10-16 14:56:21 +02:00
test_uuid.c	…
test_vmalloc.c	…
test_xarray.c	XArray: add xas_split	2021-07-15 19:27:10 +02:00
textsearch.c	lib: textsearch: fix escapes in example code	2019-10-03 12:12:23 -04:00
timerqueue.c	lib/timerqueue: Rely on rbtree semantics for next timer	2019-07-24 17:38:01 +02:00
ts_bm.c	…
ts_fsm.c	…
ts_kmp.c	…
ubsan.c	lib/ubsan: don't serialize UBSAN report	2020-01-30 16:22:24 +01:00
ubsan.h	…
ucmpdi2.c	…
ucs2_string.c	…
usercopy.c	lib: introduce copy_struct_from_user() helper	2019-10-01 15:45:03 +02:00
uuid.c	…
vsprintf.c	vsprintf: don't obfuscate NULL and error pointers	2020-06-22 17:22:42 -03:00
win_minmax.c	…
xarray.c	XArray: add xas_split	2021-07-15 19:27:10 +02:00
xxhash.c	…