Dan Carpenter 70e6d2715f kfifo: fix ternary sign extension bugs ... BugLink: https://bugs.launchpad.net/bugs/1929615 [ Upstream commit 926ee00ea2 ] The intent with this code was to return negative error codes but instead it returns positives. The problem is how type promotion works with ternary operations. These functions return long, "ret" is an int and "copied" is a u32. The negative error code is first cast to u32 so it becomes a high positive and then cast to long where it's still a positive. We could fix this by declaring "ret" as a ssize_t but let's just get rid of the ternaries instead. Link: https://lkml.kernel.org/r/YIE+/cK1tBzSuQPU@mwanda Fixes: 5bf2b19320 ("kfifo: add example files to the kernel sample directory") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: Stefani Seibold <stefani@seibold.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Kamal Mostafa <kamal@canonical.com> Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>		2021-05-26 15:39:25 +02:00
..
Makefile	…
bytestream-example.c	kfifo: fix ternary sign extension bugs	2021-05-26 15:39:25 +02:00
dma-example.c	…
inttype-example.c	kfifo: fix ternary sign extension bugs	2021-05-26 15:39:25 +02:00
record-example.c	kfifo: fix ternary sign extension bugs	2021-05-26 15:39:25 +02:00