qiurui
/
Ubuntu-focal-kernel
mirror of https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/focal
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
Ubuntu-focal-kernel/kernel/dma
History
Lance Richardson d1c8a2a4f8 dma: fix call order in dmam_free_coherent 
BugLink: https://bugs.launchpad.net/bugs/2078388

[ Upstream commit 28e8b7406d3a1f5329a03aa25a43aa28e087cb20 ]

dmam_free_coherent() frees a DMA allocation, which makes the
freed vaddr available for reuse, then calls devres_destroy()
to remove and free the data structure used to track the DMA
allocation. Between the two calls, it is possible for a
concurrent task to make an allocation with the same vaddr
and add it to the devres list.

If this happens, there will be two entries in the devres list
with the same vaddr and devres_destroy() can free the wrong
entry, triggering the WARN_ON() in dmam_match.

Fix by destroying the devres entry before freeing the DMA
allocation.

Tested:
  kokonut //net/encryption
    http://sponge2/b9145fe6-0f72-4325-ac2f-a84d81075b03

Fixes: 9ac7849e35 ("devres: device resource management")
Signed-off-by: Lance Richardson <rlance@google.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Koichiro Den <koichiro.den@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
 		2024-09-27 10:50:16 +02:00
..
Kconfig
…
Makefile
…
coherent.c dma-mapping: clear dev->dma_mem to NULL after freeing it 2024-02-29 15:23:36 +01:00
contiguous.c
…
debug.c treewide: Remove uninitialized_var() usage 2023-08-09 12:25:41 +02:00
direct.c dma-mapping: drop the dev argument to arch_sync_dma_for_* 2023-07-10 17:22:05 +02:00
dummy.c
…
mapping.c dma: fix call order in dmam_free_coherent 2024-09-27 10:50:16 +02:00
remap.c
…
swiotlb.c Reinstate some of "swiotlb: rework "fix info leak with DMA_FROM_DEVICE"" 2022-08-26 11:06:53 +02:00
virt.c
…