Centos-kernel-stream-9

mirror of https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9.git synced 2026-09-09 00:08:12 +08:00

Files

T

Mark Langsdorf bad15eb175 driver core: Constify API device_find_child() and adapt for various usages

JIRA: https://issues.redhat.com/browse/RHEL-81536
Conflicts:
	drivers/firewire/core-device.c
	drivers/gpio/gpio-sim.c
	drivers/gpu/drm/mediatek/mtk_drm_drv.c
	drivers/hwmon/hwmon.c
	drivers/pwm/core.c - device_find_child() wasn't used
in any of these files in centos-stream-9 and the changes had
to be dropped
	drivers/pwm/sysfs.c - made the void argument of
pwm_unexport_match() into const void to satisfy the new
function declaration
	drivers/net/ethernet/qualcomm/emac/emac-sgmii.c -
made the void argument of emac_sgmii_acpi_match() into
const void to satisfy the new function declaration,
and sgmii_ops **ops was declared const and then data had to
be explicitly cast to satisfy the compiler
	drivers/nvdimm/claim.c - made the void argument of
namespace_match() into const void to satisfy the new
function declaration, then made char *name into const
so that data could be assigned to it.

commit f1e8bf56320a7fb32095b6c51b707459361b403b
Author: Zijun Hu <quic_zijuhu@quicinc.com>
Date: Fri, 03 Jan 2025 11:19:35 +0000

Constify the following API:
struct device *device_find_child(struct device *dev, void *data,
		int (*match)(struct device *dev, void *data));
To :
struct device *device_find_child(struct device *dev, const void *data,
                                 device_match_t match);
typedef int (*device_match_t)(struct device *dev, const void *data);
with the following reasons:

- Protect caller's match data @*data which is for comparison and lookup
  and the API does not actually need to modify @*data.

- Make the API's parameters (@match)() and @data have the same type as
  all of other device finding APIs (bus|class|driver)_find_device().

- All kinds of existing device match functions can be directly taken
  as the API's argument, they were exported by driver core.

Constify the API and adapt for various existing usages.

BTW, various subsystem changes are squashed into this commit to meet
'git bisect' requirement, and this commit has the minimal and simplest
changes to complement squashing shortcoming, and that may bring extra
code improvement.

Reviewed-by: Alison Schofield <alison.schofield@intel.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Acked-by: Uwe Kleine-König <ukleinek@kernel.org> # for drivers/pwm
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Link: https://lore.kernel.org/r/20241224-const_dfc_done-v5-4-6623037414d4@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Mark Langsdorf <mlangsdo@redhat.com>