SC2001: See if you can use ${variable//search/replace} instead.
SC2045: Iterating over ls output is fragile. Use globs.
SC2046: Quote this (command) to prevent word splitting.
SC2086: Double quote to prevent globbing and word splitting.
SC2162: read without -r will mangle backslashes.
SC2231: Quote expansions in this for loop glob to prevent wordsplitting, e.g. "$dir"/*.txt .
Also, change to #!/bin/bash so bash-isms won't be flagged, e.g.
SC2039: In POSIX sh, [[ ]] is undefined.
Signed-off-by: Ben Crocker <bcrocker@redhat.com>
The distribution specific Makefile target names begin with rh-. Switch
them to be use the distro agnostic dist-.
rh-dist-git-test and rh-dist-git are renamed to dist-git-test and
dist-git.
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
v2: Update to include jcline's newly added docs
v3: Clean up rh-help and rh-full-help output. I made all text conform
to 80 chars.
ARK plans to merge with Fedora and has therefore begun building the
Fedora configuration files.
The current ARK process generates defaults for new configuration options
in the redhat/configs/pending/ directory, and then generates commits
moving these configs to the redhat/configs/common/ directory which are
sent out for review. This is necessary because rebases are largely
automated, there needs to be a place to set defaults for new
configuration options that indicate they need human review.
This is problematic for Fedora because it enables a super-set of
ARK options, which in turn lead to options being exposed during rebases
that are not exposed for ARK. Thus, this adds a
redhat/configs/pending-fedora/ configuration directory where new options
for Fedora rebases are stored. This also renames the current pending/
directory to be pending-common/ in order to make the final destination
of configuration options clearer. Fedora still inherits configuration
options from common/ and pending-common/ so only settings specific to
Fedora are placed here.
There is no pending-ark/ directory at the moment because if, during
review, ARK needs a setting that differs from Fedora, the setting is
changed and manually moved into the ark/ directory.
Cc: Don Zickus <dzickus@redhat.com>
Signed-off-by: Jeremy Cline <jcline@redhat.com>
Ben Crocker
Prarit Bhargava
Jeremy Cline
Laura Abbott