Commit Graph

9 Commits

Author SHA1 Message Date
Desnes Nunes 8e174502e4 usb: cdns3-ti: Add workaround for Errata i2409
JIRA: https://issues.redhat.com/browse/RHEL-59051

commit b50a2da03bd95784541b3f9058e452cc38f9ba05
Author: Roger Quadros <rogerq@kernel.org>
Date: Thu, 16 May 2024 10:15:37 +0530

  TI USB2 PHY is known to have a lockup issue on very short
  suspend intervals. Enable the Suspend Residency quirk flag to
  workaround this as described in Errata i2409 [1].

  [1] - https://www.ti.com/lit/er/sprz457h/sprz457h.pdf

  Signed-off-by: Roger Quadros <rogerq@kernel.org>
  Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
  Acked-by: Peter Chen <peter.chen@kernel.org>
  Link: https://lore.kernel.org/r/20240516044537.16801-3-r-gunasekaran@ti.com
  Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: Desnes Nunes <desnesn@redhat.com>
2024-11-07 23:01:28 -03:00
Martin McConnell 6b884c2a40 usb: cdns3-ti: Convert to platform remove callback returning void
JIRA: https://issues.redhat.com/browse/RHEL-54566

commit defbfca6945ec5f3362e15ee4ec15180117240c3
Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date:   Thu May 18 01:01:06 2023 +0200

    usb: cdns3-ti: Convert to platform remove callback returning void

    The .remove() callback for a platform driver returns an int which makes
    many driver authors wrongly assume it's possible to do error handling by
    returning an error code. However the value returned is ignored (apart from
    emitting a warning) and this typically results in resource leaks. To improve
    here there is a quest to make the remove callback return void. In the first
    step of this quest all drivers are converted to .remove_new() which already
    returns void. Eventually after all drivers are converted, .remove_new() is
    renamed to .remove().

    Trivially convert this driver from always returning zero in the remove
    callback to the void returning variant.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Link: https://lore.kernel.org/r/20230517230239.187727-5-u.kleine-koenig@pengutronix.de
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: Martin McConnell <mmcconne@redhat.com>
2024-08-30 12:20:42 +01:00
Desnes Nunes deb21c1cbc usb: Explicitly include correct DT includes
JIRA: https://issues.redhat.com/browse/RHEL-28809
Conflicts:
* Avoding unsupported changes at renesas_usbf.c, fhci-hcd,
  mtu3_host and jz4740

commit 484468fb0f7dbac88f050009a5145ed1ee744a7e
Author: Rob Herring <robh@kernel.org>
Date: Tue, 18 Jul 2023 08:30:23 -0600

  The DT of_device.h and of_platform.h date back to the separate
  of_platform_bus_type before it as merged into the regular platform bus.
  As part of that merge prepping Arm DT support 13 years ago, they
  "temporarily" include each other. They also include platform_device.h
  and of.h. As a result, there's a pretty much random mix of those include
  files used throughout the tree. In order to detangle these headers and
  replace the implicit includes with struct declarations, users need to
  explicitly include the correct includes.

  Acked-by: Herve Codina <herve.codina@bootlin.com>
  Signed-off-by: Rob Herring <robh@kernel.org>
  Link: https://lore.kernel.org/r/20230718143027.1064731-1-robh@kernel.org
  Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: Desnes Nunes <desnesn@redhat.com>
2024-03-18 15:42:26 -03:00
Lee Jones a945fd0a58 usb: cdns3: cdns3-ti: File headers are not good candidates for kernel-doc
Fixes the following W=1 kernel build warning(s):

 drivers/usb/cdns3/cdns3-ti.c:20: warning: expecting prototype for cdns3(). Prototype was for USBSS_PID() instead

Cc: Peter Chen <peter.chen@kernel.org>
Cc: Pawel Laszczak <pawell@cadence.com>
Cc: Roger Quadros <rogerq@kernel.org>
Cc: Aswath Govindraju <a-govindraju@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Acked-by: Peter Chen <peter.chen@kernel.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20210526130037.856068-9-lee.jones@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-05-27 09:43:44 +02:00
Aswath Govindraju 4f30b9d231
usb: cdns3: Add support for TI's AM64 SoC
Add support for USB controller present on the AM64x SoC.

Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
Signed-off-by: Peter Chen <peter.chen@kernel.org>
2021-01-23 09:48:56 +08:00
Alexander A. Klimov ffeb1e9e89 USB: Replace HTTP links with HTTPS ones
Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.

Deterministic algorithm:
For each file:
  If not .svg:
    For each line:
      If doesn't contain `\bxmlns\b`:
        For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
	  If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
            If both the HTTP and HTTPS versions
            return 200 OK and serve the same content:
              Replace HTTP with HTTPS.

Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
Link: https://lore.kernel.org/r/20200719160910.60018-1-grandmaster@al2klimov.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-07-21 13:41:57 +02:00
Dinghao Liu e5b9134960 usb: cdns3: Fix runtime PM imbalance on error
pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.

Reviewed-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
2020-05-25 11:09:43 +03:00
Colin Ian King 70d8b9e5e6 usb: cdns3: make signed 1 bit bitfields unsigned
The signed 1 bit bitfields should be unsigned, so make them unsigned.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Peter Chen <peter.chen@nxp.com>
Link: https://lore.kernel.org/r/20200325125041.94769-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-03-26 15:05:44 +01:00
Roger Quadros 387c359b84 usb: cdns3: Add TI specific wrapper driver
The J721e platform comes with 2 Cadence USB3 controller
instances. This driver supports the TI specific wrapper
on this platform.

Signed-off-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
Reviewed-by: Pawel Laszczak <pawell@cadence.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
2019-10-29 12:55:09 +02:00