Commit Graph

3 Commits

Author SHA1 Message Date
Martin McConnell 0671cb69f0 usb: cdns3: starfive: don't misuse /** comment
JIRA: https://issues.redhat.com/browse/RHEL-54566

commit 5cc623a4edaf383eea39546104084b089f3035ca
Author: Randy Dunlap <rdunlap@infradead.org>
Date:   Wed Dec 6 10:13:17 2023 -0800

    usb: cdns3: starfive: don't misuse /** comment

    Use a common C comment "/*" instead of "/**" to prevent a warning
    from scripts/kernel-doc.

    cdns3-starfive.c:23: warning: expecting prototype for cdns3(). Prototype was for USB_STRAP_HOST() instead

    Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    Cc: Minda Chen <minda.chen@starfivetech.com>
    Cc: Peter Chen <peter.chen@kernel.org>
    Cc: Pawel Laszczak <pawell@cadence.com>
    Cc: Roger Quadros <rogerq@kernel.org>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc:  <linux-usb@vger.kernel.org>
    Acked-by: Peter Chen <peter.chen@kernel.org>
    Link: https://lore.kernel.org/r/20231206181317.27515-1-rdunlap@infradead.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: Martin McConnell <mmcconne@redhat.com>
2024-08-30 12:21:46 +01:00
Martin McConnell 8cdffeb4a3 usb: cdns3: starfive: Convert to platform remove callback returning void
JIRA: https://issues.redhat.com/browse/RHEL-54566

commit 48cb8ff3e250301a5a48925281a7096969ab3a48
Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date:   Fri Jul 7 09:36:53 2023 +0200

    usb: cdns3: starfive: Convert to platform remove callback returning void

    The .remove() callback for a platform driver returns an int which makes
    many driver authors wrongly assume it's possible to do error handling by
    returning an error code. However the value returned is ignored (apart
    from emitting a warning) and this typically results in resource leaks.
    To improve here there is a quest to make the remove callback return
    void. In the first step of this quest all drivers are converted to
    .remove_new() which already returns void. Eventually after all drivers
    are converted, .remove_new() is renamed to .remove().

    Trivially convert this driver from always returning zero in the remove
    callback to the void returning variant.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Acked-by: Roger Quadros <rogerq@kernel.org>
    Link: https://lore.kernel.org/r/20230707073653.3396988-1-u.kleine-koenig@pengutronix.de
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: Martin McConnell <mmcconne@redhat.com>
2024-08-30 12:21:42 +01:00
Martin McConnell 7a5f2aa6b7 usb: cdns3: Add StarFive JH7110 USB driver
JIRA: https://issues.redhat.com/browse/RHEL-54566

Conflicts: MAINTAINERS: Integrate new StarFive JH71x0 usb driver entry

commit bfb46b424652a3396b92ca3c96c169ade9b45b8d
Author: Minda Chen <minda.chen@starfivetech.com>
Date:   Thu May 18 19:27:49 2023 +0800

    usb: cdns3: Add StarFive JH7110 USB driver

    Adds Specific Glue layer to support USB peripherals on
    StarFive JH7110 SoC.
    There is a Cadence USB3 core for JH7110 SoCs, the cdns
    core is the child of this USB wrapper module device.

    Signed-off-by: Minda Chen <minda.chen@starfivetech.com>
    Acked-by: Peter Chen <peter.chen@kernel.org>
    Reviewed-by: Roger Quadros <rogerq@kernel.org>
    Link: https://lore.kernel.org/r/20230518112750.57924-7-minda.chen@starfivetech.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: Martin McConnell <mmcconne@redhat.com>
2024-08-30 12:21:15 +01:00