Commit Graph

3 Commits

Author SHA1 Message Date
David Arcari 6a4b7926ac platform/x86/intel: add missing MODULE_DESCRIPTION() macros
JIRA: https://issues.redhat.com/browse/RHEL-65816

commit 41ab81ce8490b9cad88e87c49315fb8c46208be7
Author: Jeff Johnson <quic_jjohnson@quicinc.com>
Date:   Tue Jun 11 21:56:26 2024 -0700

    platform/x86/intel: add missing MODULE_DESCRIPTION() macros

    With ARCH=x86, make allmodconfig && make W=1 C=1 reports:
    WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/intel/pmc/intel_pmc_core_pltdrv.o
    WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/intel/intel-hid.o
    WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/intel/intel-vbtn.o
    WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/intel/intel-rst.o
    WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/intel/intel-smartconnect.o

    Add the missing invocations of the MODULE_DESCRIPTION() macro.

    Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
    Link: https://lore.kernel.org/r/20240611-md-drivers-platform-x86-intel-v1-1-5ed967425b04@quicinc.com
    Reviewed-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Signed-off-by: David Arcari <darcari@redhat.com>
2024-11-05 08:53:13 -05:00
Prarit Bhargava dae377d2c9 ACPI: make remove callback of ACPI driver void
JIRA: https://issues.redhat.com/browse/RHEL-25415

Conflicts: Some drivers need some minor int->void changes that
are needed due to drift between RHEL9 and upstream.

commit 6c0eb5ba3500f6da367351ff3c4452c029cb72fa
Author: Dawei Li <set_pte_at@outlook.com>
Date:   Mon Nov 14 00:26:09 2022 +0800

    ACPI: make remove callback of ACPI driver void

    For bus-based driver, device removal is implemented as:
    1 device_remove()->
    2   bus->remove()->
    3     driver->remove()

    Driver core needs no inform from callee(bus driver) about the
    result of remove callback. In that case, commit fc7a6209d571
    ("bus: Make remove callback return void") forces bus_type::remove
    be void-returned.

    Now we have the situation that both 1 & 2 of calling chain are
    void-returned, so it does not make much sense for 3(driver->remove)
    to return non-void to its caller.

    So the basic idea behind this change is making remove() callback of
    any bus-based driver to be void-returned.

    This change, for itself, is for device drivers based on acpi-bus.

    Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Acked-by: Lee Jones <lee@kernel.org>
    Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    Reviewed-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Dawei Li <set_pte_at@outlook.com>
    Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>  # for drivers/platform/surface/*
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Signed-off-by: Prarit Bhargava <prarit@redhat.com>
2024-03-20 09:42:49 -04:00
Prarit Bhargava 0bedea3e96 platform/x86: intel-rst: Move to intel sub-directory
JIRA: https://issues.redhat.com/browse/RHEL-25415

Conflicts: Minor drift issues.

commit e6596c22744e7c3058bc3ef843d1a6c20632e27f
Author: Kate Hsuan <hpa@redhat.com>
Date:   Fri Aug 20 14:04:47 2021 +0300

    platform/x86: intel-rst: Move to intel sub-directory

    Move Intel RST driver to intel sub-directory to improve readability
    and rename it from intel-rst.c to rst.c.

    Signed-off-by: Kate Hsuan <hpa@redhat.com>
    Reviewed-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Link: https://lore.kernel.org/r/20210820110458.73018-10-andriy.shevchenko@linux.intel.com
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Signed-off-by: Prarit Bhargava <prarit@redhat.com>
2024-03-20 09:42:48 -04:00