Commit Graph

3 Commits

Author SHA1 Message Date
Jeff Moyer 336182e09d io_uring: silence variable ‘prev’ set but not used warning
JIRA: https://issues.redhat.com/browse/RHEL-12076

commit fa780334a8c392d959ae05eb19f2410b3a1e6cb0
Author: Jens Axboe <axboe@kernel.dk>
Date:   Thu Mar 9 09:51:13 2023 -0700

    io_uring: silence variable ‘prev’ set but not used warning
    
    If io_uring.o is built with W=1, it triggers a warning:
    
    io_uring/io_uring.c: In function ‘__io_submit_flush_completions’:
    io_uring/io_uring.c:1502:40: warning: variable ‘prev’ set but not used [-Wunused-but-set-variable]
     1502 |         struct io_wq_work_node *node, *prev;
          |                                        ^~~~
    
    which is due to the wq_list_for_each() iterator always keeping a 'prev'
    variable. Most users need this to remove an entry from a list, for
    example, but __io_submit_flush_completions() never does that.
    
    Add a basic helper that doesn't track prev instead, and use that in
    that function.
    
    Reported-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
    Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>

Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
2023-11-02 15:31:12 -04:00
Jeff Moyer 1ca4e4595f io_uring: remove unused wq_list_merge
JIRA: https://issues.redhat.com/browse/RHEL-12076

commit 9a1563d1720680bdc1d702486b7b73f51c079b32
Author: Pavel Begunkov <asml.silence@gmail.com>
Date:   Wed Feb 22 14:32:43 2023 +0000

    io_uring: remove unused wq_list_merge
    
    There are no users of wq_list_merge, kill it.
    
    Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
    Link: https://lore.kernel.org/r/5f9ad0301949213230ad9000a8359d591aae615a.1677002255.git.asml.silence@gmail.com
    Signed-off-by: Jens Axboe <axboe@kernel.dk>

Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
2023-11-02 15:31:11 -04:00
Jeff Moyer 3bb83f0f6a io_uring: move list helpers to a separate file
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2068237

commit a6b21fbb4ce3c4976ba478a9f0f10d4163038478
Author: Pavel Begunkov <asml.silence@gmail.com>
Date:   Tue Jun 21 10:09:01 2022 +0100

    io_uring: move list helpers to a separate file
    
    It's annoying to have io-wq.h as a dependency every time we want some of
    struct io_wq_work_list helpers, move them into a separate file.
    
    Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
    Link: https://lore.kernel.org/r/c1d891ce12b30767d1d2a3b7db2ca3abc1ecc4a2.1655802465.git.asml.silence@gmail.com
    Signed-off-by: Jens Axboe <axboe@kernel.dk>

Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
2023-04-29 06:39:02 -04:00