qiurui
/
Centos-kernel-stream-9
mirror of https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net: phy: qca807x: Drop unnecessary and broken DT validation 

JIRA: https://issues.redhat.com/browse/RHEL-57766

commit 46e6acfe3501fa938af9c5bd730f0020235b08a2
Author: Rob Herring (Arm) <robh@kernel.org>
Date:   Wed Jul 31 14:17:03 2024 -0600

    net: phy: qca807x: Drop unnecessary and broken DT validation

    The check for "leds" and "gpio-controller" both being present is never
    true because "leds" is a node, not a property. This could be fixed
    with a check for child node, but there's really no need for the kernel
    to validate a DT. Just continue ignoring the LEDs if GPIOs are present.

    Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
    Link: https://patch.msgid.link/20240731201703.1842022-2-robh@kernel.org
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Signed-off-by: Izabela Bakollari <ibakolla@redhat.com>
This commit is contained in:
Izabela Bakollari 2024-11-26 13:03:05 +01:00
parent 4b4c84c5cd
commit ee6457bcca
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/net/phy/qcom/qca807x.c
View File

@ -735,16 +735,6 @@ static int qca807x_probe(struct phy_device *phydev)
"qcom,dac-disable-bias-current-tweak");
#if IS_ENABLED(CONFIG_GPIOLIB)
/* Make sure we don't have mixed leds node and gpio-controller
* to prevent registering leds and having gpio-controller usage
* conflicting with them.
*/
if (of_find_property(node, "leds", NULL) &&
of_find_property(node, "gpio-controller", NULL)) {
phydev_err(phydev, "Invalid property detected. LEDs and gpio-controller are mutually exclusive.");
return -EINVAL;
}
/* Do not register a GPIO controller unless flagged for it */
if (of_property_read_bool(node, "gpio-controller")) {
ret = qca807x_gpio(phydev);