qiurui
/
Centos-kernel-stream-9
mirror of https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

s390: ism: Pass string literal as format argument of dev_set_name() 

JIRA: https://issues.redhat.com/browse/RHEL-99989

commit 199561a48f026bf674424fd9019c0690a3570377
Author: Simon Horman <horms@kernel.org>
Date:   Thu Apr 17 11:28:23 2025 +0100

    s390: ism: Pass string literal as format argument of dev_set_name()

    GCC 14.2.0 reports that passing a non-string literal as the
    format argument of dev_set_name() is potentially insecure.

    drivers/s390/net/ism_drv.c: In function 'ism_probe':
    drivers/s390/net/ism_drv.c:615:2: warning: format not a string literal and no format arguments [-Wformat-security]
      615 |  dev_set_name(&ism->dev, dev_name(&pdev->dev));
          |  ^~~~~~~~~~~~

    It seems to me that as pdev is a PCIE device then the dev_name
    call above should always return the device's BDF, e.g. 00:12.0.
    That this should not contain format escape sequences. And thus
    the current usage is safe.

    But, it seems better to be safe than sorry. And, as a bonus, compiler
    output becomes less verbose by addressing this issue.

    Compile tested only.
    No functional change intended.

    Signed-off-by: Simon Horman <horms@kernel.org>
    Link: https://patch.msgid.link/20250417-ism-str-fmt-v1-1-9818b029874d@kernel.org
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Signed-off-by: Mahanta Jambigi <mjambigi@linux.ibm.com>
Signed-off-by: Mete Durlu <mdurlu@redhat.com>
This commit is contained in:
Mete Durlu 2025-11-07 15:48:07 +01:00
parent bd2c46beca
commit e428271d08
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/s390/net/ism_drv.c
View File

@ -615,7 +615,7 @@ static int ism_probe(struct pci_dev *pdev, const struct pci_device_id *id)
ism->dev.parent = &pdev->dev;
ism->dev.release = ism_dev_release;
device_initialize(&ism->dev);
dev_set_name(&ism->dev, dev_name(&pdev->dev));
dev_set_name(&ism->dev, "%s", dev_name(&pdev->dev));
ret = device_add(&ism->dev);
if (ret)
goto err_dev;