qiurui
/
Centos-kernel-stream-9
mirror of https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

xfs: don't deplete the reserve pool when trying to shrink the fs 

JIRA: https://issues.redhat.com/browse/RHEL-2002

commit 06f3ef6e1705612b88aa0b6991e2ac3b8ed3f8ec
Author: Darrick J. Wong <djwong@kernel.org>
Date:   Mon Jun 12 18:09:04 2023 -0700

    xfs: don't deplete the reserve pool when trying to shrink the fs

    Every now and then, xfs/168 fails with this logged in dmesg:

    Reserve blocks depleted! Consider increasing reserve pool size.
    EXPERIMENTAL online shrink feature in use. Use at your own risk!
    Per-AG reservation for AG 1 failed.  Filesystem may run out of space.
    Per-AG reservation for AG 1 failed.  Filesystem may run out of space.
    Error -28 reserving per-AG metadata reserve pool.
    Corruption of in-memory data (0x8) detected at xfs_ag_shrink_space+0x23c/0x3b0 [xfs] (fs/xfs/libxfs/xfs_ag.c:1007).  Shutting down filesystem.

    It's silly to deplete the reserved blocks pool just to shrink the
    filesystem, particularly since the fs goes down after that.

    Fixes: fb2fc17201 ("xfs: support shrinking unused space in the last AG")
    Signed-off-by: Darrick J. Wong <djwong@kernel.org>

Signed-off-by: Bill O'Donnell <bodonnel@redhat.com>
This commit is contained in:
Bill O'Donnell 2023-11-06 19:28:19 -06:00
parent 19fab0b814
commit da0e203942
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
fs/xfs/xfs_fsops.c
View File

@ -140,9 +140,13 @@ xfs_growfs_data_private(
return -EINVAL;
}
error = xfs_trans_alloc(mp, &M_RES(mp)->tr_growdata,
(delta > 0 ? XFS_GROWFS_SPACE_RES(mp) : -delta), 0,
XFS_TRANS_RESERVE, &tp);
if (delta > 0)
error = xfs_trans_alloc(mp, &M_RES(mp)->tr_growdata,
XFS_GROWFS_SPACE_RES(mp), 0, XFS_TRANS_RESERVE,
&tp);
else
error = xfs_trans_alloc(mp, &M_RES(mp)->tr_growdata, -delta, 0,
0, &tp);
if (error)
return error;