qiurui
/
Centos-kernel-stream-9
mirror of https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

io_uring: do not allow multishot read to set addr or len 

JIRA: https://issues.redhat.com/browse/RHEL-27755

commit 49fbe99486786661994a55ced855c31d966bbdf0
Author: Dylan Yudaken <dyudaken@gmail.com>
Date:   Mon Nov 6 20:39:08 2023 +0000

    io_uring: do not allow multishot read to set addr or len
    
    For addr: this field is not used, since buffer select is forced.
    But by forcing it to be zero it leaves open future uses of the field.
    
    len is actually usable, you could imagine that you want to receive
    multishot up to a certain length.
    However right now this is not how it is implemented, and it seems
    safer to force this to be zero.
    
    Fixes: fc68fcda0491 ("io_uring/rw: add support for IORING_OP_READ_MULTISHOT")
    Signed-off-by: Dylan Yudaken <dyudaken@gmail.com>
    Link: https://lore.kernel.org/r/20231106203909.197089-3-dyudaken@gmail.com
    Signed-off-by: Jens Axboe <axboe@kernel.dk>

Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
This commit is contained in:
Jeff Moyer 2023-11-06 20:39:08 +00:00
parent 7b3b4276a9
commit d99eee7ea7
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
io_uring/rw.c
View File

@ -143,6 +143,7 @@ int io_prep_rw_fixed(struct io_kiocb *req, const struct io_uring_sqe *sqe)
*/
int io_read_mshot_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
{
struct io_rw *rw = io_kiocb_to_cmd(req, struct io_rw);
int ret;
/* must be used with provided buffers */
@ -153,6 +154,9 @@ int io_read_mshot_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
if (unlikely(ret))
return ret;
if (rw->addr || rw->len)
return -EINVAL;
req->flags |= REQ_F_APOLL_MULTISHOT;
return 0;
}