usb: cdns3: skip set TRB_IOC when usb_request: no_interrupt is true

JIRA: https://issues.redhat.com/browse/RHEL-54566

commit 7836be3b100cfc6db3db7ddeb985254bfe1775e4
Author: Frank Li <Frank.Li@nxp.com>
Date:   Fri Oct 27 14:39:19 2023 -0400

    usb: cdns3: skip set TRB_IOC when usb_request: no_interrupt is true

    No completion irq is needed if no_interrupt is true. Needn't set TRB_IOC
    at this case.

    Check usb_request: no_interrupt and set/skip TRB_IOC in
    cdns3_ep_run_transfer().

    Signed-off-by: Frank Li <Frank.Li@nxp.com>
    Acked-by: Peter Chen <peter.chen@kernel.org>
    Link: https://lore.kernel.org/r/20231027183919.664271-1-Frank.Li@nxp.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: Martin McConnell <mmcconne@redhat.com>
This commit is contained in:
Martin McConnell 2024-08-30 12:21:45 +01:00
parent 13cefbe9cd
commit d6b454b89c
1 changed files with 4 additions and 3 deletions

View File

@ -1126,6 +1126,7 @@ static int cdns3_ep_run_transfer(struct cdns3_endpoint *priv_ep,
u16 total_tdl = 0;
struct scatterlist *s = NULL;
bool sg_supported = !!(request->num_mapped_sgs);
u32 ioc = request->no_interrupt ? 0 : TRB_IOC;
if (priv_ep->type == USB_ENDPOINT_XFER_ISOC)
num_trb = priv_ep->interval;
@ -1235,11 +1236,11 @@ static int cdns3_ep_run_transfer(struct cdns3_endpoint *priv_ep,
control |= pcs;
if (priv_ep->type == USB_ENDPOINT_XFER_ISOC && !priv_ep->dir) {
control |= TRB_IOC | TRB_ISP;
control |= ioc | TRB_ISP;
} else {
/* for last element in TD or in SG list */
if (sg_iter == (num_trb - 1) && sg_iter != 0)
control |= pcs | TRB_IOC | TRB_ISP;
control |= pcs | ioc | TRB_ISP;
}
if (sg_iter)
@ -1270,7 +1271,7 @@ static int cdns3_ep_run_transfer(struct cdns3_endpoint *priv_ep,
priv_req->num_of_trb = num_trb;
if (sg_iter == 1)
trb->control |= cpu_to_le32(TRB_IOC | TRB_ISP);
trb->control |= cpu_to_le32(ioc | TRB_ISP);
if (priv_dev->dev_ver < DEV_VER_V2 &&
(priv_ep->flags & EP_TDLCHK_EN)) {