wifi: wireless: avoid strlen() in cfg80211_michael_mic_failure()
JIRA: https://issues.redhat.com/browse/RHEL-34696 commit 7f78840cf4d4ac9ab36ddf574a025a45835375d0 Author: Dmitry Antipov <dmantipov@yandex.ru> Date: Wed Jan 10 08:42:06 2024 +0300 wifi: wireless: avoid strlen() in cfg80211_michael_mic_failure() In 'cfg80211_michael_mic_failure()', avoid extra call to 'strlen()' by using the value returned by 'sprintf()'. Compile tested only. Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru> Link: https://msgid.link/20240110054246.371651-1-dmantipov@yandex.ru Signed-off-by: Johannes Berg <johannes.berg@intel.com> Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
This commit is contained in:
parent
d7041c079d
commit
d0cb8c2b30
|
@ -241,12 +241,12 @@ void cfg80211_michael_mic_failure(struct net_device *dev, const u8 *addr,
|
|||
char *buf = kmalloc(128, gfp);
|
||||
|
||||
if (buf) {
|
||||
sprintf(buf, "MLME-MICHAELMICFAILURE.indication("
|
||||
"keyid=%d %scast addr=%pM)", key_id,
|
||||
key_type == NL80211_KEYTYPE_GROUP ? "broad" : "uni",
|
||||
addr);
|
||||
memset(&wrqu, 0, sizeof(wrqu));
|
||||
wrqu.data.length = strlen(buf);
|
||||
wrqu.data.length =
|
||||
sprintf(buf, "MLME-MICHAELMICFAILURE."
|
||||
"indication(keyid=%d %scast addr=%pM)",
|
||||
key_id, key_type == NL80211_KEYTYPE_GROUP
|
||||
? "broad" : "uni", addr);
|
||||
wireless_send_event(dev, IWEVCUSTOM, &wrqu, buf);
|
||||
kfree(buf);
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue