qiurui
/
Centos-kernel-stream-9
mirror of https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

rcu: Fix late wakeup when flush of bypass cblist happens 

JIRA: https://issues.redhat.com/browse/RHEL-5228

commit b50606f35f4b73c8e4c6b9c64fe7ba72ea919134
Author: Joel Fernandes (Google) <joel@joelfernandes.org>
Date:   Sat, 17 Sep 2022 16:41:59 +0000

    rcu: Fix late wakeup when flush of bypass cblist happens

    When the bypass cblist gets too big or its timeout has occurred, it is
    flushed into the main cblist. However, the bypass timer is still running
    and the behavior is that it would eventually expire and wake the GP
    thread.

    Since we are going to use the bypass cblist for lazy CBs, do the wakeup
    soon as the flush for "too big or too long" bypass list happens.
    Otherwise, long delays can happen for callbacks which get promoted from
    lazy to non-lazy.

    This is a good thing to do anyway (regardless of future lazy patches),
    since it makes the behavior consistent with behavior of other code paths
    where flushing into the ->cblist makes the GP kthread into a
    non-sleeping state quickly.

    [ Frederic Weisbecker: Changes to avoid unnecessary GP-thread wakeups plus
                        comment changes. ]

    Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
    Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
    Signed-off-by: Paul E. McKenney <paulmck@kernel.org>

Signed-off-by: Waiman Long <longman@redhat.com>
This commit is contained in:
Waiman Long 2023-09-22 13:21:09 -04:00
parent e92ffafa13
commit baf7a2fda7
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
kernel/rcu/tree_nocb.h
View File

@ -433,8 +433,9 @@ static bool rcu_nocb_try_bypass(struct rcu_data *rdp, struct rcu_head *rhp,
if ((ncbs && j != READ_ONCE(rdp->nocb_bypass_first)) ||
ncbs >= qhimark) {
rcu_nocb_lock(rdp);
*was_alldone = !rcu_segcblist_pend_cbs(&rdp->cblist);
if (!rcu_nocb_flush_bypass(rdp, rhp, j)) {
*was_alldone = !rcu_segcblist_pend_cbs(&rdp->cblist);
if (*was_alldone)
trace_rcu_nocb_wake(rcu_state.name, rdp->cpu,
TPS("FirstQ"));
@ -447,7 +448,12 @@ static bool rcu_nocb_try_bypass(struct rcu_data *rdp, struct rcu_head *rhp,
rcu_advance_cbs_nowake(rdp->mynode, rdp);
rdp->nocb_gp_adv_time = j;
}
rcu_nocb_unlock_irqrestore(rdp, flags);
// The flush succeeded and we moved CBs into the regular list.
// Don't wait for the wake up timer as it may be too far ahead.
// Wake up the GP thread now instead, if the cblist was empty.
__call_rcu_nocb_wake(rdp, *was_alldone, flags);
return true; // Callback already enqueued.
}