From b88b437ef57b009bb20aa0184e836b51f7b7d224 Mon Sep 17 00:00:00 2001 From: Maurizio Lombardi Date: Wed, 13 Mar 2024 16:24:51 +0100 Subject: [PATCH] nvme: take const cmd pointer in read-only helpers JIRA: https://issues.redhat.com/browse/RHEL-25547 nvme_is_fabrics() and nvme_is_write() only read struct nvme_command, so take it by const pointer. This allows callers to pass a const pointer and communicates that these functions don't modify the command. Signed-off-by: Caleb Sander Reviewed-by: Chaitanya Kulkarni Reviewed-by: Christoph Hellwig Reviewed-by: Sagi Grimberg Signed-off-by: Keith Busch (cherry picked from commit f9e9115d0c014dec3278d68823eaff159f98f4d6) Signed-off-by: Maurizio Lombardi --- include/linux/nvme.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/nvme.h b/include/linux/nvme.h index 4697533dfa02..e70b692181a2 100644 --- a/include/linux/nvme.h +++ b/include/linux/nvme.h @@ -1798,7 +1798,7 @@ struct nvme_command { }; }; -static inline bool nvme_is_fabrics(struct nvme_command *cmd) +static inline bool nvme_is_fabrics(const struct nvme_command *cmd) { return cmd->common.opcode == nvme_fabrics_command; } @@ -1817,7 +1817,7 @@ struct nvme_error_slot { __u8 resv2[24]; }; -static inline bool nvme_is_write(struct nvme_command *cmd) +static inline bool nvme_is_write(const struct nvme_command *cmd) { /* * What a mess...