qiurui
/
Centos-kernel-stream-9
mirror of https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

mm/dmapool.c: revert "make dma pool to use kmalloc_node" 

Bugzilla: https://bugzilla.redhat.com/2120352

commit cc6266f0322fa9f7f4543564759e881d989ad866
Author: Christian König <christian.koenig@amd.com>
Date:   Fri Jan 14 14:06:54 2022 -0800

    mm/dmapool.c: revert "make dma pool to use kmalloc_node"

    This reverts commit 2618c60b8b ("dma: make dma pool to use
    kmalloc_node").

    While working myself into the dmapool code I've found this little odd
    kmalloc_node().

    What basically happens here is that we allocate the housekeeping
    structure on the numa node where the device is attached to.  Since the
    device is never doing DMA to or from that memory this doesn't seem to
    make sense at all.

    So while this doesn't seem to cause much harm it's probably cleaner to
    revert the change for consistency.

    Link: https://lkml.kernel.org/r/20211221110724.97664-1-christian.koenig@amd.com
    Signed-off-by: Christian König <christian.koenig@amd.com>
    Cc: Yinghai Lu <yinghai.lu@sun.com>
    Cc: Andi Kleen <ak@suse.de>
    Cc: Christoph Lameter <clameter@sgi.com>
    Cc: David Rientjes <rientjes@google.com>
    Cc: Greg KH <greg@kroah.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Signed-off-by: Chris von Recklinghausen <crecklin@redhat.com>
This commit is contained in:
Chris von Recklinghausen 2022-10-12 07:08:46 -04:00
parent 6a201920b9
commit b756b2d174
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
mm/dmapool.c
View File

@ -152,7 +152,7 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev,
else if ((boundary < size) || (boundary & (boundary - 1)))
return NULL;
retval = kmalloc_node(sizeof(*retval), GFP_KERNEL, dev_to_node(dev));
retval = kmalloc(sizeof(*retval), GFP_KERNEL);
if (!retval)
return retval;