qiurui
/
Centos-kernel-stream-9
mirror of https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

usb: dwc3-qcom: Convert to platform remove callback returning void 

JIRA: https://issues.redhat.com/browse/RHEL-28809

commit d662268dcca8c0ec72e0bf0b49738a3c0226a254
Author: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Date: Thu May 18 01:01:22 2023 +0200

  The .remove() callback for a platform driver returns an int which makes
  many driver authors wrongly assume it's possible to do error handling by
  returning an error code. However the value returned is ignored (apart from
  emitting a warning) and this typically results in resource leaks. To improve
  here there is a quest to make the remove callback return void. In the first
  step of this quest all drivers are converted to .remove_new() which already
  returns void. Eventually after all drivers are converted, .remove_new() is
  renamed to .remove().

  Trivially convert this driver from always returning zero in the remove
  callback to the void returning variant.

  Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
  Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
  Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
  Link: https://lore.kernel.org/r/20230517230239.187727-21-u.kleine-koenig@pengutronix.de
  Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: Desnes Nunes <desnesn@redhat.com>
This commit is contained in:
Desnes Nunes 2024-03-28 21:43:46 -03:00
parent 46761ba3b1
commit b21ca7a335
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/usb/dwc3/dwc3-qcom.c
View File

@ -947,7 +947,7 @@ reset_assert:
return ret;
}
static int dwc3_qcom_remove(struct platform_device *pdev)
static void dwc3_qcom_remove(struct platform_device *pdev)
{
struct dwc3_qcom *qcom = platform_get_drvdata(pdev);
struct device *dev = &pdev->dev;
@ -967,8 +967,6 @@ static int dwc3_qcom_remove(struct platform_device *pdev)
pm_runtime_allow(dev);
pm_runtime_disable(dev);
return 0;
}
static int __maybe_unused dwc3_qcom_pm_suspend(struct device *dev)
@ -1061,7 +1059,7 @@ MODULE_DEVICE_TABLE(acpi, dwc3_qcom_acpi_match);
static struct platform_driver dwc3_qcom_driver = {
.probe = dwc3_qcom_probe,
.remove = dwc3_qcom_remove,
.remove_new = dwc3_qcom_remove,
.driver = {
.name = "dwc3-qcom",
.pm = &dwc3_qcom_dev_pm_ops,