qiurui
/
Centos-kernel-stream-9
mirror of https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

idpf: call set_real_num_queues in idpf_open 

JIRA: https://issues.redhat.com/browse/RHEL-68688

commit 52c11d31b5a1d1c747bb5f36cc4808e93e2348f4
Author: Joshua Hay <joshua.a.hay@intel.com>
Date:   Tue Feb 4 18:08:11 2025 -0800

    idpf: call set_real_num_queues in idpf_open

    On initial driver load, alloc_etherdev_mqs is called with whatever max
    queue values are provided by the control plane. However, if the driver
    is loaded on a system where num_online_cpus() returns less than the max
    queues, the netdev will think there are more queues than are actually
    available. Only num_online_cpus() will be allocated, but
    skb_get_queue_mapping(skb) could possibly return an index beyond the
    range of allocated queues. Consequently, the packet is silently dropped
    and it appears as if TX is broken.

    Set the real number of queues during open so the netdev knows how many
    queues will be allocated.

    Fixes: 1c325aac10a8 ("idpf: configure resources for TX queues")
    Signed-off-by: Joshua Hay <joshua.a.hay@intel.com>
    Reviewed-by: Madhu Chittim <madhu.chittim@intel.com>
    Tested-by: Samuel Salin <Samuel.salin@intel.com>
    Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>

Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
This commit is contained in:
Michal Schmidt 2025-02-14 10:49:49 +01:00
parent 5ba435c29b
commit b0df072c74
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/ethernet/intel/idpf/idpf_lib.c
View File

@ -2159,8 +2159,13 @@ static int idpf_open(struct net_device *netdev)
idpf_vport_ctrl_lock(netdev);
vport = idpf_netdev_to_vport(netdev);
err = idpf_set_real_num_queues(vport);
if (err)
goto unlock;
err = idpf_vport_open(vport);
unlock:
idpf_vport_ctrl_unlock(netdev);
return err;