qiurui
/
Centos-kernel-stream-9
mirror of https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

net: phy: dp83869: fix memory corruption when enabling fiber 

JIRA: https://issues.redhat.com/browse/RHEL-57766

commit a842e443ca8184f2dc82ab307b43a8b38defd6a5
Author: Ingo van Lil <inguin@gmx.de>
Date:   Wed Oct 2 18:18:07 2024 +0200

    net: phy: dp83869: fix memory corruption when enabling fiber

    When configuring the fiber port, the DP83869 PHY driver incorrectly
    calls linkmode_set_bit() with a bit mask (1 << 10) rather than a bit
    number (10). This corrupts some other memory location -- in case of
    arm64 the priv pointer in the same structure.

    Since the advertising flags are updated from supported at the end of the
    function the incorrect line isn't needed at all and can be removed.

    Fixes: a29de52ba2 ("net: dp83869: Add ability to advertise Fiber connection")
    Signed-off-by: Ingo van Lil <inguin@gmx.de>
    Reviewed-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
    Reviewed-by: Andrew Lunn <andrew@lunn.ch>
    Link: https://patch.msgid.link/20241002161807.440378-1-inguin@gmx.de
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Signed-off-by: Izabela Bakollari <ibakolla@redhat.com>
This commit is contained in:
Izabela Bakollari 2024-11-26 13:08:14 +01:00
parent a04f1db914
commit a473807a1a
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/net/phy/dp83869.c
View File

@ -645,7 +645,6 @@ static int dp83869_configure_fiber(struct phy_device *phydev,
phydev->supported);
linkmode_set_bit(ETHTOOL_LINK_MODE_FIBRE_BIT, phydev->supported);
linkmode_set_bit(ADVERTISED_FIBRE, phydev->advertising);
if (dp83869->mode == DP83869_RGMII_1000_BASE) {
linkmode_set_bit(ETHTOOL_LINK_MODE_1000baseX_Full_BIT,