qiurui
/
Centos-kernel-stream-9
mirror of https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

wifi: iwlwifi: mvm: use correct sta ID for IGTK/BIGTK 

JIRA: https://issues.redhat.com/browse/RHEL-19746

commit 63ef576c9facf5d92702e249ad213fa73eb434bf
Author: Johannes Berg <johannes.berg@intel.com>
Date:   Tue Sep 26 11:07:20 2023 +0300

    wifi: iwlwifi: mvm: use correct sta ID for IGTK/BIGTK
    
    We don't (yet) send the IGTK down to the firmware, but when
    we do it needs to be with the broadcast station ID, not the
    multicast station ID. Same for the BIGTK, which we may send
    already if firmware advertises it (but it doesn't yet.)
    
    Fixes: a5de7de7e78e ("wifi: iwlwifi: mvm: enable TX beacon protection")
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>
    Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
    Link: https://lore.kernel.org/r/20230926110319.dbc653913353.I82e90c86010f0b9588a180d9835fd11f666f5196@changeid
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
This commit is contained in:
Jose Ignacio Tornos Martinez 2024-02-01 15:29:42 +01:00
parent 5b91cee742
commit 904e9a6fd6
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/net/wireless/intel/iwlwifi/mvm/mld-key.c
View File

@ -24,10 +24,15 @@ static u32 iwl_mvm_get_sec_sta_mask(struct iwl_mvm *mvm,
return 0;
}
/* AP group keys are per link and should be on the mcast STA */
/* AP group keys are per link and should be on the mcast/bcast STA */
if (vif->type == NL80211_IFTYPE_AP &&
!(keyconf->flags & IEEE80211_KEY_FLAG_PAIRWISE))
!(keyconf->flags & IEEE80211_KEY_FLAG_PAIRWISE)) {
/* IGTK/BIGTK to bcast STA */
if (keyconf->keyidx >= 4)
return BIT(link_info->bcast_sta.sta_id);
/* GTK for data to mcast STA */
return BIT(link_info->mcast_sta.sta_id);
}
/* for client mode use the AP STA also for group keys */
if (!sta && vif->type == NL80211_IFTYPE_STATION)