From 8dd87d24f09787327146bd18f90e4c6bfc60594e Mon Sep 17 00:00:00 2001 From: Mark Langsdorf Date: Mon, 2 May 2022 15:49:19 -0400 Subject: [PATCH] device property: Drop redundant NULL checks Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2067252 commit 27e0bcd02990f7291adb0f111e300f06c495d509 Author: Andy Shevchenko Date: Tue, 26 Oct 2021 19:29:54 +0300 In cases when functions are called via fwnode operations, we already know that this is software node we are dealing with, hence no need to check if it's NULL, it can't be, Reported-by: YE Chengfeng Reviewed-by: Rafael J. Wysocki Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20211026162954.89811-1-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Mark Langsdorf --- drivers/base/swnode.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c index 7bd0f3cfb7eb..e5b498ebd915 100644 --- a/drivers/base/swnode.c +++ b/drivers/base/swnode.c @@ -413,9 +413,6 @@ software_node_get_name(const struct fwnode_handle *fwnode) { const struct swnode *swnode = to_swnode(fwnode); - if (!swnode) - return "(null)"; - return kobject_name(&swnode->kobj); } @@ -507,9 +504,6 @@ software_node_get_reference_args(const struct fwnode_handle *fwnode, int error; int i; - if (!swnode) - return -ENOENT; - prop = property_entry_get(swnode->node->properties, propname); if (!prop) return -ENOENT;