qiurui
/
Centos-kernel-stream-9
mirror of https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

platform/chrome: cros_ec: Fix leak in sequence_store() 

The allocated cros_ec_command message structure is not freed in function
sequence_store(). Make sure that 'msg' is freed in all exit paths.
Detected by Coverity CID 1309667.

Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: Olof Johansson <olof@lixom.net>
This commit is contained in:
Christian Engelmayer 2015-07-18 19:30:33 +02:00 committed by Olof Johansson
parent 23ecee32b9
commit 88dfb8b43d
1 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
drivers/platform/chrome/cros_ec_lightbar.c
View File

@ -352,10 +352,6 @@ static ssize_t sequence_store(struct device *dev, struct device_attribute *attr,
struct cros_ec_dev *ec = container_of(dev, struct cros_ec_dev *ec = container_of(dev,
struct cros_ec_dev, class_dev); struct cros_ec_dev, class_dev);
msg = alloc_lightbar_cmd_msg(ec);
if (!msg)
return -ENOMEM;
for (len = 0; len < count; len++) for (len = 0; len < count; len++)
if (!isalnum(buf[len])) if (!isalnum(buf[len]))
break; break;
@ -370,21 +366,30 @@ static ssize_t sequence_store(struct device *dev, struct device_attribute *attr,
return ret; return ret;
} }
msg = alloc_lightbar_cmd_msg(ec);
if (!msg)
return -ENOMEM;
param = (struct ec_params_lightbar *)msg->data; param = (struct ec_params_lightbar *)msg->data;
param->cmd = LIGHTBAR_CMD_SEQ; param->cmd = LIGHTBAR_CMD_SEQ;
param->seq.num = num; param->seq.num = num;
ret = lb_throttle(); ret = lb_throttle();
if (ret) if (ret)
return ret; goto exit;
ret = cros_ec_cmd_xfer(ec->ec_dev, msg); ret = cros_ec_cmd_xfer(ec->ec_dev, msg);
if (ret < 0) if (ret < 0)
return ret; goto exit;
if (msg->result != EC_RES_SUCCESS) if (msg->result != EC_RES_SUCCESS) {
return -EINVAL; ret = -EINVAL;
goto exit;
}
return count; ret = count;
exit:
kfree(msg);
return ret;
} }
/* Module initialization */ /* Module initialization */