to_shrink_list(): call only if refcount is 0
JIRA: https://issues.redhat.com/browse/RHEL-29564 commit c2e5e29f3fdaff6f57795be068ce525c60954fd0 Author: Al Viro <viro@zeniv.linux.org.uk> Date: Mon Oct 30 01:06:06 2023 -0400 to_shrink_list(): call only if refcount is 0 The only thing it does if refcount is not zero is d_lru_del(); no point, IMO, seeing that plain dput() does nothing of that sort... Note that 2 of 3 current callers are guaranteed that refcount is 0. Acked-by: Christian Brauner <brauner@kernel.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Ming Lei <ming.lei@redhat.com>
This commit is contained in:
parent
1a7fe253af
commit
87ebce96ed
|
@ -915,8 +915,7 @@ __must_hold(&dentry->d_lock)
|
|||
if (!(dentry->d_flags & DCACHE_SHRINK_LIST)) {
|
||||
if (dentry->d_flags & DCACHE_LRU_LIST)
|
||||
d_lru_del(dentry);
|
||||
if (!dentry->d_lockref.count)
|
||||
d_shrink_add(dentry, list);
|
||||
d_shrink_add(dentry, list);
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -1110,10 +1109,8 @@ EXPORT_SYMBOL(d_prune_aliases);
|
|||
static inline void shrink_kill(struct dentry *victim, struct list_head *list)
|
||||
{
|
||||
struct dentry *parent = victim->d_parent;
|
||||
if (parent != victim) {
|
||||
--parent->d_lockref.count;
|
||||
if (parent != victim && !--parent->d_lockref.count)
|
||||
to_shrink_list(parent, list);
|
||||
}
|
||||
__dentry_kill(victim);
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue