Add skb drop reasons to IPv6 UDP receive path
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2059161 Upstream Status: net-next.git commit 0d92efdee9152e400aa973229861c3cb84069a98 Author: Donald Hunter <donald.hunter@redhat.com> Date: Mon Sep 26 13:03:50 2022 +0100 Add skb drop reasons to IPv6 UDP receive path Enumerate the skb drop reasons in the receive path for IPv6 UDP packets. Signed-off-by: Donald Hunter <donald.hunter@redhat.com> Link: https://lore.kernel.org/r/20220926120350.14928-1-donald.hunter@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Antoine Tenart <atenart@redhat.com>
This commit is contained in:
parent
6f2e7329d3
commit
869ad52bd6
|
@ -645,16 +645,20 @@ static int __udpv6_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)
|
|||
rc = __udp_enqueue_schedule_skb(sk, skb);
|
||||
if (rc < 0) {
|
||||
int is_udplite = IS_UDPLITE(sk);
|
||||
enum skb_drop_reason drop_reason;
|
||||
|
||||
/* Note that an ENOMEM error is charged twice */
|
||||
if (rc == -ENOMEM)
|
||||
if (rc == -ENOMEM) {
|
||||
UDP6_INC_STATS(sock_net(sk),
|
||||
UDP_MIB_RCVBUFERRORS, is_udplite);
|
||||
else
|
||||
drop_reason = SKB_DROP_REASON_SOCKET_RCVBUFF;
|
||||
} else {
|
||||
UDP6_INC_STATS(sock_net(sk),
|
||||
UDP_MIB_MEMERRORS, is_udplite);
|
||||
drop_reason = SKB_DROP_REASON_PROTO_MEM;
|
||||
}
|
||||
UDP6_INC_STATS(sock_net(sk), UDP_MIB_INERRORS, is_udplite);
|
||||
kfree_skb(skb);
|
||||
kfree_skb_reason(skb, drop_reason);
|
||||
return -1;
|
||||
}
|
||||
|
||||
|
@ -670,11 +674,14 @@ static __inline__ int udpv6_err(struct sk_buff *skb,
|
|||
|
||||
static int udpv6_queue_rcv_one_skb(struct sock *sk, struct sk_buff *skb)
|
||||
{
|
||||
enum skb_drop_reason drop_reason = SKB_DROP_REASON_NOT_SPECIFIED;
|
||||
struct udp_sock *up = udp_sk(sk);
|
||||
int is_udplite = IS_UDPLITE(sk);
|
||||
|
||||
if (!xfrm6_policy_check(sk, XFRM_POLICY_IN, skb))
|
||||
if (!xfrm6_policy_check(sk, XFRM_POLICY_IN, skb)) {
|
||||
drop_reason = SKB_DROP_REASON_XFRM_POLICY;
|
||||
goto drop;
|
||||
}
|
||||
|
||||
if (static_branch_unlikely(&udpv6_encap_needed_key) && up->encap_type) {
|
||||
int (*encap_rcv)(struct sock *sk, struct sk_buff *skb);
|
||||
|
@ -733,8 +740,10 @@ static int udpv6_queue_rcv_one_skb(struct sock *sk, struct sk_buff *skb)
|
|||
udp_lib_checksum_complete(skb))
|
||||
goto csum_error;
|
||||
|
||||
if (sk_filter_trim_cap(sk, skb, sizeof(struct udphdr)))
|
||||
if (sk_filter_trim_cap(sk, skb, sizeof(struct udphdr))) {
|
||||
drop_reason = SKB_DROP_REASON_SOCKET_FILTER;
|
||||
goto drop;
|
||||
}
|
||||
|
||||
udp_csum_pull_header(skb);
|
||||
|
||||
|
@ -743,11 +752,12 @@ static int udpv6_queue_rcv_one_skb(struct sock *sk, struct sk_buff *skb)
|
|||
return __udpv6_queue_rcv_skb(sk, skb);
|
||||
|
||||
csum_error:
|
||||
drop_reason = SKB_DROP_REASON_UDP_CSUM;
|
||||
__UDP6_INC_STATS(sock_net(sk), UDP_MIB_CSUMERRORS, is_udplite);
|
||||
drop:
|
||||
__UDP6_INC_STATS(sock_net(sk), UDP_MIB_INERRORS, is_udplite);
|
||||
atomic_inc(&sk->sk_drops);
|
||||
kfree_skb(skb);
|
||||
kfree_skb_reason(skb, drop_reason);
|
||||
return -1;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue