qiurui
/
Centos-kernel-stream-9
mirror of https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

hwmon: (lm90) Prevent integer overflow/underflow in hysteresis calculations 

JIRA: https://issues.redhat.com/browse/RHEL-28126
CVE: CVE-2021-47098

commit 55840b9eae5367b5d5b29619dc2fb7e4596dba46
Author: Guenter Roeck <linux@roeck-us.net>
Date:   Wed Nov 17 09:51:47 2021 -0800

    hwmon: (lm90) Prevent integer overflow/underflow in hysteresis calculations

    Commit b50aa49638 ("hwmon: (lm90) Prevent integer underflows of
    temperature calculations") addressed a number of underflow situations
    when writing temperature limits. However, it missed one situation, seen
    when an attempt is made to set the hysteresis value to MAX_LONG and the
    critical temperature limit is negative.

    Use clamp_val() when setting the hysteresis temperature to ensure that
    the provided value can never overflow or underflow.

    Fixes: b50aa49638 ("hwmon: (lm90) Prevent integer underflows of temperature calculations")
    Cc: Dmitry Osipenko <digetx@gmail.com>
    Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Signed-off-by: David Arcari <darcari@redhat.com>
This commit is contained in:
David Arcari 2024-03-11 13:27:39 -04:00
parent 958d4fc8fa
commit 774d7ecde1
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/hwmon/lm90.c
View File

@ -1143,8 +1143,8 @@ static int lm90_set_temphyst(struct lm90_data *data, long val)
else
temp = temp_from_s8(data->temp8[LOCAL_CRIT]);
/* prevent integer underflow */
val = max(val, -128000l);
/* prevent integer overflow/underflow */
val = clamp_val(val, -128000l, 255000l);
data->temp_hyst = hyst_to_reg(temp - val);
err = i2c_smbus_write_byte_data(client, LM90_REG_W_TCRIT_HYST,