qiurui
/
Centos-kernel-stream-9
mirror of https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

rtc: st-lpc: Use IRQF_NO_AUTOEN flag in request_irq() 

JIRA: https://issues.redhat.com/browse/RHEL-72448

commit b6cd7adec0cf03f0aefc55676e71dd721cbc71a8
Author: Jinjie Ruan <ruanjinjie@huawei.com>
Date:   Thu, 12 Sep 2024 11:37:27 +0800

    rtc: st-lpc: Use IRQF_NO_AUTOEN flag in request_irq()

    If request_irq() fails in st_rtc_probe(), there is no need to enable
    the irq, and if it succeeds, disable_irq() after request_irq() still has
    a time gap in which interrupts can come.

    request_irq() with IRQF_NO_AUTOEN flag will disable IRQ auto-enable when
    request IRQ.

    Fixes: b5b2bdfc28 ("rtc: st: Add new driver for ST's LPC RTC")
    Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
    Link: https://lore.kernel.org/r/20240912033727.3013951-1-ruanjinjie@huawei.com
    Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

Signed-off-by: Waiman Long <longman@redhat.com>
This commit is contained in:
Waiman Long 2025-01-07 13:16:40 -05:00
parent f6da46602f
commit 75167350ba
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/rtc/rtc-st-lpc.c
View File

@ -218,15 +218,14 @@ static int st_rtc_probe(struct platform_device *pdev)
return -EINVAL;
}
ret = devm_request_irq(&pdev->dev, rtc->irq, st_rtc_handler, 0,
pdev->name, rtc);
ret = devm_request_irq(&pdev->dev, rtc->irq, st_rtc_handler,
IRQF_NO_AUTOEN, pdev->name, rtc);
if (ret) {
dev_err(&pdev->dev, "Failed to request irq %i\n", rtc->irq);
return ret;
}
enable_irq_wake(rtc->irq);
disable_irq(rtc->irq);
rtc->clk = devm_clk_get_enabled(&pdev->dev, NULL);
if (IS_ERR(rtc->clk))