io_uring/register: use atomic_read/write for sq_flags migration

JIRA: https://issues.redhat.com/browse/RHEL-105612

commit a23ad06bfee5e51cd9e51aebf11401e7b4b5d00a
Author: Jens Axboe <axboe@kernel.dk>
Date:   Fri Jan 24 14:32:25 2025 -0700

    io_uring/register: use atomic_read/write for sq_flags migration
    
    A previous commit changed all of the migration from the old to the new
    ring for resizing to use READ/WRITE_ONCE. However, ->sq_flags is an
    atomic_t, and while most archs won't complain on this, some will indeed
    flag this:
    
    io_uring/register.c:554:9: sparse: sparse: cast to non-scalar
    io_uring/register.c:554:9: sparse: sparse: cast from non-scalar
    
    Just use atomic_set/atomic_read for handling this case.
    
    Reported-by: kernel test robot <lkp@intel.com>
    Closes: https://lore.kernel.org/oe-kbuild-all/202501242000.A2sKqaCL-lkp@intel.com/
    Fixes: 2c5aae129f42 ("io_uring/register: document io_register_resize_rings() shared mem usage")
    Signed-off-by: Jens Axboe <axboe@kernel.dk>

Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
This commit is contained in:
Jeff Moyer
2025-10-27 13:08:30 -04:00
parent ca4c960b5e
commit 7278b9d8cd
+1 -1
View File
@@ -552,7 +552,7 @@ overflow:
ctx->cqe_cached = ctx->cqe_sentinel = NULL;
WRITE_ONCE(n.rings->sq_dropped, READ_ONCE(o.rings->sq_dropped));
WRITE_ONCE(n.rings->sq_flags, READ_ONCE(o.rings->sq_flags));
atomic_set(&n.rings->sq_flags, atomic_read(&o.rings->sq_flags));
WRITE_ONCE(n.rings->cq_flags, READ_ONCE(o.rings->cq_flags));
WRITE_ONCE(n.rings->cq_overflow, READ_ONCE(o.rings->cq_overflow));