From 62d41291d0b985ddb9b304f0a0406fbc5b6879f5 Mon Sep 17 00:00:00 2001 From: Steve Best Date: Fri, 13 May 2022 15:09:49 -0400 Subject: [PATCH] regulator: virtual: warn against production use Bugzilla: http://bugzilla.redhat.com/2071777 commit d2fb5487ecb2a28b61ff261ae18488afc98d24a6 Author: Vincent Whitchurch Date: Tue Mar 1 12:18:30 2022 +0100 regulator: virtual: warn against production use This driver is only meant for debugging and testing. Currently, it's not possible to use it without patching the kernel since it requires platform data, but we'll be adding devicetree support, so add a loud warning to make it clear that it's still only meant for debugging and testing. Signed-off-by: Vincent Whitchurch Link: https://lore.kernel.org/r/20220301111831.3742383-3-vincent.whitchurch@axis.com Signed-off-by: Mark Brown Signed-off-by: Steve Best --- drivers/regulator/virtual.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/regulator/virtual.c b/drivers/regulator/virtual.c index 50d2e9caaa71..9e0abbee1df5 100644 --- a/drivers/regulator/virtual.c +++ b/drivers/regulator/virtual.c @@ -285,8 +285,21 @@ static int regulator_virtual_probe(struct platform_device *pdev) { char *reg_id = dev_get_platdata(&pdev->dev); struct virtual_consumer_data *drvdata; + static bool warned; int ret; + if (!warned) { + warned = true; + pr_warn("**********************************************************\n"); + pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n"); + pr_warn("** **\n"); + pr_warn("** regulator-virtual-consumer is only for testing and **\n"); + pr_warn("** debugging. Do not use it in a production kernel. **\n"); + pr_warn("** **\n"); + pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n"); + pr_warn("**********************************************************\n"); + } + drvdata = devm_kzalloc(&pdev->dev, sizeof(struct virtual_consumer_data), GFP_KERNEL); if (drvdata == NULL)