qiurui
/
Centos-kernel-stream-9
mirror of https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

remoteproc: k3-dsp: Use devm_rproc_add() helper 

JIRA: https://issues.redhat.com/browse/RHEL-60788

commit 456a75ab51967c4c594519795a9f49c40662c291
Author: Andrew Davis <afd@ti.com>
Date:   Mon Feb 5 12:27:53 2024 -0600

    remoteproc: k3-dsp: Use devm_rproc_add() helper

    Use device lifecycle managed devm_rproc_add() helper function. This helps
    prevent mistakes like deleting out of order in cleanup functions and
    forgetting to delete on all error paths.

    Signed-off-by: Andrew Davis <afd@ti.com>
    Link: https://lore.kernel.org/r/20240205182753.36978-6-afd@ti.com
    Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>

Signed-off-by: Jared Kangas <jkangas@redhat.com>
This commit is contained in:
Jared Kangas 2024-09-27 17:50:53 -07:00
parent bb35c82eb9
commit 60aa4be580
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/remoteproc/ti_k3_dsp_remoteproc.c
View File

@ -768,7 +768,7 @@ static int k3_dsp_rproc_probe(struct platform_device *pdev)
}
}
ret = rproc_add(rproc);
ret = devm_rproc_add(dev, rproc);
if (ret)
return dev_err_probe(dev, ret, "failed to add register device with remoteproc core\n");
@ -786,14 +786,9 @@ static void k3_dsp_rproc_remove(struct platform_device *pdev)
if (rproc->state == RPROC_ATTACHED) {
ret = rproc_detach(rproc);
if (ret) {
/* Note this error path leaks resources */
if (ret)
dev_err(dev, "failed to detach proc (%pe)\n", ERR_PTR(ret));
return;
}
}
rproc_del(kproc->rproc);
}
static const struct k3_dsp_mem_data c66_mems[] = {