qiurui
/
Centos-kernel-stream-9
mirror of https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

usb: phy: generic: Switch to use dev_err_probe() helper 

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2181663
Upstream Status: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e0b27d38ffb7552b28a993c3c7029ce89670ff5b

commit e0b27d38ffb7552b28a993c3c7029ce89670ff5b
Author: Yang Yingliang <yangyingliang@huawei.com>
Date: Thu, 22 Sep 2022 21:33:22 +0800

  In the probe path, dev_err() can be replaced with dev_err_probe()
  which will check if error code is -EPROBE_DEFER and prints the
  error name. It also sets the defer probe reason which can be
  checked later through debugfs. It's more simple in error path.

  Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
  Link: https://lore.kernel.org/r/20220922133323.2135494-1-yangyingliang@huawei.com
  Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: Desnes Nunes <desnesn@redhat.com>
This commit is contained in:
Desnes Nunes 2023-03-30 16:21:40 -03:00
parent 3c4406bc87
commit 5f40647c33
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/usb/phy/phy-generic.c
View File

@ -230,12 +230,9 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_generic *nop)
err = PTR_ERR_OR_ZERO(nop->gpiod_vbus);
}
if (err == -EPROBE_DEFER)
return -EPROBE_DEFER;
if (err) {
dev_err(dev, "Error requesting RESET or VBUS GPIO\n");
return err;
}
if (err)
return dev_err_probe(dev, err,
"Error requesting RESET or VBUS GPIO\n");
if (nop->gpiod_reset)
gpiod_direction_output(nop->gpiod_reset, 1);