qiurui
/
Centos-kernel-stream-9
mirror of https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-9.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

n_tty: Convert no_space_left to space_left boolean 

JIRA: https://issues.redhat.com/browse/RHEL-24205

commit b8abba0eb1f5b8a05e864cf00f246e1c066775a2
Author: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Date:   Thu Mar 9 10:20:28 2023 +0200

    n_tty: Convert no_space_left to space_left boolean

    The no_space_left variable is only assigned with 0 and 1.

    Change its type to boolean and move negation from its name into the
    check.

    Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
    Link: https://lore.kernel.org/r/20230309082035.14880-2-ilpo.jarvinen@linux.intel.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
This commit is contained in:
Andrew Halaney 2024-02-27 12:44:23 -06:00 committed by Derek Barbosa
parent a66f8c4d76
commit 2470433bde
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/tty/n_tty.c
View File

@ -625,7 +625,7 @@ static size_t __process_echoes(struct tty_struct *tty)
c = echo_buf(ldata, tail);
if (c == ECHO_OP_START) {
unsigned char op;
int no_space_left = 0;
bool space_left = true;
/*
* Since add_echo_byte() is called without holding
@ -664,7 +664,7 @@ static size_t __process_echoes(struct tty_struct *tty)
num_bs = 8 - (num_chars & 7);
if (num_bs > space) {
no_space_left = 1;
space_left = false;
break;
}
space -= num_bs;
@ -690,7 +690,7 @@ static size_t __process_echoes(struct tty_struct *tty)
case ECHO_OP_START:
/* This is an escaped echo op start code */
if (!space) {
no_space_left = 1;
space_left = false;
break;
}
tty_put_char(tty, ECHO_OP_START);
@ -710,7 +710,7 @@ static size_t __process_echoes(struct tty_struct *tty)
*
*/
if (space < 2) {
no_space_left = 1;
space_left = false;
break;
}
tty_put_char(tty, '^');
@ -720,7 +720,7 @@ static size_t __process_echoes(struct tty_struct *tty)
tail += 2;
}
if (no_space_left)
if (!space_left)
break;
} else {
if (O_OPOST(tty)) {