qiurui/Centos-kernel-stream-10
1
0
Fork 0
mirror of https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-10.git synced 2026-09-09 00:07:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

block: zero non-PI portion of auto integrity buffer

Browse Source 
JIRA: https://issues.redhat.com/browse/RHEL-144763

commit ca22c566b89164f6e670af56ecc45f47ef3df819
Author: Caleb Sander Mateos <csander@purestorage.com>
Date:   Thu Jan 8 10:22:10 2026 -0700

    block: zero non-PI portion of auto integrity buffer

    The auto-generated integrity buffer for writes needs to be fully
    initialized before being passed to the underlying block device,
    otherwise the uninitialized memory can be read back by userspace or
    anyone with physical access to the storage device. If protection
    information is generated, that portion of the integrity buffer is
    already initialized. The integrity data is also zeroed if PI generation
    is disabled via sysfs or the PI tuple size is 0. However, this misses
    the case where PI is generated and the PI tuple size is nonzero, but the
    metadata size is larger than the PI tuple. In this case, the remainder
    ("opaque") of the metadata is left uninitialized.
    Generalize the BLK_INTEGRITY_CSUM_NONE check to cover any case when the
    metadata is larger than just the PI tuple.

    Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
    Fixes: c546d6f438 ("block: only zero non-PI metadata tuples in bio_integrity_prep")
    Reviewed-by: Anuj Gupta <anuj20.g@samsung.com>
    Reviewed-by: Christoph Hellwig <hch@lst.de>
    Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>

Signed-off-by: Ming Lei <ming.lei@redhat.com>
This commit is contained in:
Ming Lei
2026-02-28 19:32:45 +08:00
parent e67fc2c40e
commit d9c22e7af9
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
block/bio-integrity-auto.c
+1 -1
View File
@@ -140,7 +140,7 @@ bool bio_integrity_prep(struct bio *bio)
return true; return true;
set_flags = false; set_flags = false;
gfp |= __GFP_ZERO; gfp |= __GFP_ZERO;
} else if (bi->csum_type == BLK_INTEGRITY_CSUM_NONE) } else if (bi->metadata_size > bi->pi_tuple_size)
gfp |= __GFP_ZERO; gfp |= __GFP_ZERO;
break; break;
default: default: