qiurui/Centos-kernel-stream-10
1
0
Fork 0
mirror of https://gitlab.com/redhat/centos-stream/src/kernel/centos-stream-10.git synced 2026-09-09 00:07:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

block: fix lbmd_guard_tag_type assignment in FS_IOC_GETLBMD_CAP

Browse Source 
JIRA: https://issues.redhat.com/browse/RHEL-144763

commit bc5b0c8febccbeabfefc9b59083b223ec7c7b53a
Author: Anuj Gupta <anuj20.g@samsung.com>
Date:   Tue Jul 22 17:37:55 2025 +0530

    block: fix lbmd_guard_tag_type assignment in FS_IOC_GETLBMD_CAP

    The blk_get_meta_cap() implementation directly assigns bi->csum_type to
    the UAPI field lbmd_guard_tag_type. This is not right as the kernel enum
    blk_integrity_checksum values are not guaranteed to match the UAPI
    defined values.

    Fix this by explicitly mapping internal checksum types to UAPI-defined
    constants to ensure compatibility and correctness, especially for the
    devices using CRC64 PI.

    Fixes: 9eb22f7fedfc ("fs: add ioctl to query metadata and protection info capabilities")
    Reported-by: Vincent Fu <vincent.fu@samsung.com>
    Signed-off-by: Anuj Gupta <anuj20.g@samsung.com>
    Link: https://lore.kernel.org/20250722120755.87501-1-anuj20.g@samsung.com
    Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
    Reviewed-by: Christoph Hellwig <hch@lst.de>
    Reviewed-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Christian Brauner <brauner@kernel.org>

Signed-off-by: Ming Lei <ming.lei@redhat.com>
This commit is contained in:
Ming Lei
2026-02-28 19:32:46 +08:00
parent 0067424098
commit c7ac53bdf1
1 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
block/blk-integrity.c
+15 -1
View File
@@ -83,7 +83,21 @@ int blk_get_meta_cap(struct block_device *bdev, unsigned int cmd,
if (meta_cap.lbmd_opaque_size && !bi->pi_offset)
meta_cap.lbmd_opaque_offset = bi->pi_tuple_size;
meta_cap.lbmd_guard_tag_type = bi->csum_type;
switch (bi->csum_type) {
case BLK_INTEGRITY_CSUM_NONE:
meta_cap.lbmd_guard_tag_type = LBMD_PI_CSUM_NONE;
break;
case BLK_INTEGRITY_CSUM_IP:
meta_cap.lbmd_guard_tag_type = LBMD_PI_CSUM_IP;
break;
case BLK_INTEGRITY_CSUM_CRC:
meta_cap.lbmd_guard_tag_type = LBMD_PI_CSUM_CRC16_T10DIF;
break;
case BLK_INTEGRITY_CSUM_CRC64:
meta_cap.lbmd_guard_tag_type = LBMD_PI_CSUM_CRC64_NVME;
break;
}
if (bi->csum_type != BLK_INTEGRITY_CSUM_NONE)
meta_cap.lbmd_app_tag_size = 2;